Bug 167677 - [bsd.port.mk] [exp-run] Reaper of the dead: remove depercated USE_XLIB from b.p.m
Summary: [bsd.port.mk] [exp-run] Reaper of the dead: remove depercated USE_XLIB from b...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Mark Linimon
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-07 14:30 UTC by Eitan Adler
Modified: 2012-09-06 22:10 UTC (History)
0 users

See Also:


Attachments
file.diff (1.33 KB, patch)
2012-05-07 14:30 UTC, Eitan Adler
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eitan Adler freebsd_committer freebsd_triage 2012-05-07 14:30:16 UTC
xorg team deprecated USE_XLIB a while ago and ak@ has finally thwacked them all.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-05-07 14:30:28 UTC
Responsible Changed
From-To: freebsd-ports-bugs->portmgr

bsd.port.mk is portmgr territory (via the GNATS Auto Assign Tool)
Comment 2 baptiste.daroussin 2012-05-07 15:42:52 UTC
USE_XLIB is still in used in a couple of ports pnet* for example
Comment 3 Eitan Adler freebsd_committer freebsd_triage 2012-05-07 15:56:17 UTC
On 7 May 2012 10:42, Baptiste Daroussin <baptiste.daroussin@gmail.com> wrote:
> USE_XLIB is still in used in a couple of ports pnet* for example

It is used in three ports.
pnet* and linuxpluginwrapper

Both maintainers have been contacted and they will be fixed or
deleted. I'd like to know if there is any other fallout.



-- 
Eitan Adler
Source & Ports committer
X11, Bugbusting teams
Comment 4 Mark Linimon freebsd_committer freebsd_triage 2012-08-04 05:04:07 UTC
State Changed
From-To: open->analyzed
Comment 5 Mark Linimon freebsd_committer freebsd_triage 2012-08-04 05:04:07 UTC
Responsible Changed
From-To: portmgr->linimon
Comment 6 dfilter service freebsd_committer freebsd_triage 2012-09-06 21:59:43 UTC
Author: linimon
Date: Thu Sep  6 20:59:27 2012
New Revision: 303789
URL: http://svn.freebsd.org/changeset/ports/303789

Log:
   - Remove obsolete USE_XLIB and MACHINE_ARCH definitions [1], [4]
  
   - Include top-level Makefile.inc from correct directory [2]
  
   - Add new target add-plist-buildinfo for package build details [3]
  
  PR:		ports/152871 [1]
  PR:		ports/164207 [2]
  PR:		ports/162397 [3]
  PR:		ports/167677 [4]
  
  Submitted by:	eadler [1], [4]; glarkin [2]; jhelfman@experts-exchange.com [3]

Modified:
  head/Mk/bsd.port.mk

Modified: head/Mk/bsd.port.mk
==============================================================================
--- head/Mk/bsd.port.mk	Thu Sep  6 20:16:47 2012	(r303788)
+++ head/Mk/bsd.port.mk	Thu Sep  6 20:59:27 2012	(r303789)
@@ -38,9 +38,7 @@ FreeBSD_MAINTAINER=	portmgr@FreeBSD.org
 # different actions for different values.
 #
 # ARCH			- The architecture of the target machine, such as would be
-#				  returned by "uname -p".  (Note: Ports should test against
-#				  ARCH, and not the host machine's architecture which is
-#				  MACHINE_ARCH, to enable ports to be cross-built.)
+#				  returned by "uname -p".
 # OPSYS			- Portability clause.  This is the operating system the
 #				  makefile is being used on.  Automatically set to
 #				  "FreeBSD," "NetBSD," or "OpenBSD" as appropriate.
@@ -359,8 +357,6 @@ FreeBSD_MAINTAINER=	portmgr@FreeBSD.org
 # USE_IMAKE		- If set, this port uses imake.
 # XMKMF			- Set to path of `xmkmf' if not in $PATH
 #				  Default: xmkmf -a
-# USE_XLIB		- If set, this port uses the X libraries. In the USE_LINUX
-#				  case the linux X libraries are referenced.
 # USE_DISPLAY	- If set, this ports requires a (virtual) X11 environment
 #				  setup. If the environment variable DISPLAY Is not set,
 #				  then an extra build dependency on Xvfb is added. Further,
@@ -1192,9 +1188,6 @@ MAINTAINER?=	ports@FreeBSD.org
 ARCH!=	${UNAME} -p
 .endif
 
-# Kludge for pre-3.0 systems
-MACHINE_ARCH?=	i386
-
 # Get the operating system type
 .if !defined(OPSYS)
 OPSYS!=	${UNAME} -s
@@ -2105,21 +2098,12 @@ IGNORE=	uses unknown USE_BISON construct
 .include "${PORTSDIR}/Mk/bsd.cmake.mk"
 .endif
 
-.if exists(${PORTSDIR}/../Makefile.inc)
-.include "${PORTSDIR}/../Makefile.inc"
+.if exists(${PORTSDIR}/Makefile.inc)
+.include "${PORTSDIR}/Makefile.inc"
 USE_SUBMAKE=	yes
 .endif
 
-.if defined(USE_XLIB)
-.	if defined(USE_LINUX)
-RUN_DEPENDS+=	${LINUXBASE}/usr/X11R6/lib/libXrender.so.1:${PORTSDIR}/x11/linux-xorg-libs
-.	else
-BUILD_DEPENDS+=	${LOCALBASE}/libdata/xorg/libraries:${X_LIBRARIES_PORT}
-RUN_DEPENDS+=	${LOCALBASE}/libdata/xorg/libraries:${X_LIBRARIES_PORT}
-.	endif
-.endif
-
-.if defined(USE_XLIB) || defined(USE_XORG)
+.if defined(USE_XORG)
 # Add explicit X options to avoid problems with false positives in configure
 .if defined(GNU_CONFIGURE)
 CONFIGURE_ARGS+=--x-libraries=${LOCALBASE}/lib --x-includes=${LOCALBASE}/include
@@ -4333,10 +4317,10 @@ _INSTALL_SEQ=	install-message check-inst
 _INSTALL_SUSEQ= check-umask install-mtree pre-su-install \
 				pre-su-install-script create-users-groups do-install \
 				install-desktop-entries install-license install-rc-script \
-				post-install post-install-script add-plist-info \
-				add-plist-docs add-plist-examples add-plist-data \
-				add-plist-post fix-plist-sequence compress-man \
-				install-ldconfig-file fake-pkg security-check
+				post-install post-install-script add-plist-buildinfo \
+				add-plist-info add-plist-docs add-plist-examples \
+				add-plist-data add-plist-post fix-plist-sequence \
+				compress-man install-ldconfig-file fake-pkg security-check
 _PACKAGE_DEP=	install
 _PACKAGE_SEQ=	package-message pre-package pre-package-script \
 				do-package post-package-script
@@ -5814,6 +5798,13 @@ add-plist-data:
 .endif
 .endif
 
+.if defined(PACKAGE_BUILDING)
+.if !target(add-plist-buildinfo)
+add-plist-buildinfo:
+	@${ECHO_CMD} "@comment Build details:  ${BUILDHOST}|${JAIL}|${BUILD}|${PORTSTREE}|${BUILDDATE}" >> ${TMPPLIST}
+.endif
+.endif
+
 .if !target(add-plist-info)
 add-plist-info:
 # Process GNU INFO files at package install/deinstall time
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 7 Mark Linimon freebsd_committer freebsd_triage 2012-09-06 22:02:20 UTC
State Changed
From-To: analyzed->closed

Committed, thanks.