Bug 167721 - [patch] graphics/gegl: use SSE/MMX on amd64
Summary: [patch] graphics/gegl: use SSE/MMX on amd64
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-gnome (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-09 01:00 UTC by Jan Beich
Modified: 2012-05-20 21:30 UTC (History)
0 users

See Also:


Attachments
amd64.diff (717 bytes, patch)
2012-05-09 01:00 UTC, Jan Beich
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2012-05-09 01:00:37 UTC

How-To-Repeat: --- vanilla
+++ patched
@@ -138,6 +139,12 @@ checking for dynamic library filename su
 checking for some Darwin platform... no
 checking for some Win32 platform... no
 checking for native Win32... no
+checking to see if compiler understands -mmmx... yes
+checking whether we can compile MMX code... yes
+checking to see if compiler understands -msse... yes
+checking to see if compiler understands -ftree-vectorize... yes
+checking to see if compiler understands -ffast-math... yes
+checking whether we can compile SSE code... yes
 checking for perl5... /usr/local/bin/perl5
 checking for pkg-config... /usr/local/bin/pkg-config
 checking pkg-config is at least version 0.9.0... yes
@@ -281,7 +288,7 @@ Optional features:
   GEGL docs:       no
   Build workshop:  no
   Build website:   no  (asciidoc not found)
-  SIMD:            sse: mmx:
+  SIMD:            sse:yes mmx:yes
   Vala support:    no
 
 Optional dependencies:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-05-09 01:00:53 UTC
Responsible Changed
From-To: freebsd-ports-bugs->gnome

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Jeremy Messenger freebsd_committer freebsd_triage 2012-05-20 17:39:22 UTC
State Changed
From-To: open->closed

Committed, thanks!
Comment 3 dfilter service freebsd_committer freebsd_triage 2012-05-20 17:39:22 UTC
mezz        2012-05-20 16:39:14 UTC

  FreeBSD ports repository

  Modified files:
    graphics/gegl        Makefile pkg-plist 
  Log:
  Turns gdk-pixbuf2 and jasper dependencies into optional and correct dependency
  by change from gtk20 to gdkpixbuf2. Bump the PORTREVISION.
  
  PR:             ports/167721
  Submitted by:   Jan Beich <jbeich@tormail.org>
  
  Revision  Changes    Path
  1.33      +20 -2     ports/graphics/gegl/Makefile
  1.13      +6 -6      ports/graphics/gegl/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 4 Jeremy Messenger freebsd_committer freebsd_triage 2012-05-20 17:39:46 UTC
State Changed
From-To: closed->feedback

Whoops, closed wrong PR and reopen it with feedback: 

The patch does not work and I have amd64 here. I am getting here: 

---------------------- 
# make configure 
[...] 
Building GEGL with prefix=/usr/local 

Optional features: 
GEGL docs:       no 
Build workshop:  no 
Build website:   no  (asciidoc not found) 
SIMD:            sse:no mmx:no <-- here, both are still disabled. 
Vala support:    no 
----------------------
Comment 5 Jan Beich freebsd_committer freebsd_triage 2012-05-20 21:04:48 UTC
mezz@FreeBSD.org writes:

> The patch does not work and I have amd64 here. I am getting here:
>
> ----------------------
> # make configure
> [...]
> Building GEGL with prefix=/usr/local
>
> Optional features:
>   GEGL docs:       no
>   Build workshop:  no
>   Build website:   no  (asciidoc not found)
>   SIMD:            sse:no mmx:no <-- here, both are still disabled.
>   Vala support:    no

I'm afraid you have to provide config.log for me to debug why compile
checks fail. configure.ac has the following logic:

  # s/x86_64/amd64/
  case "$target_or_host" in
    x86_64-*-*)
      have_x86=yes
      ;;
  esac

  AC_ARG_ENABLE(mmx, ...,, enable_mmx=$have_x86)
  AC_ARG_ENABLE(sse, ...,, enable_sse=$enable_mmx)

  if test "x$enable_mmx" = "xyes"; then
     AC_COMPILE_IFELSE(<mmx check>,
       if test "x$enable_sse" = "xyes"; then
           AC_COMPILE_IFELSE(<sse check>,, enable_sse=no)
       fi
     , enable_mmx=no)
  fi

Also, there is no point in testing with OPTIMIZE turned OFF.
Comment 6 mezz.freebsd 2012-05-20 21:20:00 UTC
On Sun, May 20, 2012 at 3:04 PM, Jan Beich <jbeich@tormail.org> wrote:
> mezz@FreeBSD.org writes:
>
>> The patch does not work and I have amd64 here. I am getting here:
>>
>> ----------------------
>> # make configure
>> [...]
>> Building GEGL with prefix=3D/usr/local
>>
>> Optional features:
>> =A0 GEGL docs: =A0 =A0 =A0 no
>> =A0 Build workshop: =A0no
>> =A0 Build website: =A0 no =A0(asciidoc not found)
>> =A0 SIMD: =A0 =A0 =A0 =A0 =A0 =A0sse:no mmx:no <-- here, both are still =
disabled.
>> =A0 Vala support: =A0 =A0no
>
> I'm afraid you have to provide config.log for me to debug why compile
> checks fail. configure.ac has the following logic:
>
> =A0# s/x86_64/amd64/
> =A0case "$target_or_host" in
> =A0 =A0x86_64-*-*)
> =A0 =A0 =A0have_x86=3Dyes
> =A0 =A0 =A0;;
> =A0esac
>
> =A0AC_ARG_ENABLE(mmx, ...,, enable_mmx=3D$have_x86)
> =A0AC_ARG_ENABLE(sse, ...,, enable_sse=3D$enable_mmx)
>
> =A0if test "x$enable_mmx" =3D "xyes"; then
> =A0 =A0 AC_COMPILE_IFELSE(<mmx check>,
> =A0 =A0 =A0 if test "x$enable_sse" =3D "xyes"; then
> =A0 =A0 =A0 =A0 =A0 AC_COMPILE_IFELSE(<sse check>,, enable_sse=3Dno)
> =A0 =A0 =A0 fi
> =A0 =A0 , enable_mmx=3Dno)
> =A0fi
>
> Also, there is no point in testing with OPTIMIZE turned OFF.

Ah, I didn't even notice that OPTIMIZE option! It does work when I
have it enables. I will commit it soon.

Cheers,
Mezz


--=20
mezz.freebsd@gmail.com - mezz@FreeBSD.org
FreeBSD GNOME Team
http://www.FreeBSD.org/gnome/ - gnome@FreeBSD.org
Comment 7 dfilter service freebsd_committer freebsd_triage 2012-05-20 21:24:58 UTC
mezz        2012-05-20 20:24:46 UTC

  FreeBSD ports repository

  Modified files:
    graphics/gegl        Makefile 
  Log:
  Get its configure to recognize amd64 by s/x86_64/amd64/g to enable SSE/MMX.
  
  PR:             ports/167721
  Submitted by:   Jan Beich <jbeich@tormail.org>
  
  Revision  Changes    Path
  1.35      +8 -4      ports/graphics/gegl/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 8 Jeremy Messenger freebsd_committer freebsd_triage 2012-05-20 21:25:02 UTC
State Changed
From-To: feedback->closed

Committed, thanks!