Bug 167808 - [maintainer-update] Patch to fix plist for games/netrek-client-cow (and more)
Summary: [maintainer-update] Patch to fix plist for games/netrek-client-cow (and more)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Michael Scheidell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-11 23:00 UTC by Kevin Zheng
Modified: 2012-05-12 10:40 UTC (History)
0 users

See Also:


Attachments
file.diff (3.04 KB, patch)
2012-05-11 23:00 UTC, Kevin Zheng
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Zheng 2012-05-11 23:00:25 UTC
The current port of games/netrek-client-cow incorrectly removes $PREFIX/pixmaps (if the directory is empty).

In addition, the current port installs to $PREFIX/games instead of $PREFIX/bin. It also uses LIB_DEPENDS to add SDL mixer, while the preferred way of doing it is to use USE_SDL.

Fix: Apply the attached patch.

Patch attached with submission follows:
How-To-Repeat: Install games/netrek-client-cow (but please don't until this is fixed).
Comment 1 Michael Scheidell freebsd_committer freebsd_triage 2012-05-12 10:24:48 UTC
Responsible Changed
From-To: freebsd-ports-bugs->scheidell

I'll take it.
Comment 2 dfilter service freebsd_committer freebsd_triage 2012-05-12 10:35:46 UTC
scheidell    2012-05-12 09:35:32 UTC

  FreeBSD ports repository

  Modified files:
    games/netrek-client-cow Makefile pkg-plist 
    games/netrek-client-cow/files patch-parsemeta.c 
                                  patch-system.mk.in 
  Log:
  - Install binary in ../bin and not ../games
  - Bump PORTREVISION
  
  PR:             ports/167808
  Submitted by:   Kevin Zheng <kevinz5000@gmail.com> (maintainer)
  
  Revision  Changes    Path
  1.2       +5 -3      ports/games/netrek-client-cow/Makefile
  1.2       +1 -1      ports/games/netrek-client-cow/files/patch-parsemeta.c
  1.2       +12 -2     ports/games/netrek-client-cow/files/patch-system.mk.in
  1.2       +1 -3      ports/games/netrek-client-cow/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Michael Scheidell freebsd_committer freebsd_triage 2012-05-12 10:35:48 UTC
State Changed
From-To: open->closed

Committed. Thanks!