- Update to 3.5.1 Port maintainer (jaapb@kerguelen.org) is cc'd. Generated with FreeBSD Port Tools 0.99
Maintainer of www/ocaml-net, Please note that PR ports/167987 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/167987 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
I've quickly tested the patch; it looks fine and compiles without problems, so yes, I approve of it. Thanks to the submitter! Jaap
State Changed From-To: feedback->open Maintainer approved.
Responsible Changed From-To: freebsd-ports-bugs->scheidell I'll take it.
State Changed From-To: open->feedback Complies and packages fine. One suggestion, clarification. PORTDOCS/EXAMPLESDOC macro's already take into account defines, so this is 'more' correct (less confusion) -.if !defined(NOPORTDOCS) PORTDOCS= * PORTEXAMPLES= * -.endif also, (and I don't know why anyone would do it), but PORTDOCS and PORTEXAMPLES are two different defines. I don't know why anyone would define NOPORTDOCS without defining NOPORTEXAMPLES, but: "in theory, practice and theory are the same, in practice, they arn't" so, the more correct way is to look for each define independently. If no objections, I will commit the above, plus this: post-install: .if !defined(NOPORTDOCS) @${MKDIR} ${DOCSDIR}/ @(cd ${WRKSRC}/doc/ && ${COPYTREE_SHARE} * ${DOCSDIR}/) - +.endif +.if !defined(NOPORTEXAMPLES) (basically: PORTDOCS= * PORTEXAMPLES= * and: post-install: .if !defined(NOPORTDOCS) @${MKDIR} ${DOCSDIR}/ @(cd ${WRKSRC}/doc/ && ${COPYTREE_SHARE} * ${DOCSDIR}/) .endif .if !defined(NOPORTEXAMPLES) @${MKDIR} ${EXAMPLESDIR}/ @(cd ${WRKSRC}/examples/ && ${COPYTREE_SHARE} * ${EXAMPLESDIR}/) .endif
scheidell 2012-05-22 13:12:46 UTC FreeBSD ports repository Modified files: www/ocaml-net Makefile distinfo Log: - Update to 3.5.1 [1] - Honor NOPORTEXAMPLES if NOPORTDOCS not defined [2] PR: ports/167987 [1] Submitted by: Jyun-Yan You <jyyou@cs.nctu.edu.tw> [1] Reviewed by: scheidell@ (me) [2] Approved by: Jaap Boender <jaapb@kerguelen.org> (maintainer) Revision Changes Path 1.28 +48 -26 ports/www/ocaml-net/Makefile 1.11 +2 -2 ports/www/ocaml-net/distinfo _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: feedback->closed Committed, with minor changes. Thanks!