Bug 168140 - shells/pdksh install munges ksh93 entry in /etc/shells
Summary: shells/pdksh install munges ksh93 entry in /etc/shells
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Steven Kreuzer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-19 19:10 UTC by Rob Windsor
Modified: 2012-05-22 15:20 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Windsor 2012-05-19 19:10:01 UTC
Install ksh93
$ cat /etc/shells
# $FreeBSD: release/9.0.0/etc/shells 59717 2000-04-27 21:58:46Z ache $
#
# List of acceptable shells for chpass(1).
# Ftpd will not allow users to connect who are not using
# one of these shells.

/bin/sh
/bin/csh
/bin/tcsh
/usr/local/bin/ksh93


Now install pdksh
$ cat /etc/shells
# $FreeBSD: release/9.0.0/etc/shells 59717 2000-04-27 21:58:46Z ache $
#
# List of acceptable shells for chpass(1).
# Ftpd will not allow users to connect who are not using
# one of these shells.

/bin/sh
/bin/csh
/bin/tcsh
/usr/local/bin/ksh

Fix: 

update line in ports/shells/pdksh/Makefile that does @(${GREP} -v ${PREFIX}/bin/ksh /etc/shells.bak ... to something like ${PREFIX}/bin/ksh\$

(test how you escape $ for functionality, don't use above example verbatum)
How-To-Repeat: uninstall pdksh
uninstall ksh93
clean up /etc/shells (if needed)
install ksh93
install pdksh
cat /etc/shells
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-05-19 19:44:59 UTC
Responsible Changed
From-To: freebsd-ports-bugs->skreuzer

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2012-05-22 15:14:05 UTC
skreuzer    2012-05-22 14:13:56 UTC

  FreeBSD ports repository

  Modified files:
    shells/pdksh         Makefile 
  Log:
  Prevent post-install from removing ksh93 from /etc/shells
  
  PR:             ports/168140
  Submitted by:   Rob Windsor <windsor@warthog.com>
  
  Revision  Changes    Path
  1.36      +1 -1      ports/shells/pdksh/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Steven Kreuzer freebsd_committer freebsd_triage 2012-05-22 15:14:56 UTC
State Changed
From-To: open->closed

Fixed the grep so it won't match ksh93. Thanks for the bug report