Bug 168278 - [PATCH] net-mgmt/nagios-pf-plugin remove obsolete OSVERSION check
Summary: [PATCH] net-mgmt/nagios-pf-plugin remove obsolete OSVERSION check
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Chris Rees
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-23 21:10 UTC by Chris Rees
Modified: 2012-06-06 18:00 UTC (History)
0 users

See Also:


Attachments
net-mgmt-nagios-pf-plugin.diff (873 bytes, patch)
2012-05-23 21:10 UTC, Chris Rees
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Rees freebsd_committer freebsd_triage 2012-05-23 21:10:06 UTC
FreeBSD ports tree doesn't support <7.x, so this check is unnecessary.

Also, creating a directory under PREFIX is a privileged operation, so pre-su-install must be used.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-05-23 21:10:58 UTC
Responsible Changed
From-To: freebsd-ports-bugs->pgollucci

pgollucci@ wants this port PRs (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2012-05-23 21:11:00 UTC
Maintainer of net-mgmt/nagios-pf-plugin,

Please note that PR ports/168278 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/168278

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 Edwin Groothuis freebsd_committer freebsd_triage 2012-05-23 21:11:02 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 4 Chris Rees freebsd_committer freebsd_triage 2012-06-06 17:53:07 UTC
State Changed
From-To: feedback->closed

Committed. Thanks! 


Comment 5 Chris Rees freebsd_committer freebsd_triage 2012-06-06 17:53:07 UTC
Responsible Changed
From-To: pgollucci->crees

Committed. Thanks!
Comment 6 dfilter service freebsd_committer freebsd_triage 2012-06-06 17:53:12 UTC
crees       2012-06-06 16:52:58 UTC

  FreeBSD ports repository

  Modified files:
    net-mgmt/nagios-pf-plugin Makefile 
  Log:
  Remove obsolete OSVERSION conditional.
  
  While here, use pre-su-install for privileged actions.
  
  PR:             ports/168278
  Submitted by:   crees
  Approved by:    maintainer timeout (kian.mohageri@gmail.com, 2w)
  
  Revision  Changes    Path
  1.4       +2 -8      ports/net-mgmt/nagios-pf-plugin/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"