Bug 168492 - editors/vim broken on environments without gettest
Summary: editors/vim broken on environments without gettest
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: David E. O'Brien
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-31 12:40 UTC by Dmitry Banschikov
Modified: 2012-05-31 23:10 UTC (History)
0 users

See Also:


Attachments
patch (305 bytes, patch)
2012-05-31 12:40 UTC, Dmitry Banschikov
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Banschikov 2012-05-31 12:40:00 UTC
    After PR ports/166202 vim is broken on environments without gettext
    installed and with WITHOUT_NLS not defined (e.g. tinderbox builds).
    While building editors/vim package in tinderbox, there is no gettext
    installed, so we append MAKE_ARGS with --disable-nls, which causes
    vim to not generate man pages in native languages. But, as earlier 
    we have defined MANLANG, then in compress-mas target in bsd.port.mk
    we tries to compress man pages which are not installed (as we have
    defined --disable-nls).

Fix: Split condition on two separate checks. One for using gettext and second
    for disabling manual pages in native languages.

How-To-Repeat:     On a freash, clean system try to install vim or, try to build package with
    tinderbox.
Comment 1 Dmitry Banschikov 2012-05-31 13:10:52 UTC
Log of failed build of vim can be found here:
http://am.nesiac.org/pub/get/vim-7.3.515.log


-- 

Dmitry Banschikov
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2012-05-31 13:45:00 UTC
Responsible Changed
From-To: freebsd-ports-bugs->obrien

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 3 dfilter service freebsd_committer freebsd_triage 2012-05-31 23:00:45 UTC
crees       2012-05-31 22:00:28 UTC

  FreeBSD ports repository

  Modified files:
    editors/vim          Makefile 
  Log:
  Stop trying to autodetect GETTEXT-- it doesn't work properly anyway and causes
  more problems than it solves.
  
  PR:             ports/168492
  PR:             ports/166202 (a fix for the consequences of)
  Approved by:    maintainer timeout on previous commit that this is to fix,
                  so this is implicit
  
  Revision  Changes    Path
  1.392     +1 -1      ports/editors/vim/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 4 Chris Rees freebsd_committer freebsd_triage 2012-05-31 23:00:54 UTC
State Changed
From-To: open->closed

Fixed in a slightly different way, thanks!