I'm corrected conflict with library devel/py-configobj. Thank you, for new experimental Ports tree CONFLICTS cross checker tool, made by Sulev-Madis "ketas" Silber. Removed file(s): - pkg-plist Generated with FreeBSD Port Tools 0.99_6 (mode: change, diff: suffix)
Responsible Changed From-To: freebsd-ports-bugs->scheidell I'll take it.
State Changed From-To: open->feedback You removed the pkg-plist? to use a big construct? If you have less than 4 plist files, it is ok to use PLIST_FILES=, but, for consistancy, readability, you should put it back. Also, without this: -@unexec if cmp -s %D/etc/dynagen.ini.sample %D/etc/dynagen.ini; then rm -f %D/etc/dynagen.ini; fi -etc/dynagen.ini.sample -@exec if [ ! -f %D/etc/dynagen.ini ] ; then cp -p %D/%F %B/dynagen.ini; fi you will clobber any existing dynagen.ini if this is installed from a package. (make package && make deinstall && pkg_add, edit dynagen.ini, pkg_delete, pkg_add)
Cannot commit until you fix this. most likely, you will need to restore your pkg-plist, for the reasons in original email, plus this: === Checking filesystem state after all packages deleted 232 ================================================================ 233 list of extra files and directories in / (not present on clean system but present after everything was deinstalled) 234 8003926 8 -r--r--r-- 1 root wheel 2317 Jun 17 12:34 usr/local/etc/dynagen.ini 235 you can replicate the problem with: make deinstall make package pkg_delete and then this pkg_add pkg_delete the problem, pkg_delete (portmaster, portupgrade, pkg tools) do not run the Makefile, then need the unexec's in pkg-plist If you need assistance, please join the mailing list freebsd-ports and describe what you are trying to do. -- Michael Scheidell, CTO >*| * SECNAP Network Security Corporation d: +1.561.948.2259 w: http://people.freebsd.org/~scheidell
Hello. I think that the use of dynamic lists, greatly simplifies the creation of a list of installable files. Instead of 47 files and directories, we only got 3 classes installable files. This is more understandable and readable. This allows you to specify the installable files and directories in just one place. Indeed, the command 'install' allows you to set in place a directory and all files in it. Dynamic lists are logically complete this design. It would be great to PLIST_FILES allow the use of 'Shell Patterns'. They could then place %%PYTHON_SITELIBDIR%%/confConsole.py %%PYTHON_SITELIBDIR%%/confConsole.pyc %%PYTHON_SITELIBDIR%%/confConsole.pyo use the shorter construction %%PYTHON_SITELIBDIR%%/confConsole.py* The second question. You are right! I forgot to add pkg-[de]install. Please use patch from this email instead of previous. Thank you. On Sat, Jun 16, 2012 at 4:31 PM, <scheidell@freebsd.org> wrote: > Synopsis: [MAINTAINER] emulators/dynagen: fix RUN_DEPENDS > > State-Changed-From-To: open->feedback > State-Changed-By: scheidell > State-Changed-When: Sat Jun 16 12:29:14 UTC 2012 > State-Changed-Why: > You removed the pkg-plist? to use a big construct? > If you have less than 4 plist files, it is ok to use PLIST_FILES=, but, for consistancy, readability, you should put it back. > Also, without this: > -@unexec if cmp -s %D/etc/dynagen.ini.sample %D/etc/dynagen.ini; then rm -f %D/etc/dynagen.ini; fi > -etc/dynagen.ini.sample > -@exec if [ ! -f %D/etc/dynagen.ini ] ; then cp -p %D/%F %B/dynagen.ini; fi > > you will clobber any existing dynagen.ini if this is installed from a package. > (make package && make deinstall && pkg_add, edit dynagen.ini, pkg_delete, pkg_add) > > > > http://www.freebsd.org/cgi/query-pr.cgi?pr=168937
State Changed From-To: feedback->open Back to the pool
Responsible Changed From-To: scheidell->freebsd-ports-bugs Back to the pool
Responsible Changed From-To: freebsd-ports-bugs->wxs I'll take it.
wxs 2012-06-22 01:49:00 UTC FreeBSD ports repository Modified files: emulators/dynagen Makefile emulators/dynagen/files patch-setup.py Added files: emulators/dynagen pkg-deinstall pkg-install Removed files: emulators/dynagen pkg-plist Log: Fix RUN_DEPENDS. Add LICENSE. Switch to PLIST_FILES. PR: ports/168937 Submitted by: Pavel I Volkov <pavelivolkov@googlemail.com> (maintainer) Revision Changes Path 1.17 +49 -18 ports/emulators/dynagen/Makefile 1.3 +3 -4 ports/emulators/dynagen/files/patch-setup.py 1.1 +6 -0 ports/emulators/dynagen/pkg-deinstall (new) 1.1 +4 -0 ports/emulators/dynagen/pkg-install (new) 1.7 +0 -78 ports/emulators/dynagen/pkg-plist (dead) _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed I committed this but in the future you should consider reverting back to a pkg-plist. Using the pkg-install/pkg-deinstall scripts just to ensure configuration files are handled properly is overkill. For more information on a better way to do this please see http://www.freebsd.org/doc/en/books/porters-handbook/plist-config.html. If you have any questions I'd be happy to help you find a better way to do this.