Bug 169137 - [PATCH] net-mgmt/p5-Nagios-Plugin: dependency cleanups
Summary: [PATCH] net-mgmt/p5-Nagios-Plugin: dependency cleanups
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Steve Wills
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-16 04:20 UTC by Steve Wills
Modified: 2012-07-16 20:30 UTC (History)
1 user (show)

See Also:


Attachments
p5-Nagios-Plugin-0.34.patch (1.02 KB, patch)
2012-06-16 04:20 UTC, Steve Wills
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Wills freebsd_committer freebsd_triage 2012-06-16 04:20:03 UTC
- Avoid SITE_PERL in DEPENDS
- Avoid += without preceeding definition
- Pet portlint by moving PERL_CONFIGURE down

Port maintainer (gerrit.beine@gmx.de) is cc'd.

Generated with FreeBSD Port Tools 0.99_6 (mode: change, diff: CVS)
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-06-16 17:19:58 UTC
Responsible Changed
From-To: freebsd-ports-bugs->perl

perl@ wants this port PRs (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2012-06-16 17:20:02 UTC
Maintainer of net-mgmt/p5-Nagios-Plugin,

Please note that PR ports/169137 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/169137

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 Edwin Groothuis freebsd_committer freebsd_triage 2012-06-16 17:20:17 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 4 Chris Rees freebsd_committer freebsd_triage 2012-07-10 20:38:19 UTC
State Changed
From-To: feedback->open

Maintainer timeout 


Comment 5 Chris Rees freebsd_committer freebsd_triage 2012-07-10 20:38:19 UTC
Responsible Changed
From-To: perl->swills

Go ahead and commit :)
Comment 6 Steve Wills freebsd_committer freebsd_triage 2012-07-16 20:24:02 UTC
State Changed
From-To: open->closed

Committed. Thanks!
Comment 7 dfilter service freebsd_committer freebsd_triage 2012-07-16 20:24:09 UTC
Author: swills
Date: Mon Jul 16 19:23:54 2012
New Revision: 300973
URL: http://svn.freebsd.org/changeset/ports/300973

Log:
  - Avoid += without preceeding definition
  - Expand value of BUILD_DEPENDS before assigning to RUN_DEPENDS
  - Pet portlint by moving PERL_CONFIGURE down
  
  PR:		ports/169137

Modified:
  head/net-mgmt/p5-Nagios-Plugin/Makefile   (contents, props changed)

Modified: head/net-mgmt/p5-Nagios-Plugin/Makefile
==============================================================================
--- head/net-mgmt/p5-Nagios-Plugin/Makefile	Mon Jul 16 19:11:35 2012	(r300972)
+++ head/net-mgmt/p5-Nagios-Plugin/Makefile	Mon Jul 16 19:23:54 2012	(r300973)
@@ -15,13 +15,13 @@ PKGNAMEPREFIX=	p5-
 MAINTAINER=	ports@FreeBSD.org
 COMMENT=	Modules to streamline writing Nagios plugins
 
-PERL_CONFIGURE=	yes
-
-BUILD_DEPENDS+=	p5-Class-Accessor>=0:${PORTSDIR}/devel/p5-Class-Accessor \
+BUILD_DEPENDS=	p5-Class-Accessor>=0:${PORTSDIR}/devel/p5-Class-Accessor \
 		p5-Params-Validate>=0:${PORTSDIR}/devel/p5-Params-Validate \
 		p5-Math-Calc-Units>=0:${PORTSDIR}/math/p5-Math-Calc-Units \
 		p5-Config-Tiny>=0:${PORTSDIR}/devel/p5-Config-Tiny
-RUN_DEPENDS+=	${BUILD_DEPENDS}
+RUN_DEPENDS:=	${BUILD_DEPENDS}
+
+PERL_CONFIGURE=	yes
 
 MAN3=		Nagios::Plugin.3 \
 		Nagios::Plugin::Config.3 \
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"