Bug 169216 - [PATCH] net/skystar2: fix usage of ${SRC_BASE} before it is defined
Summary: [PATCH] net/skystar2: fix usage of ${SRC_BASE} before it is defined
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Jason Helfman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-19 00:30 UTC by Jason Helfman
Modified: 2012-07-01 23:58 UTC (History)
1 user (show)

See Also:


Attachments
skystar2-1.32,1.patch (1.10 KB, patch)
2012-06-19 00:30 UTC, Jason Helfman
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jason Helfman freebsd_committer freebsd_triage 2012-06-19 00:30:19 UTC
 
Original PR filed as ports/165994

SRC_BASE is being used before being defined in several ports. it happened to
work anyways in most cases because the main use of SRC_BASE is for checking if
${SRC_BASE}/sys/ (/usr/src/sys/) exists, and if SRC_BASE is empty, it just
checks for /sys/ which does exist on most systems as a symlink to /usr/src/sys/.

pet portlint on pkg-message and placement of USE_BZIP2

Port maintainer (admin@lissyara.su) is cc'd.

Generated with FreeBSD Port Tools 0.99_6 (mode: change, diff: CVS)
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-06-19 00:31:18 UTC
Responsible Changed
From-To: freebsd-ports-bugs->jgh

Submitter has GNATS access (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2012-06-19 00:31:24 UTC
Maintainer of net/skystar2,

Please note that PR ports/169216 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/169216

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 Edwin Groothuis freebsd_committer freebsd_triage 2012-06-19 00:31:29 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 4 Jason Helfman freebsd_committer freebsd_triage 2012-07-01 07:35:49 UTC
State Changed
From-To: feedback->open

maintainer timeout (14 days)
Comment 5 dfilter service freebsd_committer freebsd_triage 2012-07-01 23:32:09 UTC
jgh         2012-07-01 22:31:53 UTC

  FreeBSD ports repository

  Modified files:
    net/skystar2         Makefile pkg-message 
  Log:
  - re-order, include bsd.port.pre.mk so SRC_BASE is defined before referenced
  - pet portlint (empty lines in pkg-message)
  
  PR:     ports/169216
  Submitted by:   jgh@
  Approved by:    maintainer timeout ( 14 days )
  
  Revision  Changes    Path
  1.13      +3 -2      ports/net/skystar2/Makefile
  1.3       +0 -2      ports/net/skystar2/pkg-message
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 6 Jason Helfman freebsd_committer freebsd_triage 2012-07-01 23:58:10 UTC
State Changed
From-To: open->closed

Committed. Thanks!