The official version of the code has been integrated into the MessagePack project. https://github.com/msgpack/msgpack/tree/master/php/ Fix: Patch attached with submission follows:
Responsible Changed From-To: freebsd-ports-bugs->scheidell scheidell@ wants his PRs (via the GNATS Auto Assign Tool)
State Changed From-To: open->feedback The ports auditors are going to ask me, so I need to ask you: -SHA256 (php-msgpack-0.5.3.tar.gz) = 9eb0fb03b66bab5994607c7bc1f7aef9a738af173e6e4f65965a2c2ad8e6336c -SIZE (php-msgpack-0.5.3.tar.gz) = 86591 +SHA256 (msgpack-msgpack-980a652.tar.gz) = 0a293eeb110fd24bd42bae5d35bab82a6bfc796ac62f793f47c14a2ce1da5b4d +SIZE (msgpack-msgpack-980a652.tar.gz) = 224300 HUGE size difference, and going from a normal versioning 0.5.3 to a date version, once you go back to normal versioning, you will need to do a PORTEPOCH. is there no other way to do this? Even to applying the patches from (msgpack-msgpack-980a652.tar.gz to php-msgpack-0.5.3.tar.gz and calling it 0.5.3.1 ? (if the patch is huge, I can host it at people.freebsd.org/~scheidell/huge_patch) So, they are going to ask me both questions. When a distribution file goes from 86K to 224K, they will want me to do a diff between the sources and look for obvious trojan code.
Would you consider this alternate patch? the Master site works fine with http (didn't look like it needed https), pav (portmgr) already put in USE_PHP_BUILD=yes, in a previous commit (so you don't need the run/build depends) This compiles just fine in tinderbox with php5 (5.4). other than that, its almost your patch (oh, I moved the GIT* vars down so that portlint -abt stopped complaining) if ok, I'll commit. -- Michael Scheidell, CTO SECNAP Network Security Corporation http://people.freebsd.org/~scheidell ______________________________________________________________________ This email has been scanned and certified safe by SpammerTrap(r). For Information please see http://www.spammertrap.com/ ______________________________________________________________________
Would you consider this alternate patch? the Master site works fine with http (didn't look like it needed https), pav (portmgr) already put in USE_PHP_BUILD=yes, in a previous commit (so you don't need the run/build depends) This compiles just fine in tinderbox with php5 (5.4). other than that, its almost your patch (oh, I moved the GIT* vars down so that portlint -abt stopped complaining) if ok, I'll commit. -- Michael Scheidell, CTO >*| * SECNAP Network Security Corporation d: +1.561.948.2259 w: http://people.freebsd.org/~scheidell
all ok, you can commit On Sat, 23 Jun 2012 05:59:36 -0400 Michael Scheidell <scheidell@FreeBSD.org> wrote: > Would you consider this alternate patch? > the Master site works fine with http (didn't look like it needed >https), > pav (portmgr) already put in USE_PHP_BUILD=yes, in a previous commit >(so you don't need the run/build depends) > This compiles just fine in tinderbox with php5 (5.4). > > other than that, its almost your patch (oh, I moved the GIT* vars >down so that portlint -abt stopped complaining) > > if ok, I'll commit. > -- > Michael Scheidell, CTO > >*| * SECNAP Network Security Corporation > d: +1.561.948.2259 > w: http://people.freebsd.org/~scheidell
State Changed From-To: feedback->closed Committed. Thanks!
scheidell 2012-06-25 11:08:24 UTC FreeBSD ports repository Modified files: devel/php5-msgpack Makefile distinfo Removed files: devel/php5-msgpack/files patch-msgpack.c patch-msgpack__pack_template.h patch-msgpack__sysdep.h patch-msgpack__version.h patch-msgpack_class.c patch-msgpack_pack.c patch-msgpack_pack.h patch-msgpack_unpack.c patch-msgpack_unpack.h patch-php_msgpack.h Log: - Update to 2012.05.05 - Official version of the code has been integrated into the MessagePack project PR: ports/169261 Submitted by: Valery Komarov <komarov@valerka.net> (maintainer) Obtained from: https://github.com/msgpack/msgpack/tree/master/php/ Revision Changes Path 1.6 +9 -4 ports/devel/php5-msgpack/Makefile 1.2 +2 -2 ports/devel/php5-msgpack/distinfo 1.2 +0 -72 ports/devel/php5-msgpack/files/patch-msgpack.c (dead) 1.2 +0 -11 ports/devel/php5-msgpack/files/patch-msgpack__pack_template.h (dead) 1.2 +0 -170 ports/devel/php5-msgpack/files/patch-msgpack__sysdep.h (dead) 1.2 +0 -11 ports/devel/php5-msgpack/files/patch-msgpack__version.h (dead) 1.2 +0 -90 ports/devel/php5-msgpack/files/patch-msgpack_class.c (dead) 1.2 +0 -11 ports/devel/php5-msgpack/files/patch-msgpack_pack.c (dead) 1.2 +0 -17 ports/devel/php5-msgpack/files/patch-msgpack_pack.h (dead) 1.2 +0 -55 ports/devel/php5-msgpack/files/patch-msgpack_unpack.c (dead) 1.2 +0 -25 ports/devel/php5-msgpack/files/patch-msgpack_unpack.h (dead) 1.2 +0 -11 ports/devel/php5-msgpack/files/patch-php_msgpack.h (dead) _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"