Bug 169464 - security/openssl Makefile has faulty descriptions
Summary: security/openssl Makefile has faulty descriptions
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Dirk Meyer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-26 21:00 UTC by CyberRax
Modified: 2012-06-30 12:40 UTC (History)
0 users

See Also:

Attachments
file.diff (805 bytes, patch)
2012-06-26 21:00 UTC, CyberRax 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description CyberRax 2012-06-26 21:00:22 UTC 
The description in OpenSSL's Makefile for "386" option:
- "Use optimized assembler for x86"
OpenSSL's INSTALL file however gives a different description:
- "Use the 80386 instruction set only (the default x86 code is more efficient, but requires at least a 486) [...]"
Also for the "no-sse2" option the INSTALL text specifies the following:
- "Both '386' and 'no-asm' options above imply 'no-sse2'"

So while the "386" setting is disabled by default it does suggest that turning it ON in x86 hardware would result in better performance, while it's actually the opposite on anything newer than a i386. It also disables SSE2 support (which is activated by default).

Also for atleast 2 updates the Makefiles names the RC5 cipher "C5 chipher". My native tongue ain't English, so perhaps "chipher" (with an 'h') is indeed correct, but the name of the algorithm most definitly isn't.

Fix: See attached patch

Patch attached with submission follows:
How-To-Repeat: Take a look at /usr/ports/security/openssl/Makefile
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-06-26 21:00:36 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->dinoex

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2012-06-30 12:34:54 UTC 
dinoex      2012-06-30 11:33:28 UTC

  FreeBSD ports repository

  Modified files:
    security/openssl     Makefile 
  Log:
  - update descripitions
  PR:             169464
  Submitted by:   CyberRax
  
  - shorter desc for options
  
  Revision  Changes    Path
  1.190     +11 -11    ports/security/openssl/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Dirk Meyer freebsd_committer freebsd_triage 2012-06-30 12:38:27 UTC 
State Changed
From-To: open->closed

committed, thanks.