Bug 169625 - multimedia/vlc: garbage in "make config" menu after converting to options-ng
Summary: multimedia/vlc: garbage in "make config" menu after converting to options-ng
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Joseph S. Atkinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-03 09:30 UTC by vsjcfm
Modified: 2012-07-04 10:40 UTC (History)
0 users

See Also:

Attachments
vlc-options.diff (3.42 KB, patch)
2012-07-03 22:25 UTC, Rene Ladan 		no flags Details | Diff
Makefile.rej (5.57 KB, application/octet-stream)
2012-07-04 08:05 UTC, vsjcfm 		no flags Details
patch-Makefile (1.96 KB, application/octet-stream)
2012-07-04 08:11 UTC, vsjcfm 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description vsjcfm 2012-07-03 09:30:11 UTC 
After converting multimedia/vlc, there is a garbage in "make config" menu.
Screenshot is here: http://higgs.rghost.ru/39002023/image.png
Problem is reproducable in both syscons & X sessions, regardless of $LANG.
All other "make config" menus are displayed correctly (options-ng or old options).

How-To-Repeat: Update ports to latest version, where vlc converted to options-ng, cd $PORTSDIR/multimedia/vlc and run "make config"
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-07-03 09:30:56 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->jsa

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Rene Ladan freebsd_committer freebsd_triage 2012-07-03 22:25:44 UTC 
The screenshot shows that in your case long lines are wrapped, while for
me they are cut off. Could you try the attached patch which better deals
with dependent optios so that the offending descriptions can be shortened?

René
Comment 3 vsjcfm 2012-07-04 08:05:36 UTC 
Hmm... patch doesn't work for me (ports is latest version).
I'll try to manually edit Makefile and cut long lines.

Hmm...  Looks like a unified diff to me...
The text leading up to this was:
--------------------------
|? Makefile.202
|? distinfo.202
|Index: Makefile
|===================================================================
|RCS file: /home/pcvs/ports/multimedia/vlc/Makefile,v
|retrieving revision 1.292
|diff -u -r1.292 Makefile
|--- Makefile   2 Jul 2012 22:45:27 -0000       1.292
|+++ Makefile   3 Jul 2012 21:17:39 -0000
--------------------------
Patching file Makefile using Plan A...
Hunk #1 failed at 40.
Hunk #2 failed at 52.
Hunk #3 failed at 71.
Hunk #4 failed at 85.
Hunk #5 failed at 239.
Hunk #6 failed at 273.
Hunk #7 failed at 334.
Hunk #8 failed at 564.
Hunk #9 failed at 702.
9 out of 9 hunks failed--saving rejects to Makefile.rej
done
Comment 4 vsjcfm 2012-07-04 08:11:19 UTC 
Attached patch works for me. Now all is ok.
http://rghost.ru/39018840/image.png
Comment 5 dfilter service freebsd_committer freebsd_triage 2012-07-04 10:39:20 UTC 
rene        2012-07-04 09:39:10 UTC

  FreeBSD ports repository

  Modified files:
    multimedia/vlc       Makefile 
  Log:
  Instead of mentioning dependent options in the description of the option
  that requires it, check if dependent options are set and set IGNORE if not.
  
  This prevents some option descriptions being too long, resulting in ugly
  screens. [1]
  PR:             ports/169625
  Submitted by:   Sayetsky Anton [vsjcfm gmail.com]
  Approved by:    maintainer (implicit)
  
  Revision  Changes    Path
  1.293     +28 -8     ports/multimedia/vlc/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 6 Rene Ladan freebsd_committer freebsd_triage 2012-07-04 10:39:32 UTC 
State Changed
From-To: open->closed

Committed, thanks.