Bug 169689 - multimedia/mplayer missing dependency on libbs2b
Summary: multimedia/mplayer missing dependency on libbs2b
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Pawel Pekala
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-06 21:40 UTC by Pawel Pekala
Modified: 2012-07-11 16:10 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pawel Pekala freebsd_committer freebsd_triage 2012-07-06 21:40:10 UTC 
When audio/libbs2b is installed on the system mplayer links to it and does not register it as it's dependency:

[corn:~]# ldd /usr/local/bin/mplayer | grep -i libbs
        libbs2b.so.0 => /usr/local/lib/libbs2b.so.0 (0x28fa5000)
[corn:~]# pkg_info -r mplayer-1.0.r20120322_2/ | grep -i libbs
[corn:~]#
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-07-06 21:40:20 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->pawel

Submitter has GNATS access (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2012-07-06 21:40:22 UTC 
Maintainer of multimedia/mplayer,

Please note that PR ports/169689 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/169689

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 Edwin Groothuis freebsd_committer freebsd_triage 2012-07-06 21:40:23 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 4 Thomas Zander 2012-07-10 19:47:40 UTC 
Thanks for catching this one.
Since nobody has yet asked for bs2b support, I would make this as
simple as possible, see below. Agree?

Best
Riggs


--- a/mplayer/Makefile.shared	Tue Jul 10 20:39:25 2012 +0200
+++ b/mplayer/Makefile.shared	Tue Jul 10 20:42:25 2012 +0200
@@ -39,6 +39,7 @@
 		--disable-bitmap-font \
 		--disable-liba52 \
 		--disable-alsa \
+		--disable-libbs2b \
 		--enable-ass-internal

 WANT_GNOME=	yes
Comment 5 dfilter service freebsd_committer freebsd_triage 2012-07-11 16:08:03 UTC 
pawel       2012-07-11 15:07:50 UTC

  FreeBSD ports repository

  Modified files:
    multimedia/mplayer   Makefile.shared 
  Log:
  Don't link to audio/libbs2b
  
  PR:             ports/169689
  Reported by:    myself
  Submitted by:   Thomas Zander <thomas.e.zander@googlemail.com> (maintainer)
  
  Revision  Changes    Path
  1.19      +2 -1      ports/multimedia/mplayer/Makefile.shared
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 6 Pawel Pekala freebsd_committer freebsd_triage 2012-07-11 16:10:02 UTC 
State Changed
From-To: feedback->closed

Committed. Thanks!