Bug 169984 - [MAINTAINER UPDATE] www/aolserver: Misc updates
Summary: [MAINTAINER UPDATE] www/aolserver: Misc updates
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Niclas Zeising
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-18 21:40 UTC by Bryan Drewery
Modified: 2012-07-30 16:40 UTC (History)
0 users

See Also:


Attachments
patch-aolserver.txt (1.47 KB, patch)
2012-07-18 21:40 UTC, Bryan Drewery
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bryan Drewery 2012-07-18 21:40:04 UTC
	- Remove pre/post include
	- No need for ARCH check since ONLY_FOR_ARCHS is used
	- Use USERS/GROUPS
	- Fix invalid @exec in plist causing directory to be created in the wrong place with pkgng

	To committer, please add this to GIDs (from base /etc/group):
	nogroup:*:65533:
Comment 1 Niclas Zeising freebsd_committer freebsd_triage 2012-07-19 12:39:32 UTC
Responsible Changed
From-To: freebsd-ports-bugs->zeising

I'll take it.
Comment 2 Niclas Zeising freebsd_committer freebsd_triage 2012-07-20 15:39:39 UTC
Hi!
Is there any particular reason you have choosen to use 'nogroup' instead 
of 'nobody' as the group?
Regards!
-- 
Niclas Zeising
Comment 3 Bryan Drewery 2012-07-20 15:47:55 UTC
This is what the port was already using. I'd prefer to remain backwards
compatible. I don't see any benefit to changing it.

Regards,
Bryan Drewery
Comment 4 dfilter service freebsd_committer freebsd_triage 2012-07-30 16:38:36 UTC
Author: zeising
Date: Mon Jul 30 15:38:16 2012
New Revision: 301720
URL: http://svn.freebsd.org/changeset/ports/301720

Log:
  Misc. fixes:
  - Remove pre/post include
  - No need for ARCH check since ONLY_FOR_ARCHS is used
  - Use USERS/GROUPS
  - Fix invalid @exec in plist causing directory to be created in the wrong
    place with pkgng
  
  Add nogroup to GIDs since this port uses it.
  
  PR:		ports/169984
  Submitted by:	maintainer
  Approved by:	kwm (mentor)

Modified:
  head/GIDs
  head/www/aolserver/Makefile
  head/www/aolserver/pkg-plist

Modified: head/GIDs
==============================================================================
--- head/GIDs	Mon Jul 30 15:30:35 2012	(r301719)
+++ head/GIDs	Mon Jul 30 15:38:16 2012	(r301720)
@@ -237,4 +237,5 @@ hadoop:*:955:
 pandora:*:956:
 razorback:*:957:
 gnunet:*:958:
+nogroup:*:65533
 nobody:*:65534:

Modified: head/www/aolserver/Makefile
==============================================================================
--- head/www/aolserver/Makefile	Mon Jul 30 15:30:35 2012	(r301719)
+++ head/www/aolserver/Makefile	Mon Jul 30 15:38:16 2012	(r301720)
@@ -26,6 +26,8 @@ WRKSRC=		${WRKDIR}/${DISTNAME:S/-src//}
 AOLSERVERBASE?=	${PORTNAME}
 AOLSERVERUSER?=	nobody
 AOLSERVERGROUP?=	nogroup
+USERS=	${AOLSERVERUSER}
+GROUPS=	${AOLSERVERGROUP}
 
 MANPREFIX=	${PREFIX}/${AOLSERVERBASE}
 USE_GMAKE=	yes
@@ -52,15 +54,11 @@ HTMLDOCS_DESC=	Install HTML documentatio
 MANPAGES_DESC=	Install manpages
 TESTS_DESC=	Install tests in example directory
 
-.include <bsd.port.pre.mk>
+.include <bsd.port.options.mk>
 
 SUB_LIST+=	MKDIR="${MKDIR}" ECHO_CMD="${ECHO_CMD}" \
 		CHOWN="${CHOWN}" CHMOD="${CHMOD}"
 
-.if (${ARCH} == "ia64")
-BROKEN=		does not compile on ia64
-.endif
-
 CONFIGURE_ENV+=		TCLSH="${TCLSH}"
 CONFIGURE_ARGS+=	--prefix="${PREFIX}/${AOLSERVERBASE}" \
 			--with-tcl="${TCL_LIBDIR}"
@@ -738,4 +736,4 @@ post-install:
 
 	@${CAT} ${PKGMESSAGE}
 
-.include <bsd.port.post.mk>
+.include <bsd.port.mk>

Modified: head/www/aolserver/pkg-plist
==============================================================================
--- head/www/aolserver/pkg-plist	Mon Jul 30 15:30:35 2012	(r301719)
+++ head/www/aolserver/pkg-plist	Mon Jul 30 15:38:16 2012	(r301720)
@@ -832,8 +832,8 @@
 @dirrmtry %%AOLSERVERBASE%%/servers/server1
 @dirrmtry %%AOLSERVERBASE%%/servers
 @dirrmtry %%AOLSERVERBASE%%
-@exec mkdir -p %%AOLSERVERBASE%%/log
-@exec mkdir -p %%AOLSERVERBASE%%/servers/server1/modules/nslog
+@exec mkdir -p %D/%%AOLSERVERBASE%%/log
+@exec mkdir -p %D/%%AOLSERVERBASE%%/servers/server1/modules/nslog
 %%TESTS%%%%EXAMPLESDIR%%/tests/adp/test1.adp
 %%TESTS%%%%EXAMPLESDIR%%/tests/adp/test2.adp
 %%TESTS%%%%EXAMPLESDIR%%/tests/adp/test3.adp
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 5 Niclas Zeising freebsd_committer freebsd_triage 2012-07-30 16:39:13 UTC
State Changed
From-To: open->closed

Committed. Thanks!