Bug 170184 - [patch] devel/libevent2: correct include order in pkg-config
Summary: [patch] devel/libevent2: correct include order in pkg-config
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Martin Matuska
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-26 07:00 UTC by Jan Beich
Modified: 2012-10-23 21:19 UTC (History)
0 users

See Also:

Attachments
include_order.diff (453 bytes, patch)
2012-07-26 07:00 UTC, Jan Beich 		no flags Details | Diff
include_order.diff (1.48 KB, patch)
2012-07-26 09:30 UTC, Jan Beich 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2012-07-26 07:00:22 UTC 
When using cflags from pkg-config /compat directory is placed later.
If devel/libevent is also installed an app using such flags may
accidentally pick up event.h from libevent14. As both libraries
are only API compatible the app may crash due to ABI difference.

How-To-Repeat: $ echo '#include <event.h>' |
  env -i gcc -E - $(pkg-config libevent --cflags) |
  fgrep include/event.h
# 1 "/usr/local/include/event.h" 1
# 162 "/usr/local/include/event.h"
[...]
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-07-26 07:00:35 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->mm

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Jan Beich freebsd_committer freebsd_triage 2012-07-26 09:30:56 UTC 
Jan Beich <jbeich@tormail.org> writes:

> Index: devel/libevent2/files/patch-libevent.pc.in

Oops, missed a few .pc files.
Comment 3 Martin Matuska freebsd_committer freebsd_triage 2012-10-23 21:19:41 UTC 
State Changed
From-To: open->closed

Committed. Thanks!