Bug 170321 - [MAINTAINER] devel/gdb: Small clean-up of the port
Summary: [MAINTAINER] devel/gdb: Small clean-up of the port
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Wesley Shields
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-02 09:20 UTC by luca.pizzamiglio
Modified: 2012-08-03 03:10 UTC (History)
0 users

See Also:

Attachments
file.diff (1.47 KB, patch)
2012-08-02 09:20 UTC, luca.pizzamiglio 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description luca.pizzamiglio 2012-08-02 09:20:10 UTC 
This update fix a comment in Makefile (useful to better detect problems like in ports/170080) and merges a couple of small patches I received from jhb@ and Raghu Gyambavantha.
I guess no PORTREVISION bumping is required.

Fix: Patch attached with submission follows:
Comment 1 Wesley Shields freebsd_committer freebsd_triage 2012-08-03 02:14:00 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->wxs

I'll take it.
Comment 2 Wesley Shields freebsd_committer freebsd_triage 2012-08-03 03:01:05 UTC 
State Changed
From-To: open->closed

Committed. Thanks!
Comment 3 dfilter service freebsd_committer freebsd_triage 2012-08-03 03:01:13 UTC 
Author: wxs
Date: Fri Aug  3 02:00:58 2012
New Revision: 301875
URL: http://svn.freebsd.org/changeset/ports/301875

Log:
  Clarify a comment and incorporate a couple of patches.
  
  PR:		ports/170321
  Submitted by:	Luca Pizzamiglio <luca.pizzamiglio@gmail.com> (maintainer)

Modified:
  head/devel/gdb/Makefile   (contents, props changed)
  head/devel/gdb/files/fbsd-threads.c   (contents, props changed)

Modified: head/devel/gdb/Makefile
==============================================================================
--- head/devel/gdb/Makefile	Thu Aug  2 22:34:01 2012	(r301874)
+++ head/devel/gdb/Makefile	Fri Aug  3 02:00:58 2012	(r301875)
@@ -7,7 +7,7 @@
 
 PORTNAME=	gdb
 PORTVERSION=	7.4.1
-PORTREVISION=	3
+PORTREVISION=	4
 CATEGORIES=	devel
 MASTER_SITES=	GNU
 
@@ -38,7 +38,8 @@ MAN1=	gdb${VER}.1
 
 ONLY_FOR_ARCHS=	i386 amd64	# untested elsewhere, might work
 
-# Forcing to use the readline.6
+# Forcing to use the readline from ports (readline in FreeBSD world is not
+# compatible anymore).
 LIB_DEPENDS+=	readline:${PORTSDIR}/devel/readline
 CFLAGS+=	-isystem ${LOCALBASE}/include
 LDFLAGS+=	-L${LOCALBASE}/lib

Modified: head/devel/gdb/files/fbsd-threads.c
==============================================================================
--- head/devel/gdb/files/fbsd-threads.c	Thu Aug  2 22:34:01 2012	(r301874)
+++ head/devel/gdb/files/fbsd-threads.c	Fri Aug  3 02:00:58 2012	(r301875)
@@ -1,4 +1,4 @@
-/* $FreeBSD: /tmp/pcvs/ports/devel/gdb/files/fbsd-threads.c,v 1.4 2012-06-23 09:12:05 scheidell Exp $ */
+/* $FreeBSD$ */
 /* FreeBSD libthread_db assisted debugging support.
    Copyright 1999, 2000, 2001 Free Software Foundation, Inc.
 
@@ -747,8 +747,10 @@ fbsd_thread_wait (struct target_ops *ops
       */
       if (!fbsd_thread_alive (ops, inferior_ptid) && !ptid_equal(inferior_ptid, ret))
         {
-          delete_thread (inferior_ptid);
+          ptid_t save_ptid;
+          save_ptid = inferior_ptid;
           inferior_ptid = ret;
+          delete_thread (save_ptid);
         }
     }
 
@@ -1176,7 +1178,7 @@ tsd_cb (thread_key_t key, void (*destruc
   else
     name = SYMBOL_PRINT_NAME (ms);
 
-  printf_filtered ("Destructor %p <%s>\n", destructor, name);
+  printf_filtered ("Key %d, destructor %p <%s>\n", key, destructor, name);
   return 0;
 }
 
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"