Bug 170390 - [PATCH] security/gnutls: Prevent from linking to -lpthread directly
Summary: [PATCH] security/gnutls: Prevent from linking to -lpthread directly
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Roman Bogorodskiy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-05 14:00 UTC by Jason E. Hale
Modified: 2012-08-15 15:00 UTC (History)
1 user (show)

See Also:


Attachments
2012-08-05-gnutls.diff (1.82 KB, patch)
2012-08-05 14:00 UTC, Jason E. Hale
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jason E. Hale 2012-08-05 14:00:01 UTC
- Prevent security/gnutls from linking to -lpthread directly
- Bump port revision since linking will change
- While here:
  - Use the USE_PKGCONFIG macro to remove pkgconf runtime dependency
  - Pet portlint by removing ABI number references
  - Remove --with-lzo=no, if anything it should be --without-lzo,
    but LZO support is disabled by default whether liblzo2 is installed or not

How-To-Repeat: - Use attached diff
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-08-05 14:00:27 UTC
Responsible Changed
From-To: freebsd-ports-bugs->novel

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2012-08-15 14:57:15 UTC
Author: novel
Date: Wed Aug 15 13:57:01 2012
New Revision: 302578
URL: http://svn.freebsd.org/changeset/ports/302578

Log:
  - Drop automatic dependency detection [1]
  - Do not link to -lphread directly [2]
  - Use USE_PKGCONFIG [2]
  - Pet portlint by removing ABI number references [2]
  - Drop no longer actual --with-lzo=no switch, lzo support
    is disabled by default anyway [2]
  - Bump PORTREVISION
  
  PR:		170390 [2]
  Submitted by:	Jason E. Hale [2], A.J. Kehoe IV (Nanoman) [1]

Modified:
  head/security/gnutls/Makefile

Modified: head/security/gnutls/Makefile
==============================================================================
--- head/security/gnutls/Makefile	Wed Aug 15 13:47:53 2012	(r302577)
+++ head/security/gnutls/Makefile	Wed Aug 15 13:57:01 2012	(r302578)
@@ -7,6 +7,7 @@
 
 PORTNAME=	gnutls
 PORTVERSION=	2.12.18
+PORTREVISION=	1
 CATEGORIES=	security net
 MASTER_SITES=	${MASTER_SITE_GNU} \
 		${MASTER_SITE_GNUPG}
@@ -15,15 +16,16 @@ MASTER_SITE_SUBDIR=	${PORTNAME}
 MAINTAINER=	novel@FreeBSD.org
 COMMENT=	GNU Transport Layer Security library
 
-LIB_DEPENDS=	nettle.4:${PORTSDIR}/security/nettle \
-		gpg-error.0:${PORTSDIR}/security/libgpg-error \
-		p11-kit.0:${PORTSDIR}/security/p11-kit
+LIB_DEPENDS=	nettle:${PORTSDIR}/security/nettle \
+		gpg-error:${PORTSDIR}/security/libgpg-error \
+		p11-kit:${PORTSDIR}/security/p11-kit
 
 CONFLICTS=	gnutls-devel-[0-9]*
 
 USE_BZIP2=	yes
 USE_ICONV=	yes
-USE_GNOME=	pkgconfig ltverhack gnomehack
+USE_PKGCONFIG=	build
+USE_GNOME=	ltverhack gnomehack
 GNU_CONFIGURE=	yes
 MAKE_JOBS_SAFE=	yes
 USE_LDCONFIG=	yes
@@ -36,17 +38,15 @@ MANCOMPRESSED=	no
 
 .include <bsd.port.pre.mk>
 
-.if (defined(WITH_LIBTASN1) || exists(${LOCALBASE}/lib/libtasn1.so.4)) && !defined(WITHOUT_LIBTASN1)
-LIB_DEPENDS+=	tasn1.4:${PORTSDIR}/security/libtasn1
+.if defined(WITH_LIBTASN1)
+LIB_DEPENDS+=	tasn1:${PORTSDIR}/security/libtasn1
 .else
 CONFIGURE_ARGS+=	--with-included-libtasn1
 .endif
 
-.if (defined(WITH_LZO) || exists(${LOCALBASE}/lib/liblzo2.so)) && !defined(WITHOUT_LZO)
+.if defined(WITH_LZO)
 LIB_DEPENDS+=		lzo2:${PORTSDIR}/archivers/lzo2
 CONFIGURE_ARGS+=	--with-lzo
-.else
-CONFIGURE_ARGS+=	--with-lzo=no
 .endif
 
 .if defined(WITHOUT_CXX)
@@ -67,6 +67,10 @@ PLIST_SUB+=		NLS=""
 PORTDOCS=		AUTHORS NEWS README THANKS
 PORTEXAMPLES=		*.c
 
+post-patch:
+	@${FIND} ${WRKSRC} -name "Makefile.in" -type f | ${XARGS} ${REINPLACE_CMD} \
+		-e 's|[$$][(]LTLIBPTHREAD[)]||g'
+
 post-install:
 .if !defined (NOPORTEXAMPLES)
 	@${MKDIR} ${EXAMPLESDIR}
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Roman Bogorodskiy freebsd_committer freebsd_triage 2012-08-15 14:59:25 UTC
State Changed
From-To: open->closed

Committed, thanks!