Bug 170404 - [PATCH] devel/p5-Devel-GlobalDestruction: Fix invalid plist with perl 5.12 breaking package building
Summary: [PATCH] devel/p5-Devel-GlobalDestruction: Fix invalid plist with perl 5.12 br...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-06 07:00 UTC by Bryan Drewery
Modified: 2012-08-07 09:50 UTC (History)
0 users

See Also:


Attachments
patch-devel-p5-Devel-GlobalDestruction.plist.txt (1.30 KB, patch)
2012-08-06 07:00 UTC, Bryan Drewery
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bryan Drewery freebsd_committer freebsd_triage 2012-08-06 07:00:08 UTC
	The latest update to 0.08 removed the %%OLD_PLIST%%..SITE_PERL/%%ARCH%% plist support for perl 5.12.
	This is apparently still needed.

	7.4 pkg_install:

	=======================<phase: install  >==========================
	===>  Installing for p5-Devel-GlobalDestruction-0.08
	===>   p5-Devel-GlobalDestruction-0.08 depends on package: p5-Sub-Exporter-Progressive>=0.001.002 - found
	===>   p5-Devel-GlobalDestruction-0.08 depends on file: /usr/local/bin/perl5.12.4 - found
	===>   Generating temporary packing list
	===>  Checking if devel/p5-Devel-GlobalDestruction already installed
	Files found in blib/arch: installing files in blib/lib into architecture dependent library tree
	Installing /usr/local/lib/perl5/site_perl/5.12.4/mach/auto/Devel/GlobalDestruction/GlobalDestruction.bs
	Installing /usr/local/lib/perl5/site_perl/5.12.4/mach/auto/Devel/GlobalDestruction/GlobalDestruction.so
	Installing /usr/local/lib/perl5/site_perl/5.12.4/mach/Devel/GlobalDestruction.pm
	Installing /usr/local/lib/perl5/5.12.4/man/man3/Devel::GlobalDestruction.3
	===>   Compressing manual pages for p5-Devel-GlobalDestruction-0.08
	===>   Registering installation for p5-Devel-GlobalDestruction-0.08
	===================================================================
	=======================<phase: package  >==========================
	===>  Building package for p5-Devel-GlobalDestruction-0.08
	tar: lib/perl5/site_perl/5.12.4/Devel/GlobalDestruction.pm: Cannot stat: No such file or directory
	tar: Error exit delayed from previous errors.
	pkg_create: make_dist: tar command failed with code 256
	*** Error code 1

	Stop in /usr/ports/devel/p5-Devel-GlobalDestruction.
	===>  Cleaning for p5-Devel-GlobalDestruction-0.08


	8.2 pkgng:

	=======================<phase: install  >==========================
	===>  Installing for p5-Devel-GlobalDestruction-0.08
	===>   p5-Devel-GlobalDestruction-0.08 depends on package: p5-Sub-Exporter-Progressive>=0.001.002 - found
	===>   p5-Devel-GlobalDestruction-0.08 depends on file: /usr/local/bin/perl5.12.4 - found
	===>   Generating temporary packing list
	===>  Checking if devel/p5-Devel-GlobalDestruction already installed
	Files found in blib/arch: installing files in blib/lib into architecture dependent library tree
	Installing /usr/local/lib/perl5/site_perl/5.12.4/mach/auto/Devel/GlobalDestruction/GlobalDestruction.bs
	Installing /usr/local/lib/perl5/site_perl/5.12.4/mach/auto/Devel/GlobalDestruction/GlobalDestruction.so
	Installing /usr/local/lib/perl5/site_perl/5.12.4/mach/Devel/GlobalDestruction.pm
	Installing /usr/local/lib/perl5/5.12.4/man/man3/Devel::GlobalDestruction.3
	===>   Compressing manual pages for p5-Devel-GlobalDestruction-0.08
	===>   Registering installation for p5-Devel-GlobalDestruction-0.08
	pkg: lstat(/usr/local/lib/perl5/site_perl/5.12.4/Devel/GlobalDestruction.pm): No such file or directory
	pkg: lstat(/usr/local/lib/perl5/site_perl/5.12.4/Devel/): No such file or directory
	Installing p5-Devel-GlobalDestruction-0.08... done
	===================================================================
	=======================<phase: package  >==========================
	===>  Building package for p5-Devel-GlobalDestruction-0.08
	Creating package for p5-Devel-GlobalDestruction-0.08


	redports 7.4 with perl 5.14:

	===>  Installing for p5-Devel-GlobalDestruction-0.08
	===>   p5-Devel-GlobalDestruction-0.08 depends on package: p5-Sub-Exporter-Progressive>=0.001.002 - found
	===>   p5-Devel-GlobalDestruction-0.08 depends on file: /usr/local/bin/perl5.14.2 - found
	===>   Generating temporary packing list
	===>  Checking if devel/p5-Devel-GlobalDestruction already installed
	Manifying blib/man3/Devel::GlobalDestruction.3
	Installing /usr/local/lib/perl5/site_perl/5.14.2/Devel/GlobalDestruction.pm
	Installing /usr/local/lib/perl5/5.14.2/man/man3/Devel::GlobalDestruction.3
	===>   Compressing manual pages for p5-Devel-GlobalDestruction-0.08
	===>   Registering installation for p5-Devel-GlobalDestruction-0.08
	================================================================
	====================<phase 7: make package>====================
	===>  Building package for p5-Devel-GlobalDestruction-0.08
	Deleting p5-Devel-GlobalDestruction-0.08

Fix: With patch 5.12 successfully builds and 5.14 continues to as well.
How-To-Repeat: 	With PERL_VERSION=5.12.4:
	make install package
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-08-06 07:00:27 UTC
Responsible Changed
From-To: freebsd-ports-bugs->perl

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Po-Chuan Hsieh freebsd_committer freebsd_triage 2012-08-07 04:13:39 UTC
Responsible Changed
From-To: perl->sunpoet

I'll take it.
Comment 3 Po-Chuan Hsieh freebsd_committer freebsd_triage 2012-08-07 09:43:20 UTC
State Changed
From-To: open->closed

Committed. Thanks!
Comment 4 dfilter service freebsd_committer freebsd_triage 2012-08-07 09:43:25 UTC
Author: sunpoet
Date: Tue Aug  7 08:43:10 2012
New Revision: 302230
URL: http://svn.freebsd.org/changeset/ports/302230

Log:
  - Fix PLIST for older Perl releases (which build XS version)
  
  PR:		ports/170404
  Submitted by:	bdrewery

Modified:
  head/devel/p5-Devel-GlobalDestruction/Makefile
  head/devel/p5-Devel-GlobalDestruction/pkg-plist

Modified: head/devel/p5-Devel-GlobalDestruction/Makefile
==============================================================================
--- head/devel/p5-Devel-GlobalDestruction/Makefile	Tue Aug  7 08:39:46 2012	(r302229)
+++ head/devel/p5-Devel-GlobalDestruction/Makefile	Tue Aug  7 08:43:10 2012	(r302230)
@@ -27,7 +27,13 @@ MAN3=		Devel::GlobalDestruction.3
 .include <bsd.port.pre.mk>
 
 .if ${PERL_LEVEL} < 501200
-BUILD_DEPENDS+=	p5-ExtUtils-CBuilder>=0.27:${PORTSDIR}/devel/p5-ExtUtils-CBuilder
+BUILD_DEPENDS+=	p5-ExtUtils-CBuilder>=0.2700:${PORTSDIR}/devel/p5-ExtUtils-CBuilder
+.endif
+
+.if ${PERL_LEVEL} < 501400
+PLIST_SUB+=	PP="@comment " XS=""
+.else
+PLIST_SUB+=	PP="" XS="@comment "
 .endif
 
 .include <bsd.port.post.mk>

Modified: head/devel/p5-Devel-GlobalDestruction/pkg-plist
==============================================================================
--- head/devel/p5-Devel-GlobalDestruction/pkg-plist	Tue Aug  7 08:39:46 2012	(r302229)
+++ head/devel/p5-Devel-GlobalDestruction/pkg-plist	Tue Aug  7 08:43:10 2012	(r302230)
@@ -1,5 +1,10 @@
-%%SITE_PERL%%/Devel/GlobalDestruction.pm
+%%PP%%%%SITE_PERL%%/Devel/GlobalDestruction.pm
+%%XS%%%%SITE_PERL%%/%%PERL_ARCH%%/Devel/GlobalDestruction.pm
 %%SITE_PERL%%/%%PERL_ARCH%%/auto/Devel/GlobalDestruction/.packlist
+%%XS%%%%SITE_PERL%%/%%PERL_ARCH%%/auto/Devel/GlobalDestruction/GlobalDestruction.bs
+%%XS%%%%SITE_PERL%%/%%PERL_ARCH%%/auto/Devel/GlobalDestruction/GlobalDestruction.so
 @dirrm %%SITE_PERL%%/%%PERL_ARCH%%/auto/Devel/GlobalDestruction
 @dirrmtry %%SITE_PERL%%/%%PERL_ARCH%%/auto/Devel
-@dirrmtry %%SITE_PERL%%/Devel
+%%XS%%@dirrmtry %%SITE_PERL%%/%%PERL_ARCH%%/Devel/GlobalDestruction
+%%XS%%@dirrmtry %%SITE_PERL%%/%%PERL_ARCH%%/Devel
+%%PP%%@dirrmtry %%SITE_PERL%%/Devel
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"