Bug 170409 - irc/bitchx Remove patch-funny.c
Summary: irc/bitchx Remove patch-funny.c
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Alexey Dokuchaev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-06 08:50 UTC by Gary Stanley
Modified: 2012-09-16 15:37 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gary Stanley 2012-08-06 08:50:01 UTC 
The files/patch-funny.c adds the following to source/funny.c under the BitchX version that is shipped (a security fix ported from gentoo a long time ago):

        if (channel == NULL || line == NULL) {
                bitchsay("Invalid number of arguments for %s", __FUNCTION__);
                return;
        }


However, just before the patch is added, this is present:

        /* protocol violation by server */
        if (!channel || !line)
                return;


The patch-funny.c should be removed as this was fixed in 1.1 which is shipped with FreeBSD.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-08-06 08:50:30 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->danfe

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Alexey Dokuchaev freebsd_committer freebsd_triage 2012-09-16 15:36:30 UTC 
State Changed
From-To: open->closed

Included with recent port update (SVN r304350), thanks!