Bug 170434 - [patch] Correct devel/py-gobject Dependency Declaration
Summary: [patch] Correct devel/py-gobject Dependency Declaration
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-gnome (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-07 01:50 UTC by A.J. Kehoe IV
Modified: 2012-12-30 05:30 UTC (History)
0 users

See Also:


Attachments
file.diff (472 bytes, patch)
2012-08-07 01:50 UTC, A.J. Kehoe IV
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description A.J. Kehoe IV 2012-08-07 01:50:04 UTC
The FreeBSD port devel/py-gobject uses automatic detection to declare an optional dependency.  This causes problems for port and package management.

Fix: I've attached a patch that corrects this by using the method suggested in the FreeBSD Porter's Handbook on the "Dependencies" page under "Problems Caused by Automatic Dependencies":

http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-depend.html

Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-08-07 01:50:14 UTC
Responsible Changed
From-To: freebsd-ports-bugs->gnome

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2012-12-30 05:28:05 UTC
Author: mezz
Date: Sun Dec 30 05:27:57 2012
New Revision: 309649
URL: http://svnweb.freebsd.org/changeset/ports/309649

Log:
  -OPTIONSng [1]
  -Update the header
  -USE_PKGCONFIG=build
  -portlint
  
  PR:		ports/170434
  Submitted by:	"A.J. Kehoe IV (Nanoman)" <q8y7cosz@nanoman.ca>

Modified:
  head/devel/py-gobject/Makefile   (contents, props changed)

Modified: head/devel/py-gobject/Makefile
==============================================================================
--- head/devel/py-gobject/Makefile	Sun Dec 30 05:17:02 2012	(r309648)
+++ head/devel/py-gobject/Makefile	Sun Dec 30 05:27:57 2012	(r309649)
@@ -1,10 +1,6 @@
-# New ports collection makefile for:	py-gobject
-# Date created:				10 January 2006
-# Whom:					Joe Marcus Clarke <marcus@FreeBSD.org>
-#
+# Created by: Joe Marcus Clarke <marcus@FreeBSD.org>
 # $FreeBSD$
 #   $MCom: ports/devel/py-gobject/Makefile,v 1.52 2011/06/13 20:37:47 kwm Exp $
-#
 
 PORTNAME=	gobject
 PORTVERSION=	2.28.6
@@ -19,17 +15,19 @@ DIST_SUBDIR=	gnome2
 MAINTAINER=	gnome@FreeBSD.org
 COMMENT=	Python bindings for GObject
 
+LICENSE=	LGPL21
+LICENSE_FILE=	${WRKSRC}/COPYING
+
 BUILD_DEPENDS=	g-ir-scanner:${PORTSDIR}/devel/gobject-introspection \
 		${LOCALBASE}/libdata/pkgconfig/pycairo.pc:${PORTSDIR}/graphics/py-cairo
 RUN_DEPENDS=	g-ir-scanner:${PORTSDIR}/devel/gobject-introspection \
 		${LOCALBASE}/libdata/pkgconfig/pycairo.pc:${PORTSDIR}/graphics/py-cairo
 
-LICENSE=	LGPL21
-LICENSE_FILE=	${WRKSRC}/COPYING
 USE_XZ=		yes
 USE_GMAKE=	yes
 USE_GNOME=	gnomehack glib20
 USE_PYTHON=	2.5+
+USE_PKGCONFIG=	build
 GNU_CONFIGURE=	yes
 USE_LDCONFIG=	yes
 CONFIGURE_ARGS=	--disable-docs
@@ -37,10 +35,13 @@ CONFIGURE_ARGS=	--disable-docs
 CONFLICTS=	py*-gtk-0*
 PLIST_SUB=	PYTHON_VER="${PYTHON_VER}"
 
-.include <bsd.port.pre.mk>
+OPTIONS_DEFINE=	LIBFFI
+LIBFFI_DESC=	Enable libffi support
+
+.include <bsd.port.options.mk>
 
-.if exists(${LOCALBASE}/lib/libffi.so)
-LIB_DEPENDS+=	ffi.5:${PORTSDIR}/devel/libffi
+.if ${PORT_OPTIONS:MLIBFFI}
+LIB_DEPENDS+=	ffi:${PORTSDIR}/devel/libffi
 CONFIGURE_ARGS+=--with-ffi
 .else
 CONFIGURE_ARGS+=--without-ffi
@@ -50,4 +51,4 @@ post-install:
 	@${PYTHON_CMD} ${PYTHON_LIBDIR}/compileall.py \
 		${PREFIX}/share/pygobject/2.0/codegen
 
-.include <bsd.port.post.mk>
+.include <bsd.port.mk>
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Jeremy Messenger freebsd_committer freebsd_triage 2012-12-30 05:28:22 UTC
State Changed
From-To: open->closed

Committed, thanks!