Bug 170537 - devel/libftdi seems broken on i386 and amd64
Summary: devel/libftdi seems broken on i386 and amd64
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Stefan Walter
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-11 14:40 UTC by zoon01
Modified: 2013-05-05 10:50 UTC (History)
0 users

See Also:


Attachments
libftdi.diff (2.68 KB, patch)
2013-05-05 10:01 UTC, Stefan Walter
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zoon01 2012-08-11 14:40:01 UTC
	
Port devel/libftdi seems broken on both i386 and amd64 freebsd 9.0 release p4

I included all the new files for the port upgrade for libftdi from 0.18 to 0.20

From files in current port tree this file can be removed:
patch-examples_serial_read.c as it is no longer used

Regards,
Michael Zoon

Fix: 

XXX CREES Original email and attachments at http://lists.freebsd.org/pipermail/freebsd-ports-bugs/2012-August/237997.html XXX
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-08-11 14:40:10 UTC
Maintainer of devel/libftdi,

Please note that PR ports/170537 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/170537

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2012-08-11 14:40:11 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Stefan Walter freebsd_committer freebsd_triage 2013-05-01 10:34:18 UTC
Hello zoon01,

unfortunately, there hasn't been any activity with your problem report for
devel/libftdi (see [1]) for a while. According to the port's change log,
the port's maintainer does not seem to actively maintain the port any
more.

In the problem report, you mentioned an update of the port to 0.20, but
there are no files attached. If you still wish the port to be updated,
please send a followup with a patch for the update. In case the port's
maintainer doesn't react during the next few days, you could also take
over maintainership of the port if you are interested.

Best regards,
Stefan

[1]: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/170537
Comment 4 Stefan Walter freebsd_committer freebsd_triage 2013-05-01 10:34:29 UTC
Responsible Changed
From-To: freebsd-ports-bugs->stefan

Track this while waiting for feedback.
Comment 5 Stefan Walter freebsd_committer freebsd_triage 2013-05-02 21:17:54 UTC
Hello Michael,

zoon01, 02.05.13, 17:15h CEST:

> Hi Stefan,
> 
> With this email I included the rar file with the new libftdi port files of
> version 0.20
> 
> It would be great to see the port upgraded.
> 
> Regards,
> Michael Zoon

thank you for that! Please note, though: The preferred form of updates to
ports are patches in unified diff format as produced by "svn diff" or
"diff -urN", not archives like RAR files.  Please see [1] for details on
how to create such a patch for the port. As that page states, sending a
patch file helps committers understand what changes have been made to the
port's files.

Could you re-send the update to be made as a patch file?

Best regards,
Stefan

[1]: http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/port-upgrading.html
Comment 6 Stefan Walter freebsd_committer freebsd_triage 2013-05-05 10:01:59 UTC
For the record: Updated patch received by submitter. (Attached to include
it in the PR.)

zoon01, 04.05.13, 01:00h CEST:

> HI!
> Ok 3th time final.
> 
> Included the diff for libftdi update
> 
> Regards,
> 
> Michael Zoon
> Developer and Project Owner
Comment 7 dfilter service freebsd_committer freebsd_triage 2013-05-05 10:41:38 UTC
Author: stefan
Date: Sun May  5 09:41:24 2013
New Revision: 317406
URL: http://svnweb.freebsd.org/changeset/ports/317406

Log:
  - Update to 0.20.
  - Add option for Python bindings.
  
  PR:		170537 [1]
  		170241 [2]
  Submitted by:	Michael Zoon <zoon01@nas4free.org> [1]
  		Craig Leres <leres@ee.lbl.gov> [2]
  Approved by:	maintainer timeout (~9 months)

Deleted:
  head/devel/libftdi/files/patch-examples_serial_read.c
Modified:
  head/devel/libftdi/Makefile
  head/devel/libftdi/distinfo   (contents, props changed)
  head/devel/libftdi/pkg-plist   (contents, props changed)

Modified: head/devel/libftdi/Makefile
==============================================================================
--- head/devel/libftdi/Makefile	Sun May  5 08:39:30 2013	(r317405)
+++ head/devel/libftdi/Makefile	Sun May  5 09:41:24 2013	(r317406)
@@ -2,15 +2,16 @@
 # $FreeBSD$
 
 PORTNAME=	libftdi
-PORTVERSION=	0.18
-PORTREVISION=	1
+PORTVERSION=	0.20
 CATEGORIES=	devel
 MASTER_SITES=	http://www.intra2net.com/en/developer/libftdi/download/
 
 MAINTAINER=	o.davydenko@gmail.com
-COMMENT=	Library (using libusb) to talk to FTDI chips
+COMMENT=	A library (using libusb) to talk to FTDI chips
 
-OPTIONS_DEFINE=	BOOST
+OPTIONS_DEFINE+=	BOOST PYTHON
+BOOST_DESC=		Build with boost
+PYTHON_DESC=		Python bindings
 
 USE_AUTOTOOLS=		autoconf libtool automake
 GNU_CONFIGURE=		yes
@@ -26,11 +27,18 @@ PORTDOCS=		COPYING.LIB ChangeLog README
 PLIST_SUB+=		BOOST=""
 CONFIGURE_ARGS+=	--with-boost
 CXXFLAGS+=		"-I${LOCALBASE}/include"
-LIB_DEPENDS+=		boost_system:${PORTSDIR}/devel/boost-libs
+LIB_DEPENDS+=		boost_system.4:${PORTSDIR}/devel/boost-libs
 .else
 PLIST_SUB+=		BOOST="@comment "
 CONFIGURE_ARGS+=	--without-boost
 .endif
+.if ${PORT_OPTIONS:MPYTHON}
+PLIST_SUB+=		PYTHON=""
+CONFIGURE_ARGS+=	--enable-python-binding
+USE_PYTHON=		yes
+.else
+PLIST_SUB+=		PYTHON="@comment "
+.endif
 
 EXTRA_PATCHES=	${FILESDIR}/extra-patch-configure.in
 

Modified: head/devel/libftdi/distinfo
==============================================================================
--- head/devel/libftdi/distinfo	Sun May  5 08:39:30 2013	(r317405)
+++ head/devel/libftdi/distinfo	Sun May  5 09:41:24 2013	(r317406)
@@ -1,2 +1,2 @@
-SHA256 (libftdi-0.18.tar.gz) = 5b6f3c3ee51c6aa24d3b87135e01762cf68821d1c3599d87d349fea4ede74c62
-SIZE (libftdi-0.18.tar.gz) = 398380
+SHA256 (libftdi-0.20.tar.gz) = 3176d5b5986438f33f5208e690a8bfe90941be501cc0a72118ce3d338d4b838e
+SIZE (libftdi-0.20.tar.gz) = 423570

Modified: head/devel/libftdi/pkg-plist
==============================================================================
--- head/devel/libftdi/pkg-plist	Sun May  5 08:39:30 2013	(r317405)
+++ head/devel/libftdi/pkg-plist	Sun May  5 09:41:24 2013	(r317406)
@@ -6,17 +6,17 @@ bin/bitbang_ft2232
 bin/find_all
 %%BOOST%%bin/find_all_pp
 bin/libftdi-config
-bin/serial_read
+bin/serial_test
 bin/simple
 include/ftdi.h
 %%BOOST%%include/ftdi.hpp
 lib/libftdi.a
 lib/libftdi.la
 lib/libftdi.so
-lib/libftdi.so.19
+lib/libftdi.so.21
 %%BOOST%%lib/libftdipp.a
 %%BOOST%%lib/libftdipp.la
 %%BOOST%%lib/libftdipp.so
-%%BOOST%%lib/libftdipp.so.19
+%%BOOST%%lib/libftdipp.so.21
 libdata/pkgconfig/libftdi.pc
 %%BOOST%%libdata/pkgconfig/libftdipp.pc
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 8 Stefan Walter freebsd_committer freebsd_triage 2013-05-05 10:49:20 UTC
State Changed
From-To: feedback->closed

Committed, thanks!