Bug 170614 - devel/php-xdebug brings in php54, even though php53 wanted
Summary: devel/php-xdebug brings in php54, even though php53 wanted
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Florian Smeets
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-14 00:30 UTC by rainer
Modified: 2012-09-06 17:20 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description rainer 2012-08-14 00:30:07 UTC
Hi,

I have a tinderbox, and in my options I have:

DEFAULT_PHP_VER=53


However, in the Makefile it generates:


1977 all: php-xdebug-2.2.0.tbz
1978 php-xdebug-2.2.0: php-xdebug-2.2.0.tbz
1979 php-xdebug-2.2.0.tbz: pcre-8.31.tbz libxml2-2.7.8_3.tbz pkgconf-0.8.5.tbz libiconv-1.14.tbz php5-5.4.5.tbz m4-1.4.16_1,1.tbz autoconf-wrapper-20101119.tbz perl-5.10.1_7.tbz libsigsegv-2.10.tbz autoconf-2.69.tbz


Somehow, this gets overwritten.
I'm not sure if I made a mistake or not.
All my other ports compile with php53 correctly

Fix: 

I don't know. Maybe the port is pulling in PHP incorrectly.
phpMyAdmin does get build with php53.
How-To-Repeat: see above
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-08-14 00:30:23 UTC
Maintainer of devel/php-xdebug,

Please note that PR ports/170614 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/170614

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2012-08-14 00:30:27 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Michael Scheidell freebsd_committer freebsd_triage 2012-08-14 12:46:06 UTC
Responsible Changed
From-To: freebsd-ports-bugs->scheidell

See if this patch doesn't fix it: 
--- Makefile	(revision 302518) 
+++ Makefile	(working copy) 
@@ -20,7 +20,7 @@ 
USE_PHPEXT=	yes 
USE_PHPIZE=	yes 
SUB_FILES=	pkg-message 
-DEFAULT_PHP_VER=	5 
+DEFAULT_PHP_VER?=	5 

PKGMESSAGE=	${WRKDIR}/pkg-message
Comment 4 Michael Scheidell freebsd_committer freebsd_triage 2012-08-14 12:49:36 UTC
Actually, this one is more correct than the ?= one I sent previously.

Unless maintainer doesn't want to support php53.

(note: I don't think the DEFAULT_PHP_VER belongs in port/Makefile.. it 
is already defined in <bsd.php.mk> if it doesn't exist)
Maintainer: please approve:


svn diff
Index: Makefile
===================================================================
--- Makefile    (revision 302518)
+++ Makefile    (working copy)
@@ -20,7 +20,6 @@
  USE_PHPEXT=    yes
  USE_PHPIZE=    yes
  SUB_FILES=    pkg-message
-DEFAULT_PHP_VER=    5

  PKGMESSAGE=    ${WRKDIR}/pkg-message


-- 
Michael Scheidell, CTO
 >*| * SECNAP Network Security Corporation
d: +1.561.948.2259
w: http://people.freebsd.org/~scheidell
Comment 5 Michael Scheidell freebsd_committer freebsd_triage 2012-08-23 10:24:20 UTC
Responsible Changed
From-To: scheidell->freebsd-ports-bugs

Sorry, will be losing my net access for two weeks, sending this back to 
pool for someone to commit.
Comment 6 Florian Smeets freebsd_committer freebsd_triage 2012-08-23 10:38:32 UTC
Responsible Changed
From-To: freebsd-ports-bugs->flo

I'll take it.
Comment 7 Florian Smeets 2012-08-23 10:54:49 UTC
Dear php-xdebug Maintainer,

please approve this patch. It removes the forcible dependency on php
5.4.x and lets xdebug build with other php versions, too.


Index: Makefile
===================================================================
--- Makefile    (revision 302946)
+++ Makefile    (working copy)
@@ -20,7 +20,6 @@
 USE_PHPEXT=    yes
 USE_PHPIZE=    yes
 SUB_FILES=     pkg-message
-DEFAULT_PHP_VER=       5

 PKGMESSAGE=    ${WRKDIR}/pkg-message

Thanks,
Florian
Comment 8 dfilter service freebsd_committer freebsd_triage 2012-09-06 17:13:41 UTC
Author: flo
Date: Thu Sep  6 16:13:30 2012
New Revision: 303782
URL: http://svn.freebsd.org/changeset/ports/303782

Log:
  Do not force DEFAULT_PHP_VER to version 5, let bsd.php.mk figure it out.
  This allows xdebug to work with all PHP versions again.
  
  PR:		ports/170614
  Approved by:	maintainer timeout

Modified:
  head/devel/php-xdebug/Makefile   (contents, props changed)

Modified: head/devel/php-xdebug/Makefile
==============================================================================
--- head/devel/php-xdebug/Makefile	Thu Sep  6 16:01:49 2012	(r303781)
+++ head/devel/php-xdebug/Makefile	Thu Sep  6 16:13:30 2012	(r303782)
@@ -20,7 +20,6 @@ USE_PHP=	yes
 USE_PHPEXT=	yes
 USE_PHPIZE=	yes
 SUB_FILES=	pkg-message
-DEFAULT_PHP_VER=	5
 
 PKGMESSAGE=	${WRKDIR}/pkg-message
 
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 9 Florian Smeets freebsd_committer freebsd_triage 2012-09-06 17:13:59 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!