Although I have /usr/local/include/X11/extensions/Print.h and /usr/local/lib/libXp.a /usr/local/lib/libXp.so /usr/local/lib/libXp.la /usr/local/lib/libXp.so.6 installed (they also look sane), configure fails t detect them properly. From config.log: configure:18905: cc -o conftest -O2 -pipe -march=nocona -fno-strict-aliasing -st d=gnu89 -Wall -g -fno-strict-aliasing -Wno-unused -Wno-comment -fno-tree-ter -DC SRG_BASED -DXNO_MTSAFE_API -DXNO_MTSAFE_PWDAPI -DCSRG_BASED -DXUSE_MTSAFE_API -D XNO_MTSAFE_PWDAPI -L/usr/local/lib conftest.c -liconv >&5 configure:18912: $? = 0 configure:18943: result: -liconv configure:19054: checking for libXp configure:19072: checking X11/extensions/Print.h usability configure:19089: cc -c -O2 -pipe -march=nocona -fno-strict-aliasing -std=gnu89 -Wall -g -fno-strict-aliasing -Wno-unused -Wno-comment -fno-tree-ter -DCSRG_BASED -DXNO_MTSAFE_API -DXNO_MTSAFE_PWDAPI -DCSRG_BASED -DXUSE_MTSAFE_API -DXNO_MTSAFE_PWDAPI conftest.c >&5 conftest.c:109:34: error: X11/extensions/Print.h: No such file or directory What happens is that at some point configure gets lost in saving/restoring CFLAGS/LDFLAGS and forgets to use -I/usr/local/include and -L/usr/local/lib it looks like that checking for XmuNCopyISOLatin1Lowered in -lXmu... still has our custom flags, while the next test checking for dirent.h that defines DIR... forgets the flags. How-To-Repeat: Below is full output of configure running with -x: [bugmeister note: contents moved to http://people.freebsd.org/~linimon/tmp/open-motif-log.txt]
Maintainer of x11-toolkits/open-motif, Please note that PR ports/170626 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/170626 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
The following patch seems to address this issue: --- configure.orig 2010-03-12 15:44:09.000000000 +0100 +++ configure 2012-08-12 18:33:49.000000000 +0200 @@ -19054,6 +19054,7 @@ { $as_echo "$as_me:$LINENO: checking for libXp" >&5 $as_echo_n "checking for libXp... " >&6; } +CPPFLAGS="$CPPFLAGS -I$x_includes" for ac_header in X11/extensions/Print.h do as_ac_Header=`$as_echo "ac_cv_header_$ac_header" | $as_tr_sh`
To submitter: please try the following line for CPPFLAGS in port Makefile and let me know if it works: CPPFLAGS+= -DCSRG_BASED -DXUSE_MTSAFE_API -DXNO_MTSAFE_PWDAPI -I${LOCALBASE}/include I think it will be better approach than patching configure script. -- Mikhail
On Wed, 15 Aug 2012, Mikhail Tsatsenko wrote: > To submitter: please try the following line for CPPFLAGS in port > Makefile and let me know if it works: > CPPFLAGS+= -DCSRG_BASED -DXUSE_MTSAFE_API -DXNO_MTSAFE_PWDAPI > -I${LOCALBASE}/include > > I think it will be better approach than patching configure script. Yes, I can confirm that this fixes the problem mentioned: #ifndef PRINTING_SUPPORTED #define PRINTING_SUPPORTED 1 #endif Thanks! //Marcin
Patch is attached. Could anybody commit it into ports tree pls - fix X11/extensions/XPrint.h detection. Reported by: Marcin Cieslak - Bump PORTREVISION
Responsible Changed From-To: freebsd-ports-bugs->rm I will take it.
Author: rm Date: Thu Sep 13 08:05:31 2012 New Revision: 304183 URL: http://svn.freebsd.org/changeset/ports/304183 Log: - fix detection of X11/extensions/XPrint.h - bump PORTREVISION PR: 170626 Submitted by: Mikhail Tsatsenko <m.tsatsenko at gmail dot com> (maintainer) Reported by: Marcin Cieslak <saper at saper dot info> Modified: head/x11-toolkits/open-motif/Makefile Modified: head/x11-toolkits/open-motif/Makefile ============================================================================== --- head/x11-toolkits/open-motif/Makefile Thu Sep 13 07:12:30 2012 (r304182) +++ head/x11-toolkits/open-motif/Makefile Thu Sep 13 08:05:31 2012 (r304183) @@ -8,7 +8,7 @@ PORTNAME= open-motif PORTVERSION= 2.3.3 -PORTREVISION= 1 +PORTREVISION= 2 CATEGORIES= x11-toolkits MASTER_SITES= ftp://ftp.ics.com/openmotif/${PORTVERSION:C/^([0-9]+\.[0-9]+).*/\1/}/${PORTVERSION}/ DISTNAME= openmotif-${PORTVERSION} @@ -30,7 +30,7 @@ USE_XORG= xaw xbitmaps xft GNU_CONFIGURE= yes USE_LDCONFIG= yes MAKE_ENV= LANG=C -CPPFLAGS+= -DCSRG_BASED -DXUSE_MTSAFE_API -DXNO_MTSAFE_PWDAPI +CPPFLAGS+= -DCSRG_BASED -DXUSE_MTSAFE_API -DXNO_MTSAFE_PWDAPI -I${PREFIX}/include USE_CSTD= gnu89 DEMOS_SRC= ${WRKSRC}/demos/programs _______________________________________________ svn-ports-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-ports-all To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
State Changed From-To: feedback->closed Committed, thank you!