Bug 170645 - [PATCH] x11/rxvt-unicode: fix build on recent current and 9-STABLE
Summary: [PATCH] x11/rxvt-unicode: fix build on recent current and 9-STABLE
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Thierry Thomas
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-15 11:20 UTC by Mykola Dzham
Modified: 2012-08-26 13:10 UTC (History)
1 user (show)

See Also:


Attachments
rxvt-unicode-9.15_1.patch (579 bytes, patch)
2012-08-15 11:20 UTC, Mykola Dzham
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mykola Dzham 2012-08-15 11:20:25 UTC
Can't build x11/rxvt-unicode after r236890 on current and after MFS on 9-STABLE:
...
c++ -I.. -I. -I. -I./../libev -I./../libptytty/src -I./../libecb -DHAVE_CONFIG_H -I/usr/local/include -D_THREAD_SAFE -I/usr/local/include   -D_THREAD_SAFE -I/usr/local/include -I/usr/local/include/freetype2   -I/usr/local/include -O2 -pipe -fno-strict-aliasing -w -I/usr/local/include  -D_REENTRANT -I/usr/local/include/gdk-pixbuf-2.0 -I/usr/local/include/libpng15 -I/usr/local/include/glib-2.0 -c rxvtc.C
PERL="/usr/bin/perl5" /usr/bin/perl5 /usr/local/lib/perl5/5.12.4/ExtUtils/xsubpp -C++ -typemap /usr/local/lib/perl5/5.12.4/ExtUtils/typemap -typemap typemap.iom -typemap typemap -prototypes ./rxvtperl.xs >rxvtperl.C
/usr/bin/perl5 -MExtUtils::Embed -e xsinit -- -std urxvt
cc  -o rxvtc rxvtc.o rxvtdaemon.o fdpass_wrapper.o -lutil -lsupc++ -lm
rxvtdaemon.o: In function `rxvt_connection::recv(auto_ptr<char>&, int*)':
rxvtdaemon.C:(.text+0x28e): undefined reference to `operator new[](unsigned long)'

Port maintainer (thierry@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.99_6 (mode: change, diff: CVS)

Fix: Use patch below.

tb logs:
http://levsha.me/tb/logs/10-HEAD.amd64/rxvt-unicode-9.15_1.log
http://levsha.me/tb/logs/9-STABLE.amd64/rxvt-unicode-9.15_1.log
http://levsha.me/tb/logs/9-STABLE.i386/rxvt-unicode-9.15_1.log
http://levsha.me/tb/logs/8-STABLE.amd64/rxvt-unicode-9.15_1.log
http://levsha.me/tb/logs/8-STABLE.i386/rxvt-unicode-9.15_1.log
http://levsha.me/tb/logs/7-STABLE.amd64/rxvt-unicode-9.15_1.log
http://levsha.me/tb/logs/7-STABLE.i386/rxvt-unicode-9.15_1.log
How-To-Repeat: Try to build on current after r236890 or on 9-stable after r237938
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-08-15 11:20:47 UTC
Responsible Changed
From-To: freebsd-ports-bugs->thierry

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2012-08-26 13:03:45 UTC
Author: thierry
Date: Sun Aug 26 12:03:29 2012
New Revision: 303187
URL: http://svn.freebsd.org/changeset/ports/303187

Log:
  1) Fix build on recent current and 9-STABLE.
  
  2) Add an option to depend (or not) on freedesktop startup notification.
  
  PR:		ports/170645 (1) and ports/170667 (2)
  Submitted by:	Mykola Dzham <i (at) levsha.me> (1)
  		and Konstantinos Koukopoulos <koukopoulos (at) gmail.com> (2)

Modified:
  head/x11/rxvt-unicode/Makefile   (contents, props changed)

Modified: head/x11/rxvt-unicode/Makefile
==============================================================================
--- head/x11/rxvt-unicode/Makefile	Sun Aug 26 10:58:50 2012	(r303186)
+++ head/x11/rxvt-unicode/Makefile	Sun Aug 26 12:03:29 2012	(r303187)
@@ -7,7 +7,7 @@
 
 PORTNAME=	rxvt-unicode
 PORTVERSION=	9.15
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	x11
 MASTER_SITES=	http://dist.schmorp.de/rxvt-unicode/%SUBDIR%/
 MASTER_SITE_SUBDIR=	. Attic
@@ -26,7 +26,7 @@ USE_GNOME=		pkgconfig
 USE_XORG=		xpm xft xrender
 GNU_CONFIGURE=		yes
 CPPFLAGS+=		-I${LOCALBASE}/include
-CONFIGURE_ENV=		LIBS="-lutil"
+CONFIGURE_ENV=		LIBS="-lstdc++ -lutil"
 CONFIGURE_ARGS=		--enable-everything --with-term=rxvt	\
 			--with-terminfo=${LOCALBASE}/share/misc/terminfo.db
 USE_BZIP2=		yes
@@ -48,6 +48,7 @@ OPTIONS=	\
 	IMLOCALE_FIX	"imlocale encoding conversion fix" 		On	\
 	GDK_PIXBUF	"Use gdk-pixbuf for background images"		On	\
 	AFTERIMAGE	"Use libAfterImage for background images"	Off	\
+	NOTIFY		"Freedesktop startup notification support"	Off	\
 	256_COLOR	"Support for 256 colors"			Off
 
 .include <bsd.port.pre.mk>
@@ -139,7 +140,7 @@ CONFIGURE_ARGS+=	--disable-pixbuf
 . if defined(WITHOUT_AFTERIMAGE)
 CONFIGURE_ARGS+=	--disable-afterimage	# To be upgraded
 . else
-LIB_DEPENDS+=		AfterImage.0:${PORTSDIR}/graphics/libafterimage
+LIB_DEPENDS+=		AfterImage:${PORTSDIR}/graphics/libafterimage
 CONFIGURE_ARGS+=	--enable-afterimage
 . endif
 .else
@@ -147,6 +148,14 @@ USE_GNOME+=		gdkpixbuf2
 CONFIGURE_ARGS+=	--enable-pixbuf
 .endif
 
+# enable startup notification
+.if defined(WITHOUT_NOTIFY)
+CONFIGURE_ARGS+=	--disable-startup-notification
+.else
+CONFIGURE_ARGS+=	--enable-startup-notification
+LIB_DEPENDS+=		startup-notification-1:${PORTSDIR}/x11/startup-notification
+.endif
+
 # enable support for 256 colors
 .if defined(WITH_256_COLOR)
 CONFIGURE_ARGS+=	--enable-256-color
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Thierry Thomas freebsd_committer freebsd_triage 2014-06-01 07:47:14 UTC
State Changed
From-To: open->closed


Committed, thanks!