Bug 170667 - x11/rxvt-unicode: missing dependency on libstartup-notification
Summary: x11/rxvt-unicode: missing dependency on libstartup-notification
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Thierry Thomas
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-16 14:40 UTC by koukopoulos
Modified: 2012-08-26 13:10 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description koukopoulos 2012-08-16 14:40:05 UTC
The x11/rxvt-unicode port (9.15_1) produces a binary that depends on libstartup-notification in case that library exists on the system that is building it. This binary will not work however if the x11/startup-notification package is uninstalled or generally if it is unavailable on the target system. It should be an option which is explicitly enabled or disabled as a dependency.

How-To-Repeat: $ portmaster x11/startup-notification
.
$ portmaster x11/rxvt-unicode
..
$ pkg_delete -X startup-notification
$ /usr/local/bin/urxvt
Shared object "libstartup-notification-1.so.0" not found, required by "urxvt"
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-08-16 15:05:35 UTC
Responsible Changed
From-To: freebsd-ports-bugs->thierry

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2012-08-26 13:03:46 UTC
Author: thierry
Date: Sun Aug 26 12:03:29 2012
New Revision: 303187
URL: http://svn.freebsd.org/changeset/ports/303187

Log:
  1) Fix build on recent current and 9-STABLE.
  
  2) Add an option to depend (or not) on freedesktop startup notification.
  
  PR:		ports/170645 (1) and ports/170667 (2)
  Submitted by:	Mykola Dzham <i (at) levsha.me> (1)
  		and Konstantinos Koukopoulos <koukopoulos (at) gmail.com> (2)

Modified:
  head/x11/rxvt-unicode/Makefile   (contents, props changed)

Modified: head/x11/rxvt-unicode/Makefile
==============================================================================
--- head/x11/rxvt-unicode/Makefile	Sun Aug 26 10:58:50 2012	(r303186)
+++ head/x11/rxvt-unicode/Makefile	Sun Aug 26 12:03:29 2012	(r303187)
@@ -7,7 +7,7 @@
 
 PORTNAME=	rxvt-unicode
 PORTVERSION=	9.15
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	x11
 MASTER_SITES=	http://dist.schmorp.de/rxvt-unicode/%SUBDIR%/
 MASTER_SITE_SUBDIR=	. Attic
@@ -26,7 +26,7 @@ USE_GNOME=		pkgconfig
 USE_XORG=		xpm xft xrender
 GNU_CONFIGURE=		yes
 CPPFLAGS+=		-I${LOCALBASE}/include
-CONFIGURE_ENV=		LIBS="-lutil"
+CONFIGURE_ENV=		LIBS="-lstdc++ -lutil"
 CONFIGURE_ARGS=		--enable-everything --with-term=rxvt	\
 			--with-terminfo=${LOCALBASE}/share/misc/terminfo.db
 USE_BZIP2=		yes
@@ -48,6 +48,7 @@ OPTIONS=	\
 	IMLOCALE_FIX	"imlocale encoding conversion fix" 		On	\
 	GDK_PIXBUF	"Use gdk-pixbuf for background images"		On	\
 	AFTERIMAGE	"Use libAfterImage for background images"	Off	\
+	NOTIFY		"Freedesktop startup notification support"	Off	\
 	256_COLOR	"Support for 256 colors"			Off
 
 .include <bsd.port.pre.mk>
@@ -139,7 +140,7 @@ CONFIGURE_ARGS+=	--disable-pixbuf
 . if defined(WITHOUT_AFTERIMAGE)
 CONFIGURE_ARGS+=	--disable-afterimage	# To be upgraded
 . else
-LIB_DEPENDS+=		AfterImage.0:${PORTSDIR}/graphics/libafterimage
+LIB_DEPENDS+=		AfterImage:${PORTSDIR}/graphics/libafterimage
 CONFIGURE_ARGS+=	--enable-afterimage
 . endif
 .else
@@ -147,6 +148,14 @@ USE_GNOME+=		gdkpixbuf2
 CONFIGURE_ARGS+=	--enable-pixbuf
 .endif
 
+# enable startup notification
+.if defined(WITHOUT_NOTIFY)
+CONFIGURE_ARGS+=	--disable-startup-notification
+.else
+CONFIGURE_ARGS+=	--enable-startup-notification
+LIB_DEPENDS+=		startup-notification-1:${PORTSDIR}/x11/startup-notification
+.endif
+
 # enable support for 256 colors
 .if defined(WITH_256_COLOR)
 CONFIGURE_ARGS+=	--enable-256-color
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Thierry Thomas freebsd_committer freebsd_triage 2014-06-01 07:47:15 UTC
State Changed
From-To: open->closed


Committed, thanks!