170692 – sysutils/usermin: Incomplete perl module dependency causes password not to update correctly

no flags

Daniel Shaw (daniel@afrinic.net) discovered that usermin couldn't find a dependency to change the password, in change password menu. The dependancy is p5-IO-Tty which is called by changepasswd.cgi.

sub pty_process_exec
{
local ($cmd, $uid, $gid) = @_;
if (&is_readonly_mode()) {
        # When in readonly mode, don't run the command
        $cmd = "/bin/true";
        }
&webmin_debug_log('CMD', "cmd=$cmd uid=$uid gid=$gid")
        if ($gconfig{'debug_what_cmd'});

eval "use IO::Pty";
if (!$@) {
        # Use the IO::Pty perl module if installed
        local $ptyfh = new IO::Pty;
        if (!$ptyfh) {

pty_process_exec is later called in changepasswd.cgi:

                ($fh, $fpid) = &proc::pty_process_exec(
                                        $passwd_cmd, $uinfo[2], $uinfo[3]);

Fix: A workaround is to install p5-IO-Tty manually, and then the password is changed correctly and the webpage confirms the change.

Patch attached with submission follows:
How-To-Repeat: Go to change password, and change an existing user password. Nothing is displayed on the web page & the password isn't updated silently either.