Bug 170921 - Update to www/py-graphite-web
Summary: Update to www/py-graphite-web
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Ruslan Makhmatkhanov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-23 16:00 UTC by Chris McCoy
Modified: 2012-09-16 18:13 UTC (History)
0 users

See Also:


Attachments
file.diff (344 bytes, patch)
2012-08-23 16:00 UTC, Chris McCoy
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris McCoy 2012-08-23 16:00:10 UTC
Attached is the diff to make www/py-graphite-web correctly build again.

I have attached a diff, but am willing to provide a shar if that is the preferred format. The porters handbook seemed to point to diffs for updates and shars for creation.

Fix: Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-08-23 16:00:52 UTC
Class Changed
From-To: update->maintainer-update

Fix category (submitter is maintainer) (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2012-08-23 16:00:59 UTC
Responsible Changed
From-To: freebsd-ports-bugs->freebsd-python

freebsd-python@ wants this port PRs (via the GNATS Auto Assign Tool)
Comment 3 Ruslan Makhmatkhanov freebsd_committer freebsd_triage 2012-09-16 15:58:05 UTC
Responsible Changed
From-To: freebsd-python->rm

I will take it.
Comment 4 Ruslan Makhmatkhanov freebsd_committer freebsd_triage 2012-09-16 16:06:13 UTC
State Changed
From-To: open->feedback

Hi Chris. It's right to send patches as diffs, not shars. But there is 
two things that should be keeped in mind for future. Firstly, diffs 
should be in unified format (diff -uN) to make them more readable by 
reviewers. The second one, every time when original tarball's checksum 
changed (not within version update) one need to get old tarball and new 
one and compare them to make sure the new tarball wasn't trojaned or so. 
In this particular case I see that pypi and github holding different 
tarballs - they have equal content, but different size/checksums. So the 
more correct solution to this (imho) is to comment pypi mirror and leave 
github one, because tarball from here has an correct checksum (from 
oroginal distinfo). For the time being, you can ask upstream why the 
tarballs from pypi and github has different checksums.
Comment 5 dfilter service freebsd_committer freebsd_triage 2012-09-16 18:08:28 UTC
Author: rm
Date: Sun Sep 16 17:08:15 2012
New Revision: 304372
URL: http://svn.freebsd.org/changeset/ports/304372

Log:
  - fix fetch by commenting out CHEESESHOP mirrors
  
  while here:
  - fix plist
  - remove BUILD_DEPENDS (setup.py didn't checking for it on build phase)
  - limit python version to 2.x
  - whitespace fix in pkg-descr
  - bump PORTREVISION because of dependencies change
  
  PR:		170921
  Reported by:	Chris McCoy <bsdports at wayfair dot com> (maintainer)

Modified:
  head/www/py-graphite-web/Makefile
  head/www/py-graphite-web/pkg-descr
  head/www/py-graphite-web/pkg-plist

Modified: head/www/py-graphite-web/Makefile
==============================================================================
--- head/www/py-graphite-web/Makefile	Sun Sep 16 17:02:11 2012	(r304371)
+++ head/www/py-graphite-web/Makefile	Sun Sep 16 17:08:15 2012	(r304372)
@@ -7,22 +7,22 @@
 
 PORTNAME=	graphite-web
 PORTVERSION=	0.9.10
+PORTREVISION=	1
 CATEGORIES=	www python
-MASTER_SITES=	CHEESESHOP \
-		https://github.com/downloads/graphite-project/${PORTNAME}/
+#MASTER_SITES=	CHEESESHOP \
+MASTER_SITES=	https://github.com/downloads/graphite-project/${PORTNAME}/
 PKGNAMEPREFIX=	${PYTHON_PKGNAMEPREFIX}
 
 MAINTAINER=	bsdports@wayfair.com
 COMMENT=	Enterprise scalable realtime graphing platform
 
-BUILD_DEPENDS=	${PYTHON_PKGNAMEPREFIX}cairo>=1.8.10:${PORTSDIR}/graphics/py-cairo \
+RUN_DEPENDS=	${PYTHON_PKGNAMEPREFIX}cairo>=1.8.10:${PORTSDIR}/graphics/py-cairo \
 		${PYTHON_PKGNAMEPREFIX}carbon>=${PORTVERSION}:${PORTSDIR}/databases/py-carbon \
 		${PYTHON_PKGNAMEPREFIX}django>=1.3.1:${PORTSDIR}/www/py-django \
 		${PYTHON_PKGNAMEPREFIX}django-tagging>=0.3.1:${PORTSDIR}/www/py-django-tagging
-RUN_DEPENDS:=	${BUILD_DEPENDS}
 
 FETCH_ARGS=	-pRr
-USE_PYTHON=	2.6+
+USE_PYTHON=	-2.7
 USE_PYDISTUTILS=yes
 
 post-patch:

Modified: head/www/py-graphite-web/pkg-descr
==============================================================================
--- head/www/py-graphite-web/pkg-descr	Sun Sep 16 17:02:11 2012	(r304371)
+++ head/www/py-graphite-web/pkg-descr	Sun Sep 16 17:08:15 2012	(r304372)
@@ -1,4 +1,4 @@
-Graphite provides real-time visualization and storage 
+Graphite provides real-time visualization and storage
 of numeric time-series data on an enterprise level.
 
 WWW: http://graphite.wikidot.com/

Modified: head/www/py-graphite-web/pkg-plist
==============================================================================
--- head/www/py-graphite-web/pkg-plist	Sun Sep 16 17:02:11 2012	(r304371)
+++ head/www/py-graphite-web/pkg-plist	Sun Sep 16 17:08:15 2012	(r304372)
@@ -809,7 +809,6 @@ graphite/webapp/content/js/window/window
 @dirrm graphite/storage/rrd
 @dirrm graphite/storage/log/webapp
 @dirrm graphite/storage/log
-@dirrm graphite/storage/lists
 @dirrm graphite/storage
 @dirrm graphite
 @dirrm examples
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 6 Ruslan Makhmatkhanov freebsd_committer freebsd_triage 2012-09-16 18:13:42 UTC
State Changed
From-To: feedback->closed

The issue is resolved by commenting out CHEESESHOP mirrors, thanks!