Bug 171325 - [PATCH] devel/gdb: Use USE_READLINE=port to ensure port version of readline
Summary: [PATCH] devel/gdb: Use USE_READLINE=port to ensure port version of readline
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Bryan Drewery
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-04 16:10 UTC by Bryan Drewery
Modified: 2012-09-09 14:56 UTC (History)
0 users

See Also:


Attachments
patch-devel-gdb-use-readline.txt (624 bytes, patch)
2012-09-04 16:10 UTC, Bryan Drewery
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bryan Drewery freebsd_committer freebsd_triage 2012-09-04 16:10:01 UTC
	ports/162995 added USE_READLINE=port support to bsd.port.mk. This ensures that the port version is always used.
	By switching to using this, we can ensure someone does not accidentally break gdb again, and make portlint happy.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-09-04 16:10:15 UTC
Responsible Changed
From-To: freebsd-ports-bugs->bdrewery

Submitter has GNATS access (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2012-09-04 16:10:19 UTC
Maintainer of devel/gdb,

Please note that PR ports/171325 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/171325

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 Edwin Groothuis freebsd_committer freebsd_triage 2012-09-04 16:10:23 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 4 luca.pizzamiglio 2012-09-05 09:28:32 UTC
I tested the patch on redports and unfortunately the dependency is
failed on FreeBSD9/amd64.

the readline port was not installed and the linking phase failed (I
don't understand why, I've not enough information)..


On Tue, Sep 4, 2012 at 5:10 PM, Edwin Groothuis <edwin@freebsd.org> wrote:
> Maintainer of devel/gdb,
>
> Please note that PR ports/171325 has just been submitted.
>
> If it contains a patch for an upgrade, an enhancement or a bug fix
> you agree on, reply to this email stating that you approve the patch
> and a committer will take care of it.
>
> The full text of the PR can be found at:
>     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/171325
>
> --
> Edwin Groothuis via the GNATS Auto Assign Tool
> edwin@FreeBSD.org
Comment 5 Bryan Drewery freebsd_committer freebsd_triage 2012-09-08 03:50:29 UTC
Luca,

I think that failure was a fluke with redports. I re-ran the same
revision as last time and it passed this time:

http://redports.org/buildarchive/20120908011804-47766/

Can you please try rebuilding yourself as well?

Regards,
Bryan
Comment 6 luca.pizzamiglio 2012-09-08 16:54:19 UTC
Hi Bryan,

I've tested your patch on a "real" amd64 FreeBSD9 system without problem.
Patch approved!
thanks for your support!

Luca

On Sat, Sep 8, 2012 at 4:50 AM, Bryan Drewery <bdrewery@freebsd.org> wrote:
> Luca,
>
> I think that failure was a fluke with redports. I re-ran the same
> revision as last time and it passed this time:
>
> http://redports.org/buildarchive/20120908011804-47766/
>
> Can you please try rebuilding yourself as well?
>
> Regards,
> Bryan
Comment 7 Bryan Drewery freebsd_committer freebsd_triage 2012-09-09 14:56:03 UTC
State Changed
From-To: feedback->closed

Committed.