Bug 171408 - [PATCH] games/fretsonfire: Makefile changed, now find numpy, OptionsNG
Summary: [PATCH] games/fretsonfire: Makefile changed, now find numpy, OptionsNG
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Jose Alonso Cardenas Marquez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-07 12:20 UTC by nemysis
Modified: 2013-03-24 05:20 UTC (History)
1 user (show)

See Also:


Attachments
fretsonfire-1.3.110_3.patch (3.21 KB, patch)
2012-09-07 12:20 UTC, nemysis
no flags Details | Diff
fretsonfire.diff (3.95 KB, patch)
2012-09-07 12:31 UTC, nemysis
no flags Details | Diff
fretsonfire.diff (7.77 KB, patch)
2012-09-21 15:16 UTC, nemysis
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description nemysis 2012-09-07 12:20:02 UTC
Makefile changed

Now find numpy

RUN_DEPENDS=	${PYNUMPY} \

Added OptionsNG

Don't install install.txt, not needed after Installation.

Port maintainer (acm@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.99_6 (mode: change, diff: ports)
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-09-07 12:20:15 UTC
Responsible Changed
From-To: freebsd-ports-bugs->acm

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 nemysis 2012-09-21 15:16:05 UTC
portlint -A
WARN: Makefile: Consider adding support for a WITHOUT_NLS knob to conditionally disable gettext support.
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
WARN: Makefile: new ports should not set PORTREVISION.
0 fatal errors and 3 warnings found.

WARN: Makefile: Consider adding support for a WITHOUT_NLS knob

because Port install always in NLS

/usr/local/share/fretsonfire/translations


Build log RedPorts

https://redports.org/buildarchive/20120921122751-50054/
Comment 3 Jose Alonso Cardenas Marquez freebsd_committer freebsd_triage 2013-03-24 05:09:43 UTC
State Changed
From-To: open->closed

- Committed with few modifications, thanks!!
Comment 4 dfilter service freebsd_committer freebsd_triage 2013-03-24 05:09:44 UTC
Author: acm
Date: Sun Mar 24 05:09:32 2013
New Revision: 315097
URL: http://svnweb.freebsd.org/changeset/ports/315097

Log:
  - Remove BROKEN
  - Bump PORTREVISION
  
  PR:		171408
  Submitted by:	nemysis <nemysis  at gmx.ch>
  > Description of fields to fill in above:                     76 columns --|
  > PR:            If a GNATS PR is affected by the change.
  > Submitted by:  If someone else sent in the change.
  > Reviewed by:   If someone else reviewed your modification.
  > Approved by:   If you needed approval for this commit.
  > Obtained from: If the change is from a third party.
  > MFC after:     N [day[s]|week[s]|month[s]].  Request a reminder email.
  > Security:      Vulnerability reference (one per line) or description.
  > Empty fields above will be automatically removed.
  
  M    games/fretsonfire/Makefile
  M    games/fretsonfire/pkg-descr

Modified:
  head/games/fretsonfire/Makefile
  head/games/fretsonfire/pkg-descr

Modified: head/games/fretsonfire/Makefile
==============================================================================
--- head/games/fretsonfire/Makefile	Sun Mar 24 05:05:42 2013	(r315096)
+++ head/games/fretsonfire/Makefile	Sun Mar 24 05:09:32 2013	(r315097)
@@ -7,7 +7,7 @@
 
 PORTNAME=	fretsonfire
 PORTVERSION=	1.3.110
-PORTREVISION=	2
+PORTREVISION=	3
 CATEGORIES=	games python
 MASTER_SITES=	SF
 DISTNAME=	${PORTNAME:S/f/F/g:S/o/O/}-${PORTVERSION}
@@ -16,18 +16,16 @@ DIST_SUBDIR=	${PORTNAME}
 MAINTAINER=	acm@FreeBSD.org
 COMMENT=	A game of musical skill and fast fingers
 
-RUN_DEPENDS=	${PYTHON_SITELIBDIR}/numpy:${PORTSDIR}/math/py-numpy \
-		${PYTHON_SITELIBDIR}/pygame/__init__.py:${PORTSDIR}/devel/py-game \
-		${PYTHON_SITELIBDIR}/OpenGL/__init__.py:${PORTSDIR}/graphics/py-opengl \
-		${PYTHON_SITELIBDIR}/PIL/__init__.py:${PORTSDIR}/graphics/py-imaging \
+RUN_DEPENDS=	${PYNUMPY} \
+		${PYTHON_PKGNAMEPREFIX}game>=0:${PORTSDIR}/devel/py-game \
+		${PYTHON_PKGNAMEPREFIX}opengl>=0:${PORTSDIR}/graphics/py-opengl \
+		${PYTHON_PKGNAMEPREFIX}imaging>=0:${PORTSDIR}/graphics/py-imaging \
 		${LOCALBASE}/share/${PORTNAME}/default.ttf:${PORTSDIR}/games/fretsonfire-data
 
 USE_PYTHON=	yes
 USE_DOS2UNIX=	*.txt
 NO_BUILD=	yes
 
-BROKEN=		does not build
-
 DATADIR=	share/${PORTNAME}
 EXTRACT_AFTER_ARGS=	| ${TAR} -xf - --exclude 'data'
 SUB_FILES=	pkg-message FretsOnFire
@@ -56,7 +54,7 @@ do-install:
 	${LN} -s ${LOCALBASE}/${DATADIR}/* ${FOF_DIR}/data
 	${INSTALL_SCRIPT} ${WRKDIR}/${PORTNAME:S/f/F/g:S/o/O/} ${PREFIX}/bin
 
-.if !defined(NOPORTDOCS)
+.if ${PORT_OPTIONS:MDOCS}
 	${MKDIR} ${DOCSDIR}
 	${INSTALL_DATA} ${WRKSRC}/readme.txt ${DOCSDIR}/README
 	${INSTALL_DATA} ${WRKSRC}/install.txt ${DOCSDIR}/INSTALL

Modified: head/games/fretsonfire/pkg-descr
==============================================================================
--- head/games/fretsonfire/pkg-descr	Sun Mar 24 05:05:42 2013	(r315096)
+++ head/games/fretsonfire/pkg-descr	Sun Mar 24 05:09:32 2013	(r315097)
@@ -1,4 +1,4 @@
 Frets on Fire is a game of musical skill and fast fingers. The aim of the game 
 is to play guitar with the keyboard as accurately as possible.
 
-WWW:	http://louhi.kempele.fi/~skyostil/uv/fretsonfire/
+WWW:	http://fretsonfire.sf.net
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"