Bug 171579 - make cjson an option for devel/py-jsonrpclib
Summary: make cjson an option for devel/py-jsonrpclib
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Ruslan Makhmatkhanov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-12 17:30 UTC by Brian Coca
Modified: 2012-10-16 16:09 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Coca 2012-09-12 17:30:07 UTC 
cjson has compatibility issues with the other python json libraries, the proposed patch makes it an option (default off) to depend on cjson, the jsonrpclib code will fall back to the built in json or simplejson.




--- /usr/ports/devel/py-jsonrpclib/Makefile     2011-09-22 03:04:24.000000000 -0400
+++ Makefile    2012-09-12 12:26:52.730469768 -0400
@@ -14,7 +14,12 @@
 MAINTAINER=    bra@fsn.hu
 COMMENT=       Implements the JSON-RPC 2.0 proposed specification in pure Python
 
-RUN_DEPENDS=   ${PYTHON_SITELIBDIR}/cjson.so:${PORTSDIR}/devel/py-cjson
+OPTIONS=    CJSON "Use cjson vs json or simplejson" off
+
+.ifdef WITH_CJSON
+RUN_DEPENDS+=   ${PYTHON_SITELIBDIR}/cjson.so:${PORTSDIR}/devel/py-cjson
+USE_CJSON =  yes
+.endif
 
 USE_PYTHON=            yes
 USE_PYDISTUTILS=       yes
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-09-12 20:39:54 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->freebsd-python

freebsd-python@ wants this port PRs (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2012-09-12 20:39:58 UTC 
Maintainer of devel/py-jsonrpclib,

Please note that PR ports/171579 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/171579

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 Edwin Groothuis freebsd_committer freebsd_triage 2012-09-12 20:40:05 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 4 nagy.attila 2012-10-12 07:52:08 UTC 
Fine with me, thanks.

On 09/12/12 21:39, Edwin Groothuis wrote:
> Maintainer of devel/py-jsonrpclib,
>
> Please note that PR ports/171579 has just been submitted.
>
> If it contains a patch for an upgrade, an enhancement or a bug fix
> you agree on, reply to this email stating that you approve the patch
> and a committer will take care of it.
>
> The full text of the PR can be found at:
>      http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/171579
>
Comment 5 Mark Linimon freebsd_committer freebsd_triage 2012-10-13 23:20:43 UTC 
State Changed
From-To: feedback->open

Maintainer approved.
Comment 6 Ruslan Makhmatkhanov freebsd_committer freebsd_triage 2012-10-16 16:07:23 UTC 
Responsible Changed
From-To: freebsd-python->rm

I will take it.
Comment 7 Ruslan Makhmatkhanov freebsd_committer freebsd_triage 2012-10-16 16:09:56 UTC 
State Changed
From-To: open->closed

Committed, thank you!