Bug 171585 - audio/easytag: missing dependency on libid3tag
Summary: audio/easytag: missing dependency on libid3tag
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Roman Bogorodskiy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-12 20:40 UTC by cjr
Modified: 2012-09-23 18:33 UTC (History)
0 users

See Also:


Attachments
file.diff (457 bytes, patch)
2012-09-12 20:40 UTC, cjr
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description cjr 2012-09-12 20:40:07 UTC
Easytag is a - I quote from the makefile - "GTK2 Tag editor for MP3 and OGG files". Since some time it is not possible anymore to edit mp3 files - mp4 and ogg is working fine. The problem appeared in PCBSD also (http://forums.pcbsd.org/showthread.php?t=17282).

Fix: It appears that easytag depends on libid3tag to edit mp3 tags and that dependency is not pulled anymore - I do not understand why. Neither do I know why the problem has not been noticed before - at least according to the PR DB. Anyways, adding id3tag to the depends-statements solves the problem.

Adding a conditional depend for id3tag is possible, but, considering the description in the makefile, not really an option.

Patch attached with submission follows:
How-To-Repeat: Build easytag in an environment where libid3tag is missing - poudriere in my case. Install easytag. Try to load a directory containing mp3-files. You will not be presented with any editing option. Then check Help -> About. The MP3 tagging capability will be crossed out.

Install libid3tag. Build easytag anew. The problem will be gone.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-09-12 21:01:44 UTC
Responsible Changed
From-To: freebsd-ports-bugs->novel

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2012-09-23 18:29:38 UTC
Author: novel
Date: Sun Sep 23 17:29:12 2012
New Revision: 304754
URL: http://svn.freebsd.org/changeset/ports/304754

Log:
  - Add a missing dependency on libid3tag [1]
  - Drop shlib versions from the dependency lines
  - Update headers to the new format
  
  PR:		171585 [1]
  Submitted by:	Christopher J. Ruwe <cjr@cruwe.de> [1]

Modified:
  head/audio/easytag/Makefile

Modified: head/audio/easytag/Makefile
==============================================================================
--- head/audio/easytag/Makefile	Sun Sep 23 17:12:59 2012	(r304753)
+++ head/audio/easytag/Makefile	Sun Sep 23 17:29:12 2012	(r304754)
@@ -1,13 +1,9 @@
-# New ports collection makefile for:	easytag-devel
-# Date created:				15 Feb 2005
-# Whom:					Adam Weinberger <adamw@FreeBSD.org>
-#
+# Created by:	Adam Weinberger <adamw@FreeBSD.org>
 # $FreeBSD$
-#
 
 PORTNAME=	easytag
 PORTVERSION=	2.1.7
-PORTREVISION=	2
+PORTREVISION=	3
 CATEGORIES=	audio
 MASTER_SITES=	SF/${PORTNAME}/${PORTNAME}%20%28gtk%202%29/${PORTVERSION:C/\.[0-9]+$//}
 
@@ -15,9 +11,10 @@ MAINTAINER=	novel@FreeBSD.org
 COMMENT=	GTK2 Tag editor for MP3 and OGG files
 
 LIB_DEPENDS=	id3:${PORTSDIR}/audio/id3lib \
+		id3tag:${PORTSDIR}/audio/libid3tag \
 		vorbis:${PORTSDIR}/audio/libvorbis \
 		FLAC:${PORTSDIR}/audio/flac \
-		mp4v2.10:${PORTSDIR}/multimedia/mp4v2
+		mp4v2:${PORTSDIR}/multimedia/mp4v2
 
 MAN1=		easytag.1
 CONFLICTS=	easytag-devel-[0-9]*
@@ -30,7 +27,7 @@ CPPFLAGS+=	-I${LOCALBASE}/include -DHAVE
 LDFLAGS+=	-L${LOCALBASE}/lib
 
 .if defined(WITH_WAVPACK)
-LIB_DEPENDS+=		wavpack.2:${PORTSDIR}/audio/wavpack
+LIB_DEPENDS+=		wavpack:${PORTSDIR}/audio/wavpack
 CONFIGURE_ARGS+=	--enable-wavpack
 .else
 CONFIGURE_ARGS+=	--disable-wavpack
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Roman Bogorodskiy freebsd_committer freebsd_triage 2012-09-23 18:33:42 UTC
State Changed
From-To: open->closed

Committed, thanks!