Bug 171688 - [bsd.port.mk / bsd.sites.mk] Allow WRKSRC to be overridden when using USE_GITHUB
Summary: [bsd.port.mk / bsd.sites.mk] Allow WRKSRC to be overridden when using USE_GITHUB
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Beat Gaetzi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-16 18:10 UTC by Bryan Drewery
Modified: 2012-10-10 19:23 UTC (History)
1 user (show)

See Also:

Attachments
patch-use-github-wrksrc.txt (811 bytes, patch)
2012-09-16 18:10 UTC, Bryan Drewery 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bryan Drewery freebsd_committer freebsd_triage 2012-09-16 18:10:15 UTC 
	When using USE_GITHUB, it is not possible to override WRKSRC. This is needed for ports such as www/phalcon and cad/openvsp.

Fix: Fix is to move the WRKSRC for github up to bsd.port.mk before the default WRKSRC is set, and use the same logic that bsd.sites.mk uses for USE_GITHUB.

	Mirrored at http://people.freebsd.org/~bdrewery/patch-use-github-wrksrc.txt
How-To-Repeat: 	Apply http://people.freebsd.org/~bdrewery/patch-cad-openvsp-use-github.txt to cad/openvsp and try to build. It will override WRKSRC and lose the /src subdir.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-09-16 18:10:26 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->portmgr

bsd.port.mk is portmgr territory (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=171688 

Date: Mon, 17 Sep 2012 09:21:43 +0200
Comment 2 Beat Gaetzi freebsd_committer freebsd_triage 2012-10-07 11:21:55 UTC 
Responsible Changed
From-To: portmgr->beat

Take for exp-run.
Comment 3 Beat Gaetzi freebsd_committer freebsd_triage 2012-10-10 19:23:03 UTC 
State Changed
From-To: open->closed

Committed. Thanks!