Bug 171813 - [PATCH] fix ffmpeg dependency in audio/sox
Summary: [PATCH] fix ffmpeg dependency in audio/sox
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Jason E. Hale
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-20 18:30 UTC by Dan Nelson
Modified: 2012-09-23 22:30 UTC (History)
0 users

See Also:

Attachments
file.diff (504 bytes, patch)
2012-09-20 18:30 UTC, Dan Nelson 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dan Nelson 2012-09-20 18:30:10 UTC 
	
The dependency line in the sox port just lists "avformat", which matches the
avformat library installed by both ffmpeg and ffmpeg-devel.  sox only wants
regular ffmpeg, though, so use the same depends line that other audio
ports use.

How-To-Repeat: 	

Install ffmpeg-devel, try to install sox, configure fails with a "cannot
find ffmpeg" error.
Comment 1 Jason E. Hale freebsd_committer freebsd_triage 2012-09-23 21:47:37 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->jhale

I'll take it.
Comment 2 Jason E. Hale freebsd_committer freebsd_triage 2012-09-23 22:19:41 UTC 
State Changed
From-To: open->closed

Committed. Thanks!
Comment 3 dfilter service freebsd_committer freebsd_triage 2012-09-23 22:20:10 UTC 
Author: jhale
Date: Sun Sep 23 21:19:18 2012
New Revision: 304766
URL: http://svn.freebsd.org/changeset/ports/304766

Log:
  - Fix FFMPEG option when ffmpeg-devel is installed
  
  While here:
  - Move LICENSE to proper location
  - Convert to USE_PKGCONFIG
  
  PR:		ports/171813
  Submitted by:	Dan Nelson <dnelson at allantgroup.com> (maintainer)
  Approved by:	makc (mentor)

Modified:
  head/audio/sox/Makefile   (contents, props changed)

Modified: head/audio/sox/Makefile
==============================================================================
--- head/audio/sox/Makefile	Sun Sep 23 20:47:31 2012	(r304765)
+++ head/audio/sox/Makefile	Sun Sep 23 21:19:18 2012	(r304766)
@@ -14,6 +14,9 @@ MASTER_SITES=	SF
 MAINTAINER=	dnelson@allantgroup.com
 COMMENT=	SOund eXchange - universal sound sample translator
 
+LICENSE=	LGPL21 GPLv2
+LICENSE_COMB=	dual
+
 CONFLICTS=	play-[0-9]*
 
 MAN1=		sox.1 soxi.1
@@ -23,9 +26,7 @@ MLINKS=		sox.1 play.1 sox.1 rec.1 sox.1 
 GNU_CONFIGURE=	yes
 USE_LDCONFIG=	yes
 USE_AUTOTOOLS=	libltdl
-USE_GNOME=	pkgconfig
-LICENSE_COMB=	dual
-LICENSE=	LGPL21 GPLv2
+USE_PKGCONFIG=	build
 
 # Default LAME to off for packages so we don't end up RESTRICTED
 .if defined(PACKAGE_BUILDING)
@@ -88,7 +89,7 @@ CONFIGURE_ARGS+=	--without-amrwb
 
 .if defined(WITH_FFMPEG)
 CONFIGURE_ARGS+=	--with-ffmpeg
-LIB_DEPENDS+=		avformat:${PORTSDIR}/multimedia/ffmpeg
+LIB_DEPENDS+=		avcodec.1:${PORTSDIR}/multimedia/ffmpeg
 .else
 CONFIGURE_ARGS+=	--without-ffmpeg
 .endif
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"