Bug 171920 - japanese/p5-nkf: there is a typo in pkg-descr
Summary: japanese/p5-nkf: there is a typo in pkg-descr
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Frederic Culot
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-24 14:30 UTC by Takanori Yamamoto
Modified: 2012-09-25 08:40 UTC (History)
0 users

See Also:


Attachments
file.diff (258 bytes, patch)
2012-09-24 14:30 UTC, Takanori Yamamoto
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Takanori Yamamoto 2012-09-24 14:30:10 UTC
pkg-descr says the syntax of p5-nkf is:

        use NKF;
        $output = nkf ($flags, $input)

But the first argument of nkf() have to be an array, not a scalar value. So it should be:

        use NKF;
        $output = nkf (@flags, $input)

(for more details about the usage of p5-nkf, see: nkf-2.1.2/NKF.mod/README)

Fix: --- japanese/p5-nkf/pkg-descr.orig	2011-10-24 13:16:01.000000000 +0900
+++ japanese/p5-nkf/pkg-descr	2012-09-24 22:08:18.000000000 +0900
@@ -3,4 +3,4 @@
 The syntax is as follows:
 
 	use NKF;
-	$output = nkf ($flags, $input)
+	$output = nkf (@flags, $input)


Patch attached with submission follows:
How-To-Repeat: This is a documentation bug.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-09-24 14:30:33 UTC
Responsible Changed
From-To: freebsd-ports-bugs->perl

perl@ wants this port PRs (via the GNATS Auto Assign Tool)
Comment 2 Frederic Culot freebsd_committer freebsd_triage 2012-09-24 16:04:50 UTC
Responsible Changed
From-To: perl->culot

I'll take it.
Comment 3 dfilter service freebsd_committer freebsd_triage 2012-09-25 08:35:01 UTC
Author: culot
Date: Tue Sep 25 07:34:49 2012
New Revision: 304819
URL: http://svn.freebsd.org/changeset/ports/304819

Log:
  - Fix typo in pkg-descr [1]
  - While here, enhance description a bit
  
  PR:		ports/171920 [1]
  Submitted by:	Takanori Yamamoto <takanori@miko.org>

Modified:
  head/japanese/p5-nkf/pkg-descr

Modified: head/japanese/p5-nkf/pkg-descr
==============================================================================
--- head/japanese/p5-nkf/pkg-descr	Tue Sep 25 07:07:33 2012	(r304818)
+++ head/japanese/p5-nkf/pkg-descr	Tue Sep 25 07:34:49 2012	(r304819)
@@ -1,6 +1,11 @@
-This is a Perl extension module to use NKF.
+This is a Perl extension module to use NKF (Network Kanji Filter).
+It converts the kanji code given as input (which encoding is
+automatically recognized) to designated kanji code such as ISO-2022-JP,
+Shift_JIS, EUC-JP, UTF-8, UTF-16 or UTF-32.
 
 The syntax is as follows:
 
 	use NKF;
-	$output = nkf ($flags, $input)
+	$output = nkf (@flags, $input)
+
+WWW: http://sourceforge.jp/projects/nkf/
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 4 Frederic Culot freebsd_committer freebsd_triage 2012-09-25 08:35:26 UTC
State Changed
From-To: open->closed

Committed, with minor changes. Thanks!