Bug 172143 - updated astro/xearth to build with clang with no warnings
Summary: updated astro/xearth to build with clang with no warnings
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Guido Falsi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-28 12:30 UTC by Anton Shterenlikht
Modified: 2012-10-15 13:03 UTC (History)
0 users

See Also:


Attachments
file.diff (2.77 KB, patch)
2012-09-28 12:30 UTC, Anton Shterenlikht
no flags Details | Diff
xearth.diff (2.80 KB, patch)
2012-10-14 22:26 UTC, Guido Falsi
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anton Shterenlikht 2012-09-28 12:30:05 UTC
astro/xearth is abandoned upstream.
Well.. there's just no upstream anymore.
So, I made my changes to the source,
rather than with patches.

The changes:

1. Updated the software's own makefile.
2. Updated 2 src C files, and one documentation file.
3. Build with BSD make, not imake.
4. Removed pkg-plist, and replaced it with
   PLIST_FILES, PLIST_DIRS.
5. I now distribute the tarball compressed with xz. 
6. Bumped PORTVERSION
7. Because PORTVERSION changed, I have to update
   the number of the tarball. Since the new
   tarball is only available from my site at this
   point, modified MASTER_SITES accordingly.
Comment 1 Guido Falsi freebsd_committer freebsd_triage 2012-10-07 11:12:41 UTC
Responsible Changed
From-To: freebsd-ports-bugs->madpilot

I'll take it.
Comment 2 Guido Falsi freebsd_committer freebsd_triage 2012-10-07 11:28:01 UTC
Hi,

As you (Piero) can see from the PR I'm testing the update to this port.

I'd like to know how you'd like to be credited in the "Created by:" line 
after this update.

As you can read here(if you do not know already):

http://blogs.freebsdish.org/portmgr/2012/09/17/change-to-the-header-in-ports-makefiles-take-two/

You have the option of doing without the attribution. Otherwise Id like 
to change it to:

Created by: Piero Serini <piero@FreeBSD.org>

but if this is a problem to you I'll leave it as:

Created by: piero

Thank you in advance for your reply!

-- 
Guido Falsi <madpilot@FreeBSD.org>
Comment 3 Guido Falsi freebsd_committer freebsd_triage 2012-10-14 22:26:11 UTC
Hi!

Thanks for the patch, I have made a few small modifications. Most
notably I changed the post-install target to do-install, since the
upstream sources do a noop install, we are doing all the work, so no
need to call their install.

I also uploaded the distfile to the FreBSD local mirror.

Can you approve this patch?

Thanks.

-- 
Guido Falsi <mad@madpilot.net>
Comment 4 Guido Falsi freebsd_committer freebsd_triage 2012-10-14 22:27:33 UTC
State Changed
From-To: open->feedback

Ask for maintainer approval.
Comment 5 Anton Shterenlikht 2012-10-15 09:46:15 UTC
Yes, this is fine, thank you.

Anton
Comment 6 Guido Falsi freebsd_committer freebsd_triage 2012-10-15 09:56:25 UTC
State Changed
From-To: feedback->open

Maintainer has approved via private email.
Comment 7 Guido Falsi freebsd_committer freebsd_triage 2012-10-15 13:03:49 UTC
State Changed
From-To: open->closed

Committed. Thanks!