Bug 172211 - [PATCH] x11-wm/fvwm2 fix configure with clang
Summary: [PATCH] x11-wm/fvwm2 fix configure with clang
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Cy Schubert
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-01 15:40 UTC by Guido Falsi
Modified: 2013-02-04 17:00 UTC (History)
1 user (show)

See Also:


Attachments
file.diff (1.31 KB, patch)
2012-10-01 15:40 UTC, Guido Falsi
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Guido Falsi freebsd_committer freebsd_triage 2012-10-01 15:40:03 UTC
Configure fails because clang refuses to compile a main not returning
an int. It blames -Werror, but this is not the case with clang.

Attached patch removes this check. Perhaps this is not the best
fix, but works correctly. perhaps setting -Wno-return-type is also
an option.

While testing this I also noticed that the configure script gets
modified in post-patch, so during configure phase autoconf sees it
sith a newer date and does not touch it even if USE_AUTOTOOLS=autoconf
is defined. So I added the touch command to fix this.

Maintainer is CCed.

How-To-Repeat: 
Try to compile x11-wm/fvwm2 on a 10-CURRENT system with WITH_CLANG_IS_CC=yes
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-10-01 15:40:14 UTC
Responsible Changed
From-To: freebsd-ports-bugs->cy

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Cy Schubert freebsd_committer freebsd_triage 2013-02-04 16:54:49 UTC
State Changed
From-To: open->closed

Fixed by PR/175760.
Comment 3 dfilter service freebsd_committer freebsd_triage 2013-02-04 16:59:12 UTC
Author: cy
Date: Mon Feb  4 16:58:33 2013
New Revision: 311637
URL: http://svnweb.freebsd.org/changeset/ports/311637

Log:
  Fix build under 10-CURRENT.
  
  PR:		172211, 175760
  Submitted by:	Niclas Zeising <zeising@daemonic.se>

Added:
  head/x11-wm/fvwm2/files/patch-configure.ac   (contents, props changed)

Added: head/x11-wm/fvwm2/files/patch-configure.ac
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/x11-wm/fvwm2/files/patch-configure.ac	Mon Feb  4 16:58:33 2013	(r311637)
@@ -0,0 +1,11 @@
+--- configure.ac.bak	2013-02-01 10:35:04.191557713 +0100
++++ configure.ac	2013-02-01 10:35:12.513558507 +0100
+@@ -225,7 +225,7 @@
+   switch (*p = p = *c) { case 0: printf("%Q", c, p); }
+   *c = &i; c = p;
+   while (1 || (unsigned int)3 >= 0 || ((int)-1) == ((unsigned int)1));
+-  return;], , AC_MSG_ERROR("
++  return 0;], , AC_MSG_ERROR("
+ configure is not able to compile programs with warnings.  Please
+ remove all offending options like -Werror from the CFLAGS and
+ CPPFLAGS variables and run configure again."))
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"