Bug 172265 - [maintainer-update] converters/gbsdconv 1.0
Summary: [maintainer-update] converters/gbsdconv 1.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Bryan Drewery
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-02 08:50 UTC by buganini
Modified: 2012-10-08 17:30 UTC (History)
0 users

See Also:


Attachments
file.diff (2.03 KB, patch)
2012-10-02 08:50 UTC, buganini
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description buganini 2012-10-02 08:50:02 UTC
Update converters/gbsdconv to 1.0

Changelog:
	chase py-bsdconv update
	utilize new API in taglib 1.8 to allow saving ID3v2.3

Fix: Patch attached with submission follows:
Comment 1 buganini 2012-10-02 08:56:52 UTC
Buildlog:
https://redports.org/buildarchive/20121002063038-27138/
Comment 2 Bryan Drewery freebsd_committer freebsd_triage 2012-10-03 16:23:31 UTC
Responsible Changed
From-To: freebsd-ports-bugs->bdrewery

I'll take it.
Comment 3 Bryan Drewery freebsd_committer freebsd_triage 2012-10-08 17:22:34 UTC
State Changed
From-To: open->closed

Committed, with minor changes. Thanks!
Comment 4 dfilter service freebsd_committer freebsd_triage 2012-10-08 17:22:39 UTC
Author: bdrewery
Date: Mon Oct  8 16:22:29 2012
New Revision: 305545
URL: http://svn.freebsd.org/changeset/ports/305545

Log:
  - Update to 1.0 [1]
  - Remove ABI version from LIB_DEPENDS [1]
  - Update to new header
  - Use USE_GITHUB for fetching
  
  Changelog:
    chase py-bsdconv update
    utilize new API in taglib 1.8 to allow saving ID3v2.3
  
  PR:		ports/172265 [1]
  Submitted by:	Kuan-Chung Chiu <buganini@gmail.com> (maintainer) [1]

Modified:
  head/converters/gbsdconv/Makefile
  head/converters/gbsdconv/distinfo

Modified: head/converters/gbsdconv/Makefile
==============================================================================
--- head/converters/gbsdconv/Makefile	Mon Oct  8 16:17:25 2012	(r305544)
+++ head/converters/gbsdconv/Makefile	Mon Oct  8 16:22:29 2012	(r305545)
@@ -1,35 +1,33 @@
-# New ports collection makefile for:	gbsdconv
-# Date created:		22 Dec, 2011
-# Whom:			buganini@gmail.com
-#
+# Created by: buganini@gmail.com
 # $FreeBSD$
-#
 
 PORTNAME=	gbsdconv
-PORTVERSION=	0.4
-PORTREVISION=	1
+PORTVERSION=	1.0
 CATEGORIES=	converters python
-MASTER_SITES=	https://github.com/buganini/${PORTNAME}/tarball/${PORTVERSION}/
-DISTNAME=	buganini-${PORTNAME}-${PORTVERSION}-0-g${GITVERSION}
+DISTNAME=	buganini-${PORTNAME}-${PORTVERSION}-0-g${GH_COMMIT}
 
 MAINTAINER=	buganini@gmail.com
 COMMENT=	GUI for bsdconv
 
 LICENSE=	BSD
 
-LIB_DEPENDS=	tag_c.0:${PORTSDIR}/audio/taglib
-RUN_DEPENDS=	${PYTHON_PKGNAMEPREFIX}bsdconv>=7.2:${PORTSDIR}/converters/py-bsdconv \
+LIB_DEPENDS=	tag:${PORTSDIR}/audio/taglib
+RUN_DEPENDS=	${PYTHON_PKGNAMEPREFIX}bsdconv>=8.0:${PORTSDIR}/converters/py-bsdconv \
 		${LOCALBASE}/bin/g-ir-scanner:${PORTSDIR}/devel/gobject-introspection
 
-GITVERSION=	22788c2
-FETCH_ARGS=	-pRr
-WRKSRC=		${WRKDIR}/buganini-${PORTNAME}-${GITVERSION}
+USE_GITHUB=	yes
+GH_ACCOUNT=	buganini
+GH_COMMIT=	ac7e05f
 
-NO_BUILD=	yes
 USE_GNOME=	gtk30
 USE_PYTHON=	yes
 
+USE_LDCONFIG=	yes
+
+MAKE_ARGS=	PREFIX=${PREFIX}
+
 PLIST_FILES=	bin/gbsdconv \
+		lib/gbsdconv_taglib.so \
 		%%DATADIR%%/gbsdconv.png \
 		%%DATADIR%%/gbsdconv.xml \
 		%%DATADIR%%/gbsdconv2.png
@@ -38,10 +36,4 @@ PLIST_DIRS=	%%DATADIR%%
 post-patch:
 	@${REINPLACE_CMD} -e 's|/usr/local|${LOCALBASE}|g' ${WRKSRC}/gbsdconv
 
-do-install:
-	${MKDIR} ${DATADIR}/
-	cd ${WRKSRC}/ && \
-		${INSTALL_SCRIPT} gbsdconv ${PREFIX}/bin/ && \
-		${INSTALL_DATA} gbsdconv.png gbsdconv.xml gbsdconv2.png ${DATADIR}/
-
 .include <bsd.port.mk>

Modified: head/converters/gbsdconv/distinfo
==============================================================================
--- head/converters/gbsdconv/distinfo	Mon Oct  8 16:17:25 2012	(r305544)
+++ head/converters/gbsdconv/distinfo	Mon Oct  8 16:22:29 2012	(r305545)
@@ -1,2 +1,2 @@
-SHA256 (buganini-gbsdconv-0.4-0-g22788c2.tar.gz) = b6b736ba042d9e569479751b58c496a5b4e4f2035695c7e7d13813cba3799a90
-SIZE (buganini-gbsdconv-0.4-0-g22788c2.tar.gz) = 15107
+SHA256 (buganini-gbsdconv-1.0-0-gac7e05f.tar.gz) = 9172626f50db686c16b997ce99b88455fcd03e0d0331cf0fdadca11dce067e61
+SIZE (buganini-gbsdconv-1.0-0-gac7e05f.tar.gz) = 19724
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"