Bug 172342 - [PATCH] graphics/eos-movrec: Makefile changed, OptionsNG, take maintainership
Summary: [PATCH] graphics/eos-movrec: Makefile changed, OptionsNG, take maintainership
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Alex Kozlov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-05 00:20 UTC by nemysis
Modified: 2012-10-06 22:10 UTC (History)
0 users

See Also:


Attachments
eos-movrec-0.3.1_2.patch (2.10 KB, patch)
2012-10-05 00:20 UTC, nemysis
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description nemysis 2012-10-05 00:20:07 UTC
- Take maintainership

- Used more correct

+PORTVERSION=	0.3.1

+DISTNAME=	${PORTNAME}-${DISTVERSION}_beta-src

- Changed COMMENT

+COMMENT=	Program to capture short movies with Canon DSLR camera

- Added EXTRACT_DEPENDS

+EXTRACT_DEPENDS=convert:${PORTSDIR}/graphics/ImageMagick

- Not needed, WRKSRC is default

-WRKSRC=		${WRKDIR}/${PORTNAME}-${DISTVERSION}
-DISTVERSIONSUFFIX=	-src
-PORTREVISION=	1

- Added DESKTOP_ENTRIES

+DESKTOP_ENTRIES

- Added post-extract and post-install to have png for DESKTOP_ENTRIES

+post-extract:
+	@(cd ${WRKSRC} && convert eos-movrec2.ico eos-movrec2.png)

+post-install:
+	${INSTALL_DATA} ${WRKSRC}/${PORTNAME}2-6.png ${PREFIX}/share/pixmaps/${PORTNAME}.png

Generated and tested manually, tested with port test and with RedPorts (all RELEASES, CLANG), sent with FreeBSD Port Tools 0.99_6 (mode: change, diff: ports)

How-To-Repeat: 
portlint -A
WARN: Makefile: possible use of absolute pathname "/_/}".
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
WARN: Makefile: new ports should not set PORTREVISION.
WARN: Makefile: using hyphen in PORTNAME. consider using PKGNAMEPREFIX and/or PKGNAMESUFFIX.
WARN: Makefile: LIB_DEPENDS don't specify the ABI version number .2 in gphoto2.2 unless it is really necessary.
0 fatal errors and 5 warnings found.

WARN: Makefile: possible use of absolute pathname "/_/}". because is used

${PORTNAME:S/-/_/}"

WARN: Makefile: using hyphen in PORTNAME. because is used as before

 PORTNAME=	eos-movrec

port test: clean


Build log RedPorts

https://redports.org/buildarchive/20121003211136-18414/
Comment 1 Alex Kozlov freebsd_committer freebsd_triage 2012-10-06 12:57:01 UTC
Responsible Changed
From-To: freebsd-ports-bugs->ak

I'll take it.
Comment 2 dfilter service freebsd_committer freebsd_triage 2012-10-06 22:05:22 UTC
Author: ak
Date: Sat Oct  6 21:05:12 2012
New Revision: 305403
URL: http://svn.freebsd.org/changeset/ports/305403

Log:
  - Convert Makefile headers to new style
  - Add DESKTOP_ENTRIES
  - Pass maintainership to nemysis <nemysis@gmx.ch>
  
  PR:	ports/172342
  Submitted by:	nemysis <nemysis@gmx.ch>

Modified:
  head/graphics/eos-movrec/Makefile   (contents, props changed)
  head/graphics/eos-movrec/distinfo   (contents, props changed)

Modified: head/graphics/eos-movrec/Makefile
==============================================================================
--- head/graphics/eos-movrec/Makefile	Sat Oct  6 20:50:12 2012	(r305402)
+++ head/graphics/eos-movrec/Makefile	Sat Oct  6 21:05:12 2012	(r305403)
@@ -1,34 +1,42 @@
-# New ports collection makefile for:	EOS camera movie record
-# Date created:				15 Aug 2011
-# Whom:					Alexey Dokuchaev <danfe@FreeBSD.org>
-#
 # $FreeBSD$
-#
+# Created by:	Alexey Dokuchaev <danfe@FreeBSD.org>
 
 PORTNAME=	eos-movrec
 DISTVERSION=	0.3.1_beta
 PORTREVISION=	1
 CATEGORIES=	graphics
-MASTER_SITES=	SF/${PORTNAME}/${PORTNAME}/0.3_beta
+MASTER_SITES=	SF/${PORTNAME}/${PORTNAME}/0.3_beta/
 
-MAINTAINER=	ports@FreeBSD.org
-COMMENT=	A program to capture short movies with Canon DSLR camera
+MAINTAINER=	nemysis@gmx.ch
+COMMENT=	Program to capture short movies with Canon DSLR camera
 
 LICENSE=	GPLv2
 
-LIB_DEPENDS=	gphoto2.2:${PORTSDIR}/graphics/libgphoto2
+LIB_DEPENDS=	gphoto2:${PORTSDIR}/graphics/libgphoto2
+BUILD_DEPENDS=	pnmtopng:${PORTSDIR}/graphics/netpbm
 
-USE_ZIP=	yes
+USE_BZIP2=	yes
 USE_CMAKE=	yes
+CMAKE_VERBOSE=	yes
 USE_QT4=	qmake_build moc_build rcc_build uic_build gui
 
 WRKSRC=		${WRKDIR}/${PORTNAME}-${DISTVERSION}
 DISTVERSIONSUFFIX=	-src
-PORTREVISION=	1
 
-PLIST_FILES=	bin/eos_movrec
+PLIST_FILES=	bin/eos_movrec \
+		share/pixmaps/${PORTNAME}.png
+
+DESKTOP_ENTRIES=	"EOS Camera Movie Record" "${COMMENT}" "${PORTNAME}" \
+			"${PORTNAME:S/-/_/}" "Application;Graphics;" ${FALSE}
 
 post-patch:
 	@${REINPLACE_CMD} -e 's,GLIBC,${OPSYS},' ${WRKSRC}/os_api.h
 
+post-build:
+	@(cd ${WRKSRC} && ${LOCALBASE}/bin/winicontoppm -bestqual eos-movrec2.ico | \
+		${LOCALBASE}/bin/pnmtopng > eos-movrec.png)
+
+post-install:
+	${INSTALL_DATA} ${WRKSRC}/${PORTNAME}.png ${PREFIX}/share/pixmaps/
+
 .include <bsd.port.mk>

Modified: head/graphics/eos-movrec/distinfo
==============================================================================
--- head/graphics/eos-movrec/distinfo	Sat Oct  6 20:50:12 2012	(r305402)
+++ head/graphics/eos-movrec/distinfo	Sat Oct  6 21:05:12 2012	(r305403)
@@ -1,2 +1,2 @@
-SHA256 (eos-movrec-0.3.1_beta-src.zip) = 25897e7d173d6baa0cfa94a8e0ff5f3decf809d2644ddf2a492677c068efc0c3
-SIZE (eos-movrec-0.3.1_beta-src.zip) = 5183470
+SHA256 (eos-movrec-0.3.1_beta-src.tar.bz2) = 044cf8b6428d66d6d03c3df53103f985e5b669cad3c8f78a94f9ef308259deea
+SIZE (eos-movrec-0.3.1_beta-src.tar.bz2) = 3955037
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Alex Kozlov freebsd_committer freebsd_triage 2012-10-06 22:07:08 UTC
State Changed
From-To: open->closed

Committed. Thanks!