Bug 172422 - [PATCH] devel/binutils: Converting port to new options framework
Summary: [PATCH] devel/binutils: Converting port to new options framework
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Eitan Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-07 05:20 UTC by Michael Gmelin
Modified: 2012-10-07 05:51 UTC (History)
0 users

See Also:

Attachments
binutils-2.22_1.patch (1.19 KB, patch)
2012-10-07 05:20 UTC, Michael Gmelin 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Gmelin 2012-10-07 05:20:15 UTC 
The patch below converts the port to use the new options framework[1]
and converts the Makefile header to the new format[2].

The patch is to be applied using:

patch -p0 -E </path/to/patchfile

Please note that using OptionsNg there is no way of defining NLS to be
Off by default. If this is a problem a different approach should be
taken.

See also:
1. http://lists.freebsd.org/pipermail/freebsd-ports/2012-October/078676.html
2. http://lists.freebsd.org/pipermail/freebsd-ports/2012-August/077801.html



Generated with FreeBSD Port Tools 0.99_6 (mode: change, diff: suffix)
Comment 1 Eitan Adler freebsd_committer freebsd_triage 2012-10-07 05:24:37 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->eadler

I'll take it.
Comment 2 dfilter service freebsd_committer freebsd_triage 2012-10-07 05:31:29 UTC 
Author: eadler
Date: Sun Oct  7 04:31:13 2012
New Revision: 305426
URL: http://svn.freebsd.org/changeset/ports/305426

Log:
  Convert to OptionsNG
  
  PR:		ports/172422
  Submitted by:	Michael Gmelin <freebsd@grem.de>

Modified:
  head/devel/binutils/Makefile

Modified: head/devel/binutils/Makefile
==============================================================================
--- head/devel/binutils/Makefile	Sun Oct  7 03:55:19 2012	(r305425)
+++ head/devel/binutils/Makefile	Sun Oct  7 04:31:13 2012	(r305426)
@@ -1,9 +1,5 @@
-# New ports collection makefile for:	binutils
-# Date created:		9 July 2009
-# Whom:			Martin Matuska <mm@FreeBSD.org>
-#
+# Created by: Martin Matuska <mm@FreeBSD.org>
 # $FreeBSD$
-#
 
 PORTNAME=	binutils
 PORTVERSION=	2.22
@@ -23,7 +19,7 @@ BUILD_DEPENDS=	${LOCALBASE}/lib/libgmp.s
 
 CONFLICTS=	libbfd-[0-9]*
 
-OPTIONS=	NLS "Enable National Language Support" off
+OPTIONS_DEFINE=	NLS
 
 LICENSE_FILE_GPLv3=	${WRKSRC}/COPYING3
 LICENSE_FILE_LGPL3=	${WRKSRC}/COPYING3.LIB
@@ -69,7 +65,7 @@ INFO=		as \
 		configure \
 		ld
 
-.include <bsd.port.pre.mk>
+.include <bsd.port.options.mk>
 
 # Actual earliest version may differ slightly
 .if ${OSVERSION} >= 900044
@@ -79,7 +75,7 @@ PLIST_SUB+=	GOLD=""
 PLIST_SUB+=	GOLD="@comment "
 .endif
 
-.if defined(WITH_NLS)
+.if ${PORT_OPTIONS:MNLS}
 USE_GETTEXT=	yes
 PLIST_SUB+=	NLS=""
 .else
@@ -100,4 +96,4 @@ post-install:
 	@${FIND} -ds ${PREFIX}/${CONFIGURE_TARGET} -type d | \
 		${SED} -e 's,^${PREFIX}/,@dirrm ,' >> ${TMPPLIST}
 
-.include <bsd.port.post.mk>
+.include <bsd.port.mk>
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Eitan Adler freebsd_committer freebsd_triage 2012-10-07 05:51:21 UTC 
State Changed
From-To: open->closed

Committed, with minor changes. Thanks!