Bug 172470 - [MAINTAINER] emulators/bsnes: update to 0.91
Summary: [MAINTAINER] emulators/bsnes: update to 0.91
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Jason E. Hale
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-08 04:10 UTC by Naram Qashat
Modified: 2012-10-26 21:08 UTC (History)
0 users

See Also:


Attachments
bsnes-0.91.patch (6.94 KB, patch)
2012-10-08 04:10 UTC, Naram Qashat
no flags Details | Diff
bsnes.diff (7.07 KB, patch)
2012-10-26 11:06 UTC, Jason E. Hale
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Naram Qashat 2012-10-08 04:10:10 UTC
- Update to 0.91
- Also updated to OptionsNG
- Added options for profile, making the default compatibility instead of performance

Added file(s):
- files/patch-target-ethos-Makefile

Removed file(s):
- files/patch-target-ui-Makefile

Generated with FreeBSD Port Tools 0.99_6 (mode: update, diff: ports)
Comment 1 Jason E. Hale freebsd_committer freebsd_triage 2012-10-25 07:49:27 UTC
Responsible Changed
From-To: freebsd-ports-bugs->jhale

I'll take it.
Comment 2 Jason E. Hale freebsd_committer freebsd_triage 2012-10-26 11:06:33 UTC
There are a few issues that I have fixed...could you look at the attached 
patch?

- Build with the GUI_QT4 option on was failing.  The .moc files needed to be 
regenerated because they are too old.
- Moved the gtk20 dependency so it is only enabled if GTK is enabled
- Cleaned up whitespace in options block so it is easier to read

And this is more of a suggestion, but I think the options should be named so 
that they are compatible with global options.  E.g. if a user has QT4 enabled 
and GTK2 disabled in their global options in /etc/make.conf, the options in 
this port will be set correctly.  Also, I think it is reduntant to have 
"SOUND," "VIDEO," and "GUI" in the options dialog three times on the same 
line.

What do you think?
-- 
Jason E. Hale - jhale@
FreeBSD Ports Committer
KDE/FreeBSD Team
Comment 3 Naram Qashat 2012-10-26 18:13:36 UTC
On 10/26/12 06:06, Jason E. Hale wrote:
> There are a few issues that I have fixed...could you look at the attached
> patch?
>
> - Build with the GUI_QT4 option on was failing.  The .moc files needed to be
> regenerated because they are too old.
> - Moved the gtk20 dependency so it is only enabled if GTK is enabled
> - Cleaned up whitespace in options block so it is easier to read
>
> And this is more of a suggestion, but I think the options should be named so
> that they are compatible with global options.  E.g. if a user has QT4 enabled
> and GTK2 disabled in their global options in /etc/make.conf, the options in
> this port will be set correctly.  Also, I think it is reduntant to have
> "SOUND," "VIDEO," and "GUI" in the options dialog three times on the same
> line.
>
> What do you think?
>

These changes look fine to me.

Thanks,
Naram Qashat
Comment 4 Jason E. Hale freebsd_committer freebsd_triage 2012-10-26 21:08:54 UTC
State Changed
From-To: open->closed

Committed with suggested changes.  Thanks!