Bug 172660 - [patch] science/libkml: Build error when swig is installed
Summary: [patch] science/libkml: Build error when swig is installed
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-13 13:50 UTC by Rainer Hurling
Modified: 2014-05-25 19:50 UTC (History)
0 users

See Also:


Attachments
file.diff (1.81 KB, patch)
2012-10-13 13:50 UTC, Rainer Hurling
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rainer Hurling freebsd_committer freebsd_triage 2012-10-13 13:50:00 UTC
At least on 10.0-CURRENT I get a build error if swig-1.3.40 is installed already: 

./configure: ${SWIG_VERSION:4}: Bad substitution
===>  Script "configure" failed unexpectedly.

Obviously the configure script is not able to recognize the swig version correctly.

While here do the following additions
- Introduce option 'SWIG bindings'
- Trim header to one line (if Wen@ agrees)
- Increment PORTREVISION

Fix: I am not sure if the patch for configure corrects the problem in the right way:

-		if test ${SWIG_VERSION:4} -lt 35; then
+		if test ${SWIG_VERSION} -lt 35; then



Patch attached with submission follows:
How-To-Repeat: Install devel/swig13 and afterwards try to build science/libkml.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-10-13 13:50:35 UTC
Responsible Changed
From-To: freebsd-ports-bugs->wen

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Thierry Thomas freebsd_committer freebsd_triage 2014-01-28 21:28:14 UTC
Responsible Changed
From-To: wen->sunpoet


Transfer to the current maintainer.
Comment 3 dfilter service freebsd_committer freebsd_triage 2014-05-25 19:47:58 UTC
Author: sunpoet
Date: Sun May 25 18:47:55 2014
New Revision: 355264
URL: http://svnweb.freebsd.org/changeset/ports/355264
QAT: https://qat.redports.org/buildarchive/r355264/

Log:
  - Add SWIG option
  
  PR:		ports/172660
  Submitted by:	Rainer Hurling <rhurlin@gwdg.de>

Modified:
  head/science/libkml/Makefile

Modified: head/science/libkml/Makefile
==============================================================================
--- head/science/libkml/Makefile	Sun May 25 18:45:00 2014	(r355263)
+++ head/science/libkml/Makefile	Sun May 25 18:47:55 2014	(r355264)
@@ -15,13 +15,18 @@ LICENSE=	BSD3CLAUSE
 BUILD_DEPENDS=	${LOCALBASE}/bin/curl-config:${PORTSDIR}/ftp/curl \
 		${LOCALBASE}/include/expat.h:${PORTSDIR}/textproc/expat2
 
-CONFIGURE_ARGS=	--disable-java --disable-python --disable-swig \
+OPTIONS_DEFINE=	SWIG
+
+CONFIGURE_ARGS=	--disable-java --disable-python \
 		--with-expat-include-dir=${LOCALBASE}/include \
 		--with-expat-lib-dir=${LOCALBASE}/lib
 GNU_CONFIGURE=	yes
 USE_LDCONFIG=	yes
 USES=		gmake libtool
 
+SWIG_BUILD_DEPENDS=	${LOCALBASE}/bin/swig:${PORTSDIR}/devel/swig13
+SWIG_CONFIGURE_OFF=	--disable-swig
+
 post-patch:
 	@${REINPLACE_CMD} -e '/SWIG_VERSION:4/ s|:4|#*.*.|' ${WRKSRC}/configure
 	@${FIND} ${WRKSRC} -name Makefile.in -exec ${REINPLACE_CMD} 's|-Werror||; s| -ansi -pedantic||' '{}' \;
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 4 Po-Chuan Hsieh freebsd_committer freebsd_triage 2014-05-25 19:48:19 UTC
State Changed
From-To: open->closed

Committed. Thanks!