Bug 172689 - Problem building emulators/hercules + patch
Summary: Problem building emulators/hercules + patch
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-14 13:10 UTC by jau
Modified: 2012-12-29 13:10 UTC (History)
0 users

See Also:


Attachments
file.diff (1.22 KB, patch)
2012-10-14 13:10 UTC, jau
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description jau 2012-10-14 13:10:01 UTC
There was a problem with hercules. The build failed due to
faulty setsockopt() parameters to set TCP keepalive values.
Find a patch attached.

Bjoern Zeeb has already seen the patch and advised me to
mention "Approved by maintainer."

Fix: Add the attached patch files as hercules/files/patch-hscutl.c and ...
make clean
make


Patch attached with submission follows:
How-To-Repeat: Try building hercules without the patch.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-10-14 17:33:18 UTC
Maintainer of emulators/hercules,

Please note that PR ports/172689 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/172689

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2012-10-14 17:33:19 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Bjoern A. Zeeb 2012-10-14 17:35:21 UTC
Yes please apply;  there will most likely be an ports update coming
from the same submitter and I'll be fine with that as well.

So maybe batch them;-)
Comment 4 Pawel Pekala freebsd_committer freebsd_triage 2012-12-29 13:00:17 UTC
State Changed
From-To: feedback->closed

Committed, with minor changes. Thanks!
Comment 5 dfilter service freebsd_committer freebsd_triage 2012-12-29 13:00:20 UTC
Author: pawel
Date: Sat Dec 29 13:00:07 2012
New Revision: 309617
URL: http://svnweb.freebsd.org/changeset/ports/309617

Log:
  Fix build on 9.x and upwards
  
  PR:		ports/172689 (based on)
  Submitted by:	Jukka Ukkonen <jau@iki.fi>
  Approved by:	bzeeb+freebsdports@zabbadoz.net (maintainer)

Modified:
  head/emulators/hercules/Makefile

Modified: head/emulators/hercules/Makefile
==============================================================================
--- head/emulators/hercules/Makefile	Sat Dec 29 12:18:56 2012	(r309616)
+++ head/emulators/hercules/Makefile	Sat Dec 29 13:00:07 2012	(r309617)
@@ -1,9 +1,5 @@
-# New ports collection makefile for:	dice
-# Date created:		Thu Jan 31 12:07:01 CET 2002
-# Whom:			Miguel Mendez <flynn@energyhq.homeip.net>
-#
+# Created by: Miguel Mendez <flynn@energyhq.homeip.net>
 # $FreeBSD$
-#
 
 PORTNAME=	hercules
 PORTVERSION=	3.05
@@ -27,6 +23,7 @@ post-extract:
 
 post-patch:
 	@${REINPLACE_CMD} -e 's@-lpthread@${PTHREAD_LIBS}@g' ${WRKSRC}/configure
+	@${REINPLACE_CMD} -e 's@SOL_TCP@IPPROTO_TCP@g' ${WRKSRC}/hscutl.c
 .if defined(NOPORTDOCS)
 	@${REINPLACE_CMD} -e 's,^SUBDIRS = decNumber m4 po util html man . crypto,SUBDIRS = decNumber m4 po util man . crypto,g' ${WRKSRC}/Makefile.in
 .else
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"