Bug 173176 - [PATCH] games/lmarbles: Makefile changed, OptionsNG, take maintainership
Summary: [PATCH] games/lmarbles: Makefile changed, OptionsNG, take maintainership
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Rene Ladan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-28 22:50 UTC by nemysis
Modified: 2013-03-08 08:30 UTC (History)
1 user (show)

See Also:


Attachments
lmarbles-1.0.8_3.patch (4.33 KB, patch)
2012-10-28 22:50 UTC, nemysis
no flags Details | Diff
lmarbles.diff (4.81 KB, patch)
2013-02-22 03:09 UTC, nemysis
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description nemysis 2012-10-28 22:50:00 UTC
- Take maintainership

Added file(s):
- files/pkg-install.in

Makefile changed:

+LICENSE=	GPLv2
+BUILD_DEPENDS=	giftopnm:${PORTSDIR}/graphics/netpbm
+CONFIGURE_ARGS=	--localstatedir=/var/games
+PORTDOCS=	*
+DOCSRCDIR1=	${WRKSRC}
+DOCSRCDIR2=	${WRKSRC}/src/manual
+SUB_FILES=	pkg-install
+.include <bsd.port.options.mk>
 post-patch:
+post-build:
 post-install:
+.if ${PORT_OPTIONS:MDOCS}
pkg-plist

Generated with FreeBSD Port Tools 0.99_6 (mode: change, diff: ports)

How-To-Repeat: 
portlint -A
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
WARN: Makefile: new ports should not set PORTREVISION.
WARN: pkg-install: possible use of absolute pathname "/var/games/lmarbles....".
0 fatal errors and 3 warnings found.

WARN: pkg-install: because is used
FILE="/var/games/lmarbles.prfs"


port test: clean


Build log

https://redports.org/buildarchive/20121028220134-4946/
Comment 1 nemysis 2013-02-22 03:09:34 UTC
Removed:
+BUILD_DEPENDS= giftopnm:${PORTSDIR}/graphics/netpbm

Makefile changed:
+<-----><------>SF/nemysisfreebsdp/:icons
+DISTFILES=<--->${PORTNAME}-${DISTVERSION}${EXTRACT_SUFX} \
+<-----><------>${PORTNAME}_icons${EXTRACT_SUFX}:icons
+CONFIGURE_ARGS=<------>--localstatedir=/var/games
+PORTDOCS=
+.include <bsd.port.options.mk>

Changed and refined:
 post-patch:
 post-install:
 pkg-descr
 pkg-plist
Comment 2 Rene Ladan freebsd_committer freebsd_triage 2013-02-22 16:16:35 UTC
Responsible Changed
From-To: freebsd-ports-bugs->rene

Take
Comment 3 dfilter service freebsd_committer freebsd_triage 2013-03-08 08:27:45 UTC
Author: rene
Date: Fri Mar  8 08:27:31 2013
New Revision: 313624
URL: http://svnweb.freebsd.org/changeset/ports/313624

Log:
  - Convert to optionsNG
  - Add desktop entry
  - Update COMMENT
  - Add description to pkg-descr independent of Atomix
  - Add license (GPLv2)
  - Cleanups, overhaul installation of documentation
  - Bump PORTREVISION
  - Transfer maintainership to submitter
  
  PR:		ports/173176
  Submitted by:	nemysis <nemysis@gmx.ch>

Modified:
  head/games/lmarbles/Makefile   (contents, props changed)
  head/games/lmarbles/distinfo   (contents, props changed)
  head/games/lmarbles/pkg-descr   (contents, props changed)
  head/games/lmarbles/pkg-plist   (contents, props changed)

Modified: head/games/lmarbles/Makefile
==============================================================================
--- head/games/lmarbles/Makefile	Fri Mar  8 08:18:16 2013	(r313623)
+++ head/games/lmarbles/Makefile	Fri Mar  8 08:27:31 2013	(r313624)
@@ -1,38 +1,58 @@
-# New ports collection makefile for:	marbles
-# Date created:		12 June 2002
-# Whom:			verm@drunkmonk.net
-#
+# Created by: verm@drunkmonk.net
 # $FreeBSD$
-#
 
 PORTNAME=	lmarbles
 PORTVERSION=	1.0.8
-PORTREVISION=	2
+PORTREVISION=	3
 CATEGORIES=	games
-MASTER_SITES=	SF/lgames/${PORTNAME}
+MASTER_SITES=	SF/lgames/${PORTNAME} \
+		SF/nemysisfreebsdp/:icons
+DISTFILES=	${PORTNAME}-${DISTVERSION}${EXTRACT_SUFX} \
+		${PORTNAME}_icons${EXTRACT_SUFX}:icons
 
-MAINTAINER=	ports@FreeBSD.org
-COMMENT=	A challenging puzzle game similar to Atomix
+MAINTAINER=	nemysis@gmx.ch
+COMMENT=	Atomix-like game of moving marbles in puzzles
+
+LICENSE=	GPLv2
 
 USE_SDL=	sdl mixer
 USE_GMAKE=	yes
 GNU_CONFIGURE=	yes
-CONFIGURE_ARGS=	--localstatedir=${DATADIR}
+CONFIGURE_ARGS=	--localstatedir=${ETCDIR}
 
 MAN6=		${PORTNAME}.6
 
+PORTDOCS=	*
+
+DOCSRCDIR1=	${WRKSRC}
+DOC_FILES1=	AUTHORS ChangeLog README README-SDL.txt
+
+DOCSRCDIR2=	${WRKSRC}/src/manual
+DOCSDIR2=	${DOCSDIR}/manual
+DOC_FILES2=	*.jpg *.html
+
+.include <bsd.port.options.mk>
+
 post-patch:
 	@${REINPLACE_CMD} -e 's|(datadir)/icons|(datadir)/pixmaps|g' \
+	-e 's|(datadir)/pixmaps/lmarbles32.gif|(datadir)/pixmaps/lmarbles32.png|g' \
+	-e 's|(datadir)/pixmaps/lmarbles48.gif|(datadir)/pixmaps/lmarbles48.png|g' \
 		${WRKSRC}/Makefile.in
+	@${REINPLACE_CMD} -e 's|-m 666||g' \
+	-e 's|lmarbles.prfs|lmarbles.prfs.sample|g' \
+		${WRKSRC}/src/Makefile.in
 
 post-install:
-	@${CHMOD} 2755 ${PREFIX}/bin/${PORTNAME}
-	@${CHOWN} root:games ${PREFIX}/bin/${PORTNAME}
-	@${CHMOD} 0664 ${DATADIR}/${PORTNAME}.prfs
-	@${CHOWN} root:games ${DATADIR}/${PORTNAME}.prfs
-.if !defined(NOPORTDOCS)
-	@${MKDIR} ${DOCSDIR}
-	${INSTALL_DATA} ${WRKSRC}/src/manual/* ${DOCSDIR}
+	${INSTALL_DATA} ${WRKDIR}/${PORTNAME}*.png ${PREFIX}/share/pixmaps/
+	@if [ ! -f ${ETCDIR}/lmarbles.prfs ] ; then \
+		${INSTALL_DATA} ${ETCDIR}/lmarbles.prfs.sample ${ETCDIR}/lmarbles.prfs ; \
+	fi
+
+.if ${PORT_OPTIONS:MDOCS}
+	${MKDIR} ${DOCSDIR}
+	${INSTALL_DATA} ${DOC_FILES1:S|^|${DOCSRCDIR1}/|} ${DOCSDIR}
+	${MKDIR} ${DOCSDIR2}
+	${INSTALL_DATA} ${DOC_FILES2:S|^|${DOCSRCDIR2}/|} ${DOCSDIR2}
 .endif
 
 .include <bsd.port.mk>

Modified: head/games/lmarbles/distinfo
==============================================================================
--- head/games/lmarbles/distinfo	Fri Mar  8 08:18:16 2013	(r313623)
+++ head/games/lmarbles/distinfo	Fri Mar  8 08:27:31 2013	(r313624)
@@ -1,2 +1,4 @@
 SHA256 (lmarbles-1.0.8.tar.gz) = 0e5a16a0116d325589b28f3555ced6a0b486f0fd7632cd3d98bee5cddf213e83
 SIZE (lmarbles-1.0.8.tar.gz) = 914238
+SHA256 (lmarbles_icons.tar.gz) = 7e33408a4b6a2e39c979654607757d53432f2d1eaa6814f4f2892939faa8a8cb
+SIZE (lmarbles_icons.tar.gz) = 4096

Modified: head/games/lmarbles/pkg-descr
==============================================================================
--- head/games/lmarbles/pkg-descr	Fri Mar  8 08:18:16 2013	(r313623)
+++ head/games/lmarbles/pkg-descr	Fri Mar  8 08:27:31 2013	(r313624)
@@ -2,4 +2,9 @@ LMarbles is a game similar to Atomix and
 The goal is to arrange a figure out of single marbles within a time
 limit to reach the next level.
 
+Your goal in the puzzle game marbles is to create a more or less complex
+figure out of single marbles within a time limit to reach the next
+level. Sounds easy? Well, there is a problem: If a marble starts to
+move, it will not stop until it hits a wall or another marble.
+
 WWW: http://lgames.sourceforge.net/index.php?project=LMarbles

Modified: head/games/lmarbles/pkg-plist
==============================================================================
--- head/games/lmarbles/pkg-plist	Fri Mar  8 08:18:16 2013	(r313623)
+++ head/games/lmarbles/pkg-plist	Fri Mar  8 08:27:31 2013	(r313624)
@@ -1,11 +1,5 @@
 bin/lmarbles
 share/applications/lmarbles.desktop
-%%PORTDOCS%%%%DOCSDIR%%/arrow.jpg
-%%PORTDOCS%%%%DOCSDIR%%/arrow2.jpg
-%%PORTDOCS%%%%DOCSDIR%%/crumble.jpg
-%%PORTDOCS%%%%DOCSDIR%%/manual.html
-%%PORTDOCS%%%%DOCSDIR%%/marbles.jpg
-%%PORTDOCS%%%%DOCSDIR%%/teleport.jpg
 %%DATADIR%%/gfx/board.bmp
 %%DATADIR%%/gfx/f_red.bmp
 %%DATADIR%%/gfx/f_small.bmp
@@ -63,7 +57,6 @@ share/applications/lmarbles.desktop
 %%DATADIR%%/gfx/wood/wall.bmp
 %%DATADIR%%/gfx/wood/wall_crumble.bmp
 %%DATADIR%%/levels/Original
-%%DATADIR%%/lmarbles.prfs
 %%DATADIR%%/sounds/alarm.wav
 %%DATADIR%%/sounds/arrow.wav
 %%DATADIR%%/sounds/click.wav
@@ -72,7 +65,9 @@ share/applications/lmarbles.desktop
 %%DATADIR%%/sounds/select.wav
 %%DATADIR%%/sounds/stop.wav
 %%DATADIR%%/sounds/teleport.wav
+share/pixmaps/lmarbles32.png
 share/pixmaps/lmarbles48.gif
+share/pixmaps/lmarbles48.png
 @dirrm %%DATADIR%%/sounds
 @dirrm %%DATADIR%%/levels
 @dirrm %%DATADIR%%/gfx/wood
@@ -80,5 +75,8 @@ share/pixmaps/lmarbles48.gif
 @dirrm %%DATADIR%%/gfx/metal
 @dirrm %%DATADIR%%/gfx
 @dirrm %%DATADIR%%
-%%PORTDOCS%%@dirrm %%DOCSDIR%%
+@unexec if cmp -s %D/%%ETCDIR%%/lmarbles.prfs.sample %D/%%ETCDIR%%/lmarbles.prfs ; then rm -f %D/%%ETCDIR%%/lmarbles.prfs ; fi
+%%ETCDIR%%/lmarbles.prfs.sample
+@exec if [ ! -f %D/%%ETCDIR%%/lmarbles.prfs ] ; then cp -p %D/%F %B/lmarbles.prfs ; fi
+@dirrmtry %%ETCDIR%%
 @dirrmtry share/applications
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 4 Rene Ladan freebsd_committer freebsd_triage 2013-03-08 08:30:11 UTC
State Changed
From-To: open->closed

Committed, thanks