Bug 173183 - [PATCH] devel/flyspray fix patch
Summary: [PATCH] devel/flyspray fix patch
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-29 09:00 UTC by Chris Petrik
Modified: 2012-11-05 22:19 UTC (History)
0 users

See Also:


Attachments
flyspray.diff.uu (3.26 KB, text/x-uuencode)
2012-10-30 12:13 UTC, Nick Hilliard
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Petrik 2012-10-29 09:00:00 UTC
remove patch convert to reimplace
convert to optionsng
update header
add in dos2unix

Fix: 

http://cpet.multics.org/patches/ports/patch-flyspray.txt
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-10-29 09:00:08 UTC
Maintainer of devel/flyspray,

Please note that PR ports/173183 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/173183

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2012-10-29 09:00:09 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Nick Hilliard 2012-10-30 12:13:12 UTC
looks fine in principle.  I've cleaned it up a little so that it now
patches cleanly.

Nick
Comment 4 Chris Petrik 2012-11-02 14:18:44 UTC
Patch is a svn diff which should apply cleanly.
Comment 5 Raphael Kubo da Costa freebsd_committer freebsd_triage 2012-11-04 18:59:44 UTC
Hi everyone,

It was not clear from Chris's last email to this PR whether he had some
new patch version to send or whether he was just commenting on Nick's
version.

Should Nick's patch be committed?
Comment 6 Chris Petrik 2012-11-04 19:20:22 UTC
The only difference between mine and nicks patch is the addition of
PORTREVISION which I don't think is valid in this case. If it is then
nick's patch would suffice and fix the patch issues the ports currently has.
Comment 7 Nick Hilliard 2012-11-05 16:41:56 UTC
On 04/11/2012 18:59, Raphael Kubo da Costa wrote:
> It was not clear from Chris's last email to this PR whether he had some
> new patch version to send or whether he was just commenting on Nick's
> version.
> 
> Should Nick's patch be committed?

Chris's patch doesn't apply cleanly.  I fixed it up and bumped
portrevision, so my patch should probably be used instead.  Also, you can
take out the eol hacks in svn.

Nick
Comment 8 Raphael Kubo da Costa freebsd_committer freebsd_triage 2012-11-05 22:19:40 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!