Bug 173436 - [MAINTAINER] games/mopesnake: Makefile changed, added pkg-plist, Desktop entries, removed all notes
Summary: [MAINTAINER] games/mopesnake: Makefile changed, added pkg-plist, Desktop entr...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Beech Rintoul
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-07 01:10 UTC by nemysis
Modified: 2013-03-14 23:40 UTC (History)
1 user (show)

See Also:


Attachments
mopesnake-0.5_2.patch (3.12 KB, patch)
2012-11-07 01:10 UTC, nemysis
no flags Details | Diff
mopesnake.diff (3.24 KB, patch)
2013-02-23 14:00 UTC, nemysis
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description nemysis 2012-11-07 01:10:01 UTC
Added file(s):
- pkg-plist

Makefile changed
+CATEGORIES=	games python
-PLIST_FILES=	bin/${PORTNAME} \
-		share/pixmaps/${PORTNAME}.png
-PORTDATA=	*
+DESKTOP_ENTRIES=

Changed and refined:
 post-patch:
 do-install:
files/mopesnake.in

Removed all notes

Generated and tested manually, tested with port test, sent with FreeBSD Port Tools 0.99_6 (mode: change, diff: ports)

How-To-Repeat: 
portlint -A
looks fine.

port test: clean
Comment 1 nemysis 2013-02-23 14:00:37 UTC
Please add in Makefile Header
# Created by: nemysis@gmx.ch

+DESKTOP_ENTRIES="Master Of Pain (Eating) - Snake" "${COMMENT}" \
+               "${PREFIX}/share/pixmaps/${PORTNAME}.png" \
+               "${PORTNAME}" "Game;ArcadeGame;" false
Comment 2 Beech Rintoul freebsd_committer freebsd_triage 2013-03-12 23:35:02 UTC
Responsible Changed
From-To: freebsd-ports-bugs->beech

Mine
Comment 3 dfilter service freebsd_committer freebsd_triage 2013-03-14 23:31:22 UTC
Author: beech
Date: Thu Mar 14 23:31:14 2013
New Revision: 314193
URL: http://svnweb.freebsd.org/changeset/ports/314193

Log:
  - Add Desktop entries
  - Add icons
  - Add pkg-plist
  - Bump portrevision
  
  PR:		ports/173436
  Submitted by:	nemysis <nemysis@gmx.ch> (maintainer)

Added:
  head/games/mopesnake/pkg-plist   (contents, props changed)
Modified:
  head/games/mopesnake/Makefile
  head/games/mopesnake/files/mopesnake.in

Modified: head/games/mopesnake/Makefile
==============================================================================
--- head/games/mopesnake/Makefile	Thu Mar 14 23:17:26 2013	(r314192)
+++ head/games/mopesnake/Makefile	Thu Mar 14 23:31:14 2013	(r314193)
@@ -1,9 +1,10 @@
+# Created by: nemysis <nemysis@gmx.ch>
 # $FreeBSD$
 
 PORTNAME=	mopesnake
 PORTVERSION=	0.5
-PORTREVISION=	1
-CATEGORIES=	games
+PORTREVISION=	2
+CATEGORIES=	games python
 MASTER_SITES=	SF/${PORTNAME}/${PORTNAME}/${PORTVERSION}
 DISTNAME=	${PORTNAME}-pc-${DISTVERSION}
 
@@ -18,43 +19,32 @@ USE_ZIP=	yes
 USE_PYTHON=	yes
 NO_BUILD=	yes
 
-PLIST_FILES=	bin/${PORTNAME} \
-		share/pixmaps/${PORTNAME}.png
-
-PORTDATA=	*
 PORTDOCS=	TODO.txt index.html
 
 SUB_FILES=	${PORTNAME}
 
+DESKTOP_ENTRIES="Master Of Pain (Eating) - Snake" "${COMMENT}" \
+		"${PREFIX}/share/pixmaps/${PORTNAME}" \
+		"${PORTNAME}" "Game;ArcadeGame;" false
+
+.include <bsd.port.options.mk>
+
 post-patch:
-# Fix path to python interpreter
 	@${REINPLACE_CMD} -e 's,/usr/bin/python,${PYTHON_CMD},' \
 		${WRKSRC}/*.py ${WRKSRC}/mopelib/*.py
-	@(cd ${WRKSRC} && ${RM} *.py.bak mopelib/*py.bak)
-
-.include <bsd.port.options.mk>
+	@${FIND} ${WRKSRC} -name "*.bak" -delete
 
 do-install:
-# Scripts
-	${INSTALL_SCRIPT} ${WRKDIR}/${PORTNAME} ${PREFIX}/bin
-
-# Executable
+	${INSTALL_SCRIPT} ${WRKDIR}/${PORTNAME} ${PREFIX}/bin/
 	${MKDIR} ${DATADIR}
 	${INSTALL_SCRIPT} ${WRKSRC}/${PORTNAME}.py ${DATADIR}
-
-# Data
 	@(cd ${WRKSRC} && ${COPYTREE_SHARE} "images mopelib music sounds" ${DATADIR})
-
-# Pixmaps and version
 	${INSTALL_DATA} ${WRKSRC}/doc/screenshot1.png ${PREFIX}/share/pixmaps/${PORTNAME}.png
 	${INSTALL_DATA} ${WRKSRC}/version ${DATADIR}
 
-# Documentation
 .if ${PORT_OPTIONS:MDOCS}
 	${MKDIR} ${DOCSDIR}
-.  for f in ${PORTDOCS}
-	${INSTALL_DATA} ${WRKSRC}/doc/${f} ${DOCSDIR}
-.  endfor
+	${INSTALL_DATA} ${PORTDOCS:S|^|${WRKSRC}/doc/|} ${DOCSDIR}
 .endif
 
 .include <bsd.port.mk>

Modified: head/games/mopesnake/files/mopesnake.in
==============================================================================
--- head/games/mopesnake/files/mopesnake.in	Thu Mar 14 23:17:26 2013	(r314192)
+++ head/games/mopesnake/files/mopesnake.in	Thu Mar 14 23:31:14 2013	(r314193)
@@ -1,7 +1,7 @@
 #!/bin/sh
 #
 # $FreeBSD$
+#
 
-echo "Master Of Pain (Eating) - Snake: Starting up..."
 cd "%%DATADIR%%"
-./mopesnake.py
+exec /usr/bin/env python ./mopesnake.py "${@}"

Added: head/games/mopesnake/pkg-plist
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/games/mopesnake/pkg-plist	Thu Mar 14 23:31:14 2013	(r314193)
@@ -0,0 +1,25 @@
+bin/mopesnake
+%%DATADIR%%/images/hiscores.png
+%%DATADIR%%/images/instructions.png
+%%DATADIR%%/images/title.png
+%%DATADIR%%/images/tryad.png
+%%DATADIR%%/mopelib/__init__.py
+%%DATADIR%%/mopelib/mopelib.py
+%%DATADIR%%/mopesnake.py
+%%DATADIR%%/music/the_final_rewind_loop.ogg
+%%DATADIR%%/sounds/aaa1.wav
+%%DATADIR%%/sounds/aah2.wav
+%%DATADIR%%/sounds/aei1.wav
+%%DATADIR%%/sounds/eee1.wav
+%%DATADIR%%/sounds/mmm3.wav
+%%DATADIR%%/sounds/ooh1.wav
+%%DATADIR%%/sounds/oow1.wav
+%%DATADIR%%/sounds/ouch1.wav
+%%DATADIR%%/sounds/ow1.wav
+%%DATADIR%%/version
+share/pixmaps/mopesnake.png
+@dirrm %%DATADIR%%/sounds
+@dirrm %%DATADIR%%/music
+@dirrm %%DATADIR%%/mopelib
+@dirrm %%DATADIR%%/images
+@dirrm %%DATADIR%%
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 4 Beech Rintoul freebsd_committer freebsd_triage 2013-03-14 23:31:32 UTC
State Changed
From-To: open->closed

Committed, Thanks!