Bug 174258 - [PATCH] games/pysolfc OptionsNG, added license, cardsets
Summary: [PATCH] games/pysolfc OptionsNG, added license, cardsets
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Marcus von Appen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-07 12:10 UTC by nemysis
Modified: 2012-12-15 10:49 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description nemysis 2012-12-07 12:10:00 UTC
Generated and tested manually, tested with port test

Makefile changed:
+CATEGORIES=    games python
+DISTFILES=
+DIST_SUBDIR=   ${PORTNAME}
+LICENSE=       GPLv3
+WRKSRC=                ${WRKDIR}/PySolFC-${PORTVERSION}
+PORTDOCS=      AUTHORS README
+OPTIONS_DEFINE=
+.include <bsd.port.options.mk>
+.if ${PORT_OPTIONS:MNLS}
+.if ${PORT_OPTIONS:MCARDSETS}

Changed and refined:
 post-install:
 pkg-plist

Fix: 

Because large pkg-plist, pysolfc.diff is very big 838k

You can find it on

http://patches.cpetservices.com/users/nemysis/pysolfc.diff
How-To-Repeat: portlint -A
WARN: Makefile: [67]: possible use of "${FIND} ... ${XARGS} ${RM}" when "${FIND} ... -delete" will work.
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
WARN: Makefile: new ports should not set PORTREVISION.
WARN: Makefile: use of DISTFILES with single file discouraged. distribution filename should be set by DISTNAME and EXTRACT_SUFX.
WARN: Makefile: DISTFILES/DISTNAME affects WRKSRC. take caution when changing them.
0 fatal errors and 5 warnings found.

WARN: Makefile: [67]: because is used
        @${FIND} ${WRKDIR} -name .thumbnails -or -name .xvpics | ${XARGS} ${RM} -rf
other combinations not works, but are there in Makefile with #

WARN: Makefile: use of DISTFILES
WARN: Makefile: DISTFILES/DISTNAME
are because is used
DISTFILES=      PySolFC-${DISTVERSION}${EXTRACT_SUFX}
.if ${PORT_OPTIONS:MCARDSETS}
DISTFILES+=             PySolFC-Cardsets-${DISTVERSION}${EXTRACT_SUFX}:cardsets

port test: clean
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-12-07 12:10:07 UTC
Responsible Changed
From-To: freebsd-ports-bugs->mva

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Marcus von Appen freebsd_committer freebsd_triage 2012-12-15 10:49:41 UTC
State Changed
From-To: open->closed

Committed with changes. Thanks!