Bug 174376 - [patch] audio/audacity: fix build with clang
Summary: [patch] audio/audacity: fix build with clang
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Rene Ladan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-11 20:40 UTC by atkin901
Modified: 2013-01-02 12:20 UTC (History)
0 users

See Also:


Attachments
file.diff (457 bytes, patch)
2012-12-11 20:40 UTC, atkin901
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description atkin901 2012-12-11 20:40:00 UTC
Audacity has a link time failure during compilation in libnyquist with clang as the base compiler:


./lib-src/libnyquist.a(fftlib.o): In function `fftrecurs':
nyquist/ffts/src/fftlib.c:(.text+0x139): undefined reference to `bfstages'
nyquist/ffts/src/fftlib.c:(.text+0x303): undefined reference to `bfstages'
./lib-src/libnyquist.a(fftlib.o): In function `ffts1':
nyquist/ffts/src/fftlib.c:(.text+0x382): undefined reference to `bitrevR2'
nyquist/ffts/src/fftlib.c:(.text+0x496): undefined reference to `bfR4'
nyquist/ffts/src/fftlib.c:(.text+0x4c7): undefined reference to `bfstages'
./lib-src/libnyquist.a(fftlib.o): In function `ifftrecurs':
nyquist/ffts/src/fftlib.c:(.text+0x849): undefined reference to `ibfstages'
nyquist/ffts/src/fftlib.c:(.text+0xa13): undefined reference to `ibfstages'
./lib-src/libnyquist.a(fftlib.o): In function `iffts1':
nyquist/ffts/src/fftlib.c:(.text+0xac3): undefined reference to `scbitrevR2'
nyquist/ffts/src/fftlib.c:(.text+0xbdf): undefined reference to `ibfR4'
nyquist/ffts/src/fftlib.c:(.text+0xc13): undefined reference to `ibfstages'
nyquist/ffts/src/fftlib.c:(.text+0xdaa): undefined reference to `ifft8pt'
./lib-src/libnyquist.a(fftlib.o): In function `rffts1':
nyquist/ffts/src/fftlib.c:(.text+0xe57): undefined reference to `scbitrevR2'
nyquist/ffts/src/fftlib.c:(.text+0xf66): undefined reference to `bfR4'
nyquist/ffts/src/fftlib.c:(.text+0xf97): undefined reference to `bfstages'
nyquist/ffts/src/fftlib.c:(.text+0xfd5): undefined reference to `frstage'
nyquist/ffts/src/fftlib.c:(.text+0x11a6): undefined reference to `rfft8pt'
./lib-src/libnyquist.a(fftlib.o): In function `riffts1':
nyquist/ffts/src/fftlib.c:(.text+0x1285): undefined reference to `ifrstage'
nyquist/ffts/src/fftlib.c:(.text+0x12a0): undefined reference to `scbitrevR2'
nyquist/ffts/src/fftlib.c:(.text+0x13c0): undefined reference to `ibfR4'
nyquist/ffts/src/fftlib.c:(.text+0x13f3): undefined reference to `ibfstages'
nyquist/ffts/src/fftlib.c:(.text+0x165a): undefined reference to `rifft8pt'
c++: error: linker command failed with exit code 1 (use -v to see invocation)
gmake[1]: *** [../audacity] Error 1
gmake[1]: Leaving directory `/usr/ports/audio/audacity/work/audacity-src-2.0.2/src'
gmake: *** [audacity] Error 2
*** [do-build] Error code 1

Fix: $ svn diff Makefile
How-To-Repeat: make on recent current/ports tree:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-12-11 20:40:13 UTC
Maintainer of audio/audacity,

Please note that PR ports/174376 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/174376

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2012-12-11 20:40:14 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Rene Ladan freebsd_committer freebsd_triage 2012-12-13 10:30:47 UTC
Responsible Changed
From-To: freebsd-ports-bugs->rene

Take
Comment 4 dfilter service freebsd_committer freebsd_triage 2013-01-02 12:09:17 UTC
Author: rene
Date: Wed Jan  2 12:09:09 2013
New Revision: 309811
URL: http://svnweb.freebsd.org/changeset/ports/309811

Log:
  Fix build with clang.
  
  PR:		ports/174376
  Submitted by:	Mark Atkinson <atkin901@gmail.com>
  Approved by:	maintainer timeout (22 days)

Modified:
  head/audio/audacity/Makefile   (contents, props changed)

Modified: head/audio/audacity/Makefile
==============================================================================
--- head/audio/audacity/Makefile	Wed Jan  2 12:07:39 2013	(r309810)
+++ head/audio/audacity/Makefile	Wed Jan  2 12:09:09 2013	(r309811)
@@ -186,4 +186,6 @@ post-patch:
 	@${REINPLACE_CMD} -e 's|libresample.a -lsamplerate $(LIBS)|libresample.a $(LIBS)|' ${WRKSRC}/lib-src/libresample/Makefile.in
 .endif
 
+	@${REINPLACE_CMD} -e 's|inline void|static inline void|' ${WRKSRC}/lib-src/libnyquist/nyquist/ffts/src/fftlib.c
+
 .include <bsd.port.mk>
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 5 Rene Ladan freebsd_committer freebsd_triage 2013-01-02 12:09:41 UTC
State Changed
From-To: feedback->closed

Committed, thanks