Adds "Conversation failure" error code to authentication errors list in order to permit login with special usernames. Also fixes console command. How-To-Repeat: Try to login with special username like "exit" or "console" if slim was built with PAM support enabled.
Maintainer of x11/slim, Please note that PR ports/174482 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/174482 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
I've tested the patch and it fixed the problem. Please commit it. -- Cheers, Henry
State Changed From-To: feedback->open Maintainer approved.
Responsible Changed From-To: freebsd-ports-bugs->madpilot I'll take it.
Hi, I made a few more improvements to the port I'd also like to commit with this PR: - Bump PORTREVISION, since the fix modifies the resulting package - Convert the port to the new options framework I'd like the maintainer to approve also this further changes. Patch attached. Thanks in advance! -- Guido Falsi <mad@madpilot.net>
State Changed From-To: open->feedback Ask for maintainer approval.
Author: madpilot Date: Sat Mar 23 12:35:14 2013 New Revision: 315025 URL: http://svnweb.freebsd.org/changeset/ports/315025 Log: - Add "Conversation failure" error code to authentication errors list in order to permit login with special usernames. - Fix conssole command - Bump PORTREVISION PR: ports/174482 Submitted by: Maxim Samsonov <xors@mailup.net> Approved by: Henry Hu <henry.hu.sh@gmail.com> (maintainer) Added: head/x11/slim/files/patch-PAM.cpp (contents, props changed) Modified: head/x11/slim/Makefile head/x11/slim/files/patch-slim.conf (contents, props changed) Modified: head/x11/slim/Makefile ============================================================================== --- head/x11/slim/Makefile Sat Mar 23 12:01:32 2013 (r315024) +++ head/x11/slim/Makefile Sat Mar 23 12:35:14 2013 (r315025) @@ -3,7 +3,7 @@ PORTNAME= slim PORTVERSION= 1.3.4 -PORTREVISION= 4 +PORTREVISION= 5 CATEGORIES= x11 MASTER_SITES= http://slim.berlios.de/releases/ Added: head/x11/slim/files/patch-PAM.cpp ============================================================================== --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/x11/slim/files/patch-PAM.cpp Sat Mar 23 12:35:14 2013 (r315025) @@ -0,0 +1,10 @@ +--- PAM.cpp.orig 2012-06-26 12:20:14.000000000 +0400 ++++ PAM.cpp 2012-12-16 16:05:09.000000000 +0400 +@@ -128,6 +128,7 @@ + case PAM_MAXTRIES: + case PAM_CRED_INSUFFICIENT: + case PAM_AUTH_ERR: ++ case PAM_CONV_ERR: + throw Auth_Exception(pam_handle, "pam_authentication()", last_result); + + case PAM_SUCCESS: Modified: head/x11/slim/files/patch-slim.conf ============================================================================== --- head/x11/slim/files/patch-slim.conf Sat Mar 23 12:01:32 2013 (r315024) +++ head/x11/slim/files/patch-slim.conf Sat Mar 23 12:35:14 2013 (r315025) @@ -18,7 +18,7 @@ reboot_cmd /sbin/shutdown -r now -console_cmd /usr/bin/xterm -C -fg white -bg black +sb -T "Console login" -e /bin/sh -c "/bin/cat /etc/issue; exec /bin/login" -#suspend_cmd /usr/sbin/suspend -+console_cmd %%LOCALBASE%%/bin/xterm -C -fg white -bg black +sb -T "Console login" -e /bin/sh -c "/bin/cat /etc/motd; exec /bin/login" ++console_cmd %%LOCALBASE%%/bin/xterm -C -fg white -bg black +sb -T "Console login" -e /bin/sh -c "/bin/cat /etc/motd; exec /usr/bin/login" +suspend_cmd /usr/sbin/acpiconf -s 3 # Full path to the xauth binary _______________________________________________ svn-ports-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-ports-all To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
State Changed From-To: feedback->closed Committed, with minor changes. Thanks!