Bug 174529 - devel/opengrok: drop tomcat55 support (end-of-life very soon), fix plist
Summary: devel/opengrok: drop tomcat55 support (end-of-life very soon), fix plist
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Tom Judge
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-17 23:30 UTC by Jason Helfman
Modified: 2013-01-29 16:30 UTC (History)
0 users

See Also:


Attachments
file.diff (2.32 KB, patch)
2012-12-17 23:30 UTC, Jason Helfman
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jason Helfman freebsd_committer freebsd_triage 2012-12-17 23:30:00 UTC
- update historical header
- drop tomcat55 support, as it is end-of-life at end-of-year (non-default)
- fix plist, and bump portrevision
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-12-17 23:30:08 UTC
Responsible Changed
From-To: freebsd-ports-bugs->tj

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2013-01-29 16:20:22 UTC
Author: tj
Date: Tue Jan 29 16:20:00 2013
New Revision: 311170
URL: http://svnweb.freebsd.org/changeset/ports/311170

Log:
  * Drop tomcat55 support
  * Add tomcat7 support
  * Allow customization of application server installation path
  * Small plist fix
  
  PR:		ports/170597
  PR:		ports/174100
  PR:		ports/174529
  Submitted by:	Yuri Pankov <yuri.pankov@gmail.com>
  Submitted by:	Ashley <ashley.wil@gmail.com>
  Submitted by:	jgh

Modified:
  head/devel/opengrok/Makefile   (contents, props changed)
  head/devel/opengrok/pkg-plist   (contents, props changed)

Modified: head/devel/opengrok/Makefile
==============================================================================
--- head/devel/opengrok/Makefile	Tue Jan 29 15:49:10 2013	(r311169)
+++ head/devel/opengrok/Makefile	Tue Jan 29 16:20:00 2013	(r311170)
@@ -1,12 +1,9 @@
-# New ports collection makefile for:	opengrok
-# Date created:		10/13/2009
-# Whom:			stas
-#
+# Create by: stas
 # $FreeBSD$
-#
 
 PORTNAME=	opengrok
 PORTVERSION=	0.11.1
+PORTREVISION=	1
 CATEGORIES=	devel java
 MASTER_SITES=	http://hub.opensolaris.org/bin/download/Project+opengrok/files/
 
@@ -26,12 +23,12 @@ NO_BUILD=	yes
 SUB_FILES=	opengrok
 SUB_LIST+=	LIBFILES="${LIBFILES:S,^,${DATADIR}/,}" \
 		JARFILE="${JARFILE}"
-PLIST_SUB=	T=${WEBAPP_DIRS:S|^${LOCALBASE}/||} \
+PLIST_SUB=	T=${WEBAPP_HOME:S|^${LOCALBASE}/||} \
 		CONF_EXT=${CONF_EXT}
 CONF_EXT=	sample
 
 OPTIONS_SINGLE=	AS
-OPTIONS_SINGLE_AS=	TOMCAT5 TOMCAT6 RESIN3
+OPTIONS_SINGLE_AS=	TOMCAT7 TOMCAT6 RESIN3
 OPTIONS_DEFAULT=	TOMCAT6
 
 .include <bsd.port.pre.mk>
@@ -45,24 +42,26 @@ LIBFILES=	ant.jar \
 		lucene-spellchecker-3.0.2.jar \
 		swing-layout-0.9.jar
 
-.if ${PORT_OPTIONS:MTOMCAT6}
-WEBAPP_DIRS=	apache-tomcat-6.0
-BUILD_DEPENDS+=	${LOCALBASE}/apache-tomcat-6.0/bin/bootstrap.jar:${PORTSDIR}/www/tomcat6
-RUN_DEPENDS+=	${LOCALBASE}/apache-tomcat-6.0/bin/bootstrap.jar:${PORTSDIR}/www/tomcat6
+.if ${PORT_OPTIONS:MTOMCAT7}
+WEBAPP_HOME?=	${LOCALBASE}/apache-tomcat-7.0
+BUILD_DEPENDS+=	${WEBAPP_HOME}/bin/bootstrap.jar:${PORTSDIR}/www/tomcat7
+RUN_DEPENDS+=	${WEBAPP_HOME}/bin/bootstrap.jar:${PORTSDIR}/www/tomcat7
 .endif
 
-.if ${PORT_OPTIONS:MTOMCAT5}
-WEBAPP_DIRS=	tomcat5.5
-BUILD_DEPENDS+=	${LOCALBASE}/tomcat5.5/bin/bootstrap.jar:${PORTSDIR}/www/tomcat55
-RUN_DEPENDS+=	${LOCALBASE}/tomcat5.5/bin/bootstrap.jar:${PORTSDIR}/www/tomcat55
+.if ${PORT_OPTIONS:MTOMCAT6}
+WEBAPP_HOME?=	${LOCALBASE}/apache-tomcat-6.0
+BUILD_DEPENDS+=	${WEBAPP_HOME}/bin/bootstrap.jar:${PORTSDIR}/www/tomcat6
+RUN_DEPENDS+=	${WEBAPP_HOME}/bin/bootstrap.jar:${PORTSDIR}/www/tomcat6
 .endif
 
 .if ${PORT_OPTIONS:MRESIN3}
-WEBAPP_DIRS=	resin3
-BUILD_DEPENDS+=	${LOCALBASE}/resin3/lib/resin.jar:${PORTSDIR}/www/resin3
-RUN_DEPENDS+=	${LOCALBASE}/resin3/lib/resin.jar:${PORTSDIR}/www/resin3
+WEBAPP_HOME?=	${LOCALBASE}/resin3
+BUILD_DEPENDS+=	${WEBAPP_HOME}/lib/resin.jar:${PORTSDIR}/www/resin3
+RUN_DEPENDS+=	${WEBAPP_HOME}/lib/resin.jar:${PORTSDIR}/www/resin3
 .endif
 
+WEBAPPS_DIR=	${WEBAPP_HOME:S|^${LOCALBASE}/||}/webapps
+
 pre-everything::
 .if ${PREFIX}!=${LOCALBASE}
 	@${ECHO_MSG} "Warning: you changed prefix to ${PREFIX}"
@@ -75,17 +74,17 @@ post-extract:
 	@${TAR} xf ${WRKSRC}/lib/source.war -C ${WRKSRC}/lib/${PORTNAME}
 
 do-install:
-	${INSTALL} -d -o ${WWWOWN} -g ${WWWGRP} ${PREFIX}/${WEBAPP_DIRS}/webapps/${PORTNAME}
+	${INSTALL} -d -o ${WWWOWN} -g ${WWWGRP} ${PREFIX}/${WEBAPPS_DIR}/${PORTNAME}
 	@${MV} ${WRKSRC}/lib/${PORTNAME}/WEB-INF/web.xml ${WRKSRC}/lib/${PORTNAME}/WEB-INF/web.xml.${CONF_EXT}
-	@cd ${WRKSRC}/lib/${PORTNAME} && ${COPYTREE_SHARE} \* ${PREFIX}/${WEBAPP_DIRS}/webapps/${PORTNAME}
+	@cd ${WRKSRC}/lib/${PORTNAME} && ${COPYTREE_SHARE} \* ${PREFIX}/${WEBAPPS_DIR}/${PORTNAME}
 
-	@if [ ! -e "${PREFIX}/${WEBAPP_DIRS}/webapps/${PORTNAME}/WEB-INF/web.xml" ]; then \
-			${ECHO_MSG} "	Installing local configuration file: ${PREFIX}/${WEBAPP_DIRS}/webapps/${PORTNAME}/WEB-INF/web.xml"; \
-			${INSTALL_DATA} ${WRKSRC}/lib/${PORTNAME}/WEB-INF/web.xml.${CONF_EXT} ${PREFIX}/${WEBAPP_DIRS}/webapps/${PORTNAME}/WEB-INF/web.xml; \
+	@if [ ! -e "${PREFIX}/${WEBAPPS_DIR}/${PORTNAME}/WEB-INF/web.xml" ]; then \
+			${ECHO_MSG} "	Installing local configuration file: ${PREFIX}/${WEBAPPS_DIR}/${PORTNAME}/WEB-INF/web.xml"; \
+			${INSTALL_DATA} ${WRKSRC}/lib/${PORTNAME}/WEB-INF/web.xml.${CONF_EXT} ${PREFIX}/${WEBAPPS_DIR}/${PORTNAME}/WEB-INF/web.xml; \
 		else \
-			${ECHO_MSG} "	Preserving local configuration file: ${PREFIX}/${WEBAPP_DIRS}/webapps/${PORTNAME}/WEB-INF/web.xml"; \
+			${ECHO_MSG} "	Preserving local configuration file: ${PREFIX}/${WEBAPPS_DIR}/${PORTNAME}/WEB-INF/web.xml"; \
 	fi;
-	${INSTALL_DATA} ${WRKSRC}/lib/${PORTNAME}/WEB-INF/web.xml.${CONF_EXT} ${PREFIX}/${WEBAPP_DIRS}/webapps/${PORTNAME}/WEB-INF
+	${INSTALL_DATA} ${WRKSRC}/lib/${PORTNAME}/WEB-INF/web.xml.${CONF_EXT} ${PREFIX}/${WEBAPPS_DIR}/${PORTNAME}/WEB-INF
 
 	${MKDIR} ${DATADIR}/lib
 	${INSTALL_DATA} ${LIBFILES:S,^,${WRKSRC}/lib/lib/,} ${DATADIR}/lib/

Modified: head/devel/opengrok/pkg-plist
==============================================================================
--- head/devel/opengrok/pkg-plist	Tue Jan 29 15:49:10 2013	(r311169)
+++ head/devel/opengrok/pkg-plist	Tue Jan 29 16:20:00 2013	(r311170)
@@ -1,4 +1,4 @@
-@unexec if cmp -s %D%/%%T%%/webapps/opengrok/WEB-INF/web.xml %D%/%%T%%/webapps/opengrok/WEB-INF/web.xml.%%CONF_EXT%%; then rm -f %D%/%%T%%/webapps/opengrok/WEB-INF/web.xml; fi
+@unexec if cmp -s %D/%%T%%/webapps/opengrok/WEB-INF/web.xml %D/%%T%%/webapps/opengrok/WEB-INF/web.xml.%%CONF_EXT%%; then rm -f %D/%%T%%/webapps/opengrok/WEB-INF/web.xml; fi
 bin/opengrok
 %%PORTDOCS%%%%DOCSDIR%%/CHANGES.txt
 %%PORTDOCS%%%%DOCSDIR%%/EXAMPLE.txt
@@ -19,7 +19,7 @@ bin/opengrok
 %%T%%/webapps/opengrok/WEB-INF/lib/opengrok.jar
 %%T%%/webapps/opengrok/WEB-INF/lib/swing-layout-0.9.jar
 %%T%%/webapps/opengrok/WEB-INF/web.xml.%%CONF_EXT%%
-@exec if [ ! -f %D%/%%T%%/webapps/opengrok/WEB-INF/web.xml ]; then cp %D%/%%T%%/webapps/opengrok/WEB-INF/web.xml.%%CONF_EXT%% %D%/%%T%%/webapps/opengrok/WEB-INF/web.xml; fi
+@exec if [ ! -f %D/%%T%%/webapps/opengrok/WEB-INF/web.xml ]; then cp %D/%%T%%/webapps/opengrok/WEB-INF/web.xml.%%CONF_EXT%% %D/%%T%%/webapps/opengrok/WEB-INF/web.xml; fi
 %%T%%/webapps/opengrok/default/img/Logo.png
 %%T%%/webapps/opengrok/default/img/bg.png
 %%T%%/webapps/opengrok/default/img/button1.png
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Tom Judge freebsd_committer freebsd_triage 2013-01-29 16:21:13 UTC
State Changed
From-To: open->closed

Committed, with minor changes. Thanks!